Re: [edk2-devel] Removal of VS2015 (and maybe VS2017) and deprecated toolchains (GCC48, GCC49, GCC5)

["Rebecca Cran" <rebecca@bsdio.com>]

Personally I consider it too early to remove VS2017 (and VS2019).


Rebecca


On 11/24/24 10:56 AM, Kinney, Michael D wrote:
> I also see many references to VS2015, VS2017, and GCC5 in the edk2 repo
> outside of toolsdef.
>
> https://github.com/search?q=repo%3Atianocore%2Fedk2+VS2015&type=code
> https://github.com/search?q=repo%3Atianocore%2Fedk2+VS2017&type=code
> https://github.com/search?q=repo%3Atianocore%2Fedk2+GCC5&type=code
>
> These should be addressed in an independent set of PRs before removing
> the toolchains from toolsdef.
>
> The UefiPayloadPkg comments suggest you should discuss with those
> Maintainers to make sure the validation has moved to newer tool chains.
>
> Similar searches should be performed on all other TianoCore repos and
> updated as needed.
>
> Mike
>
>
>> -----Original Message-----
>> From: Kinney, Michael D <michael.d.kinney@intel.com>
>> Sent: Friday, November 22, 2024 4:02 PM
>> To: devel@edk2.groups.io; rebecca@os.amperecomputing.com; Rebecca Cran
>> <rebecca@bsdio.com>; leif.lindholm@oss.qualcomm.com
>> Cc: Kinney, Michael D <michael.d.kinney@intel.com>
>> Subject: RE: [edk2-devel] Removal of VS2015 (and maybe VS2017) and
>> deprecated toolchains (GCC48, GCC49, GCC5)
>>
>> VS1015, VS2017, GCC5
>>
>> Mike
>>
>>
>>> -----Original Message-----
>>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca
>>> Cran via groups.io
>>> Sent: Friday, November 22, 2024 2:30 PM
>>> To: devel@edk2.groups.io; Kinney, Michael D
>>> <michael.d.kinney@intel.com>; Rebecca Cran <rebecca@bsdio.com>;
>>> leif.lindholm@oss.qualcomm.com
>>> Subject: Re: [edk2-devel] Removal of VS2015 (and maybe VS2017) and
>>> deprecated toolchains (GCC48, GCC49, GCC5)
>>>
>>> All of them including GCC 4.8 and 4.9?
>>>
>>>
>>> Rebecca
>>>
>>>
>>> On 11/22/2024 2:08 PM, Michael D Kinney via groups.io wrote:
>>>> Hi Rebecca,
>>>>
>>>> Yes.  I have collected feedback.  I have found some use of these
>>> toolchains.
>>>> I do not have a date when the move to newer toolchains will be
>>> completed.
>>>> Mike
>>>>
>>>>> -----Original Message-----
>>>>> From: Rebecca Cran <rebecca@bsdio.com>
>>>>> Sent: Thursday, November 21, 2024 9:05 PM
>>>>> To: Kinney, Michael D <michael.d.kinney@intel.com>;
>>>>> devel@edk2.groups.io; leif.lindholm@oss.qualcomm.com
>>>>> Subject: Re: [edk2-devel] Removal of VS2015 (and maybe VS2017) and
>>>>> deprecated toolchains (GCC48, GCC49, GCC5)
>>>>>
>>>>> Hi Mike,
>>>>>
>>>>>
>>>>> I was wondering if you'd been able to collect any feedback or
>> review
>>> the
>>>>> proposal?
>>>>>
>>>>>
>>>>> Rebecca
>>>>>
>>>>>
>>>>> On 10/23/24 9:23 PM, Kinney, Michael D wrote:
>>>>>> Hi,
>>>>>>
>>>>>> I will need more time to review this impacts of this proposal.
>>>>>>
>>>>>> Can we extend the timeline for comments to mid November.
>>>>>>
>>>>>> Thanks,
>>>>>>
>>>>>> Mike
>>>>>>
>>>>>>> -----Original Message-----
>>>>>>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
>> Leif
>>>>>>> Lindholm via groups.io
>>>>>>> Sent: Tuesday, October 22, 2024 5:15 AM
>>>>>>> To: devel@edk2.groups.io; rebecca@bsdio.com
>>>>>>> Subject: Re: [edk2-devel] Removal of VS2015 (and maybe VS2017)
>> and
>>>>>>> deprecated toolchains (GCC48, GCC49, GCC5)
>>>>>>>
>>>>>>> On Tue, 22 Oct 2024 at 12:19, Rebecca Cran <rebecca@bsdio.com>
>>> wrote:
>>>>>>>> In addition, since GCC48, GCC49 and GCC5 have been marked
>>> deprecated
>>>>>>> for
>>>>>>>> over a year, I'd like to proceed with removing them as well.
>>>>>>>>
>>>>>>>> Please provide feedback by Thursday October 31st. In the absence
>>> of
>>>>>>>> feedback I'll plan to proceed with removing VS2015, GCC48, GCC49
>>> and
>>>>>>> GCC5.
>>>>>>>
>>>>>>> No comment on the VS ones, but for the GCC ones, I'm all for it.
>>>>>>>
>>>>>>> We might also want to raise an issue on deleting workarounds put
>>> into
>>>>>>> place for ancient toolchains.
>>>>>>> For gcc48/49 that was redundant initialization due to broken
>>>>>>> use-uninitialized detection.
>>>>>>> e.g.
>>>>>>>
>> https://github.com/tianocore/edk2/blob/master/OvmfPkg/Library/X86QemuLoa
>>>>>>> dImageLib/X86QemuLoadImageLib.c#L346
>>>>>>>
>>>>>>> /
>>>>>>>        Leif
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>
>>>>
>>>>
>>>
>>> 
>>>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120826): https://edk2.groups.io/g/devel/message/120826
Mute This Topic: https://groups.io/mt/109150018/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-