From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mx.groups.io with SMTP id smtpd.web10.97872.1683509542382423037 for ; Sun, 07 May 2023 18:32:22 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm1 header.b=zsP/LvuL; spf=pass (domain: bsdio.com, ip: 66.111.4.27, mailfrom: rebecca@bsdio.com) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id A76085C0109; Sun, 7 May 2023 21:32:21 -0400 (EDT) Received: from imap43 ([10.202.2.93]) by compute5.internal (MEProxy); Sun, 07 May 2023 21:32:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1683509541; x=1683595941; bh=P7xJ9XUJ7ZgN4Q3CfC2UDTDk+Kall0PNibV /I5SDTGk=; b=zsP/LvuLHy1g17ownluGGso3vIS8toZJv76DzY/O0i774TGMv/7 Jhwqubdd/Hy9+e8XF32+nabMDy+knAF5+vZgUKT2xuQQwORgRsPKKAxyhWKVIBZz bPwfpOxIq1rKzJS7ZFwY5G09f2DZp89vuAXV2VJBit+iLcy2+8pkBbavKWYJ4Zhv KKbnWhUjra3M4UgED5y0lARxAfQUX6cTN68VVeTCn+pFFYHItg1qJEk6JJHqgowo npUVxVY6oApwYQzan+AC8hKd9Ogk0nTvZO+9HaAUOnbBBbceeMvPdYOFMcA0jHn1 rrdGaDhpo6fXZ21ITI8gKzkDvOP5ezQjSoA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1683509541; x= 1683595941; bh=P7xJ9XUJ7ZgN4Q3CfC2UDTDk+Kall0PNibV/I5SDTGk=; b=Q KUMRNrxAuLY6EPDpHzNffi4fBHetLD1kRCsNq0Lvz7G/TzxVFa4jJTQuPZ0fCOZQ Zs3MWezHEn+56bA1J535RdnM7KiN6t4j2bags3z77GY7+l4CsWMRsOVnK8OzxFcB nsMAIDQlPhBjQN7v9duOOU5lKDO6ymSHEYTt0j5LzC5rhOo6xTqQZ/qMrOL8OSvt 94bml6X4EnlEo4arEhHtD0tk39ENUOMTtF065SPmWsUR++Fq8APhzwzQwRJJNrv4 JlB02Yug6hDnFdISCx/Ta0T6ZAMlqvuFbNPzcr6nexxLDGtEUYPWNU7n5fsbmLkU CQH7bfU8Uyf9cTG3xOjsQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeefjedggeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgfgsehtqhertderreejnecuhfhrohhmpedftfgv sggvtggtrgcuvehrrghnfdcuoehrvggsvggttggrsegsshguihhordgtohhmqeenucggtf frrghtthgvrhhnpeduvdegffffgefhieeiheejgfejgfelgffgfeejfefhveetkeduheei gfegueeutdenucffohhmrghinhepghhithhhuhgsrdgtohhmpdhgrhhouhhpshdrihhone cuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprhgvsggv tggtrgessghsughiohdrtghomh X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 1B5232D4008E; Sun, 7 May 2023 21:32:21 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-386-g2404815117-fm-20230425.001-g24048151 Mime-Version: 1.0 Message-Id: <4672f0d7-a84e-4e57-a11c-ec8f579d6f23@app.fastmail.com> In-Reply-To: <008101d9814c$a5018c60$ef04a520$@byosoft.com.cn> References: <20230506193052.1835-1-rebecca@bsdio.com> <008101d9814c$a5018c60$ef04a520$@byosoft.com.cn> Date: Sun, 07 May 2023 19:32:19 -0600 From: "Rebecca Cran" To: devel@edk2.groups.io, gaoliming , "Andrew Fish" , "Leif Lindholm" , "Kinney, Michael D" , "'Bob Feng'" , "'Yuwei Chen'" Subject: =?UTF-8?B?UmU6IFtlZGsyLWRldmVsXSDlm57lpI06IFtQQVRDSCB2MyAwLzRdIGVka3NldHVwLmJhdCwgQmFzZVRvb2xzOiBJbXByb3ZlIFdpbmRvd3MgZW52aXJvbm1lbnQgc2V0dXAgYW5kIEJhc2VUb29scyBDIGNvbXBpbGF0aW9u?= Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable I=E2=80=99ve removed the python 2 checks from edksetup.sh in the patch =E2= =80=9CRemove bashisms from edksetup.sh and BaseTools/BuildEnv=E2=80=9D that= I sent out a few days ago. Rebecca On Sun, May 7, 2023, at 7:30 PM, gaoliming via groups.io wrote: > Rebecca: > This change is good to me. Reviewed-by: Liming Gao cn> > =20 > But, I see edksetup.sh also has python2 check. I think the same clean u= p > can be done in edksetup.sh. > > Thanks > Liming >> -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- >> =E5=8F=91=E4=BB=B6=E4=BA=BA: Rebecca Cran >> =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2023=E5=B9=B45=E6=9C=887=E6=97=A5 = 3:31 >> =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; Andrew Fish ; Leif >> Lindholm ; Michael D Kinney >> ; Liming Gao ; >> Bob Feng ; Yuwei Chen >> =E6=8A=84=E9=80=81: Rebecca Cran >> =E4=B8=BB=E9=A2=98: [PATCH v3 0/4] edksetup.bat, BaseTools: Improve Wind= ows >> environment setup and BaseTools C compilation >>=20 >> There are remnants of Python 2 support in BaseTools/toolsetup.bat that > it's >> probably time to remove since we only support Python 3.6 and newer these >> days. >> So, remove the variables that enable Python3 support and simplify the > batch >> script. I've also seen errors where after running edksetup.bat the build >> command isn't available because PYTHONPATH wasn't being set, so fix that >> when the Pip BaseTools are being used. >>=20 >> At the same time, let's add a check that we meet the minimum version >> requirement so we don't end up failing with an obscure error. >>=20 >> Building BaseTools causes a warning about threading.currentThread being >> deprecated, so update code in NmakeSubdirs.py to switch to >> threading.current_thread. >>=20 >> There needs to be further work, because if PYTHON_COMMAND isn't >> specified then >> it defaults to "py -3", where py is C:\Windows\py.exe, which doesn't wor= k > if >> you're using a virtualenv since it installs python.exe and pythonw.exe i= n >> venv\Scripts. toolsetup.bat therefore fails to detect the Pip BaseTools > and >> uses the in-source Basetools. >>=20 >> GitHub PR: https://github.com/tianocore/edk2/pull/4302 >> GitHub branch: https://github.com/bcran/edk2/tree/py3 >>=20 >> Changes between v1 and v2 >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D >>=20 >> - Require Python 3.6 or newer: 3.6 was when PEP 526 was added, which we >> use. >> - Fix Tests/RunTests.py on Windows. >>=20 >> Rebecca Cran (4): >> BaseTools: Remove Python2/Python3 detection from toolset.bat >> BaseTools: use threading.current_thread in NmakeSubdirs.py >> edksetup.bat: if toolsetup.bat fails, just exit >> BaseTools: Update toolsetup.bat and Tests/PythonTest.py to check ver >>=20 >> BaseTools/Source/C/Makefiles/NmakeSubdirs.py | 2 +- >> BaseTools/Tests/PythonTest.py | 22 +++- >> BaseTools/toolsetup.bat | 119 >> ++++++++------------ >> edksetup.bat | 1 + >> 4 files changed, 69 insertions(+), 75 deletions(-) >>=20 >> -- >> 2.40.0.windows.1 > > > > > >=20