public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: Siyuan Fu <siyuan.fu@intel.com>, devel@edk2.groups.io
Cc: michael.d.kinney@intel.com, liming.gao@intel.com,
	eric.dong@intel.com, ray.ni@intel.com,
	Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [edk2-devel] [Patch 0/2] Shadow microcode patch according to FIT microcode table.
Date: Wed, 8 Jan 2020 11:36:04 +0100	[thread overview]
Message-ID: <46741ce3-6d78-d4a4-8f3d-822b1d49cd07@redhat.com> (raw)
In-Reply-To: <27dad7c9-0b89-4edb-6b5b-a47820068fe4@redhat.com>

On 01/08/20 10:42, Laszlo Ersek wrote:

> In closing: it seems short-sighted that the FIT specification placed a
> "naked" pointer at a fixed offset in flash, rather than a three-field
> structure consisting of:
> - a GUID,
> - preceded by a structure size,
> - preceded by the FIT pointer.
> 
> Because, using a GUID-ed approach, the chance to *incorrectly* deduce
> "yes FIT" would be 1 in (2^128) -- all 128-bit values except one magic
> value would indicate "no FIT". That's good.
> 
> Whereas, with the spec's current "naked pointer" approach, the chance to
> *correctly* deduce "yes FIT" is 3 in (2^64) -- all 64-bit values except
> three magic values indicate "yes FIT". Not good.

Sorry I messed up the first half of the last paragraph. I meant:

With the spec's current "naked pointer" approach, the chance to
incorrectly deduce "yes FIT" is ((2^64)-3) in (2^64). So an incorrect
decision is almost certain.

Thanks
Laszlo


  reply	other threads:[~2020-01-08 10:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-08  4:25 [Patch 0/2] Shadow microcode patch according to FIT microcode table Siyuan, Fu
2020-01-08  4:25 ` [Patch 1/2] MdePkg: Add header file for Firmware Interface Table specification Siyuan, Fu
2020-01-08  4:25 ` [Patch 2/2] UefiCpuPkg: Shadow microcode patch according to FIT microcode entry Siyuan, Fu
2020-01-08  9:42 ` [Patch 0/2] Shadow microcode patch according to FIT microcode table Laszlo Ersek
2020-01-08 10:36   ` Laszlo Ersek [this message]
2020-01-08 10:58   ` Siyuan, Fu
2020-01-08 12:18     ` Laszlo Ersek
2020-01-09  2:04 ` Liming Gao
2020-01-09  2:12   ` Siyuan, Fu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46741ce3-6d78-d4a4-8f3d-822b1d49cd07@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox