From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, maciej.rabeda@linux.intel.com
Cc: "Jiaxin Wu" <jiaxin.wu@intel.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Siyuan Fu" <siyuan.fu@intel.com>
Subject: Re: [edk2-devel] [PATCH v2 0/6] NetworkPkg/IScsiDxe: support SHA256 in CHAP
Date: Wed, 30 Jun 2021 22:33:39 +0200 [thread overview]
Message-ID: <4689cc3f-ff0b-38ae-eba5-69fc35f7556e@redhat.com> (raw)
In-Reply-To: <7d90e66a-8fb7-3772-3aa2-013c8d4a38fb@linux.intel.com>
On 06/29/21 20:44, Maciej Rabeda wrote:
> Thanks, Laszlo. I really like moving the condition out of 'if' clause in
> IScsiCHAPAuthTarget :)
>
> For the patchset:
> Reviewed-by: Maciej Rabeda <maciej.rabeda@linux.intel.com>
Thank you!
Merged as commit range 3cde0d553d93..bb33c27fbed6, via
<https://github.com/tianocore/edk2/pull/1780>.
Laszlo
>
> On 29-Jun-21 18:33, Laszlo Ersek wrote:
>> Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=3355
>> Repo: https://pagure.io/lersek/edk2.git
>> Branch: iscsi_sha256_bz3355_v2 (at commit 73b92e85b4de)
>> CI: https://github.com/tianocore/edk2/pull/1772
>>
>> v1 was posted at:
>>
>> * [edk2-devel] [PATCH 0/6] NetworkPkg/IScsiDxe: support SHA256 in CHAP
>>
>> Message-Id: <20210608130652.2434-1-lersek@redhat.com>
>>
>> https://listman.redhat.com/archives/edk2-devel-archive/2021-June/msg00331.html
>>
>> https://edk2.groups.io/g/devel/message/76213
>> https://bugzilla.tianocore.org/show_bug.cgi?id=3355#c3
>>
>> v2 addresses the v1 review feedback. Please see the Notes section on
>> every patch.
>>
>> v2 has been retested, with results identical to those of v1. (Please see
>> the v1 blurb for details.)
>>
>> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
>> Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>
>> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
>> Cc: Siyuan Fu <siyuan.fu@intel.com>
>>
>> Thanks,
>> Laszlo
>>
>> Laszlo Ersek (6):
>> NetworkPkg/IScsiDxe: re-set session-level authentication state before
>> login
>> NetworkPkg/IScsiDxe: add horizontal whitespace to IScsiCHAP files
>> NetworkPkg/IScsiDxe: distinguish "maximum" and "selected" CHAP digest
>> sizes
>> NetworkPkg/IScsiDxe: support multiple hash algorithms for CHAP
>> NetworkPkg/IScsiDxe: support SHA256 in CHAP
>> NetworkPkg: introduce the NETWORK_ISCSI_MD5_ENABLE feature test macro
>>
>> NetworkPkg/IScsiDxe/IScsiCHAP.c | 204 ++++++++++++++++----
>> NetworkPkg/IScsiDxe/IScsiCHAP.h | 95 +++++++--
>> NetworkPkg/IScsiDxe/IScsiDriver.c | 2 +
>> NetworkPkg/IScsiDxe/IScsiProto.c | 21 ++
>> NetworkPkg/NetworkBuildOptions.dsc.inc | 2 +-
>> NetworkPkg/NetworkDefines.dsc.inc | 20 ++
>> 6 files changed, 293 insertions(+), 51 deletions(-)
>>
>>
>> base-commit: b37cfdd2807181aed2fee1e17bd7ec1190db266a
>
>
>
>
>
>
prev parent reply other threads:[~2021-06-30 20:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-29 16:33 [PATCH v2 0/6] NetworkPkg/IScsiDxe: support SHA256 in CHAP Laszlo Ersek
2021-06-29 16:33 ` [PATCH v2 1/6] NetworkPkg/IScsiDxe: re-set session-level authentication state before login Laszlo Ersek
2021-06-29 16:33 ` [PATCH v2 2/6] NetworkPkg/IScsiDxe: add horizontal whitespace to IScsiCHAP files Laszlo Ersek
2021-06-29 16:33 ` [PATCH v2 3/6] NetworkPkg/IScsiDxe: distinguish "maximum" and "selected" CHAP digest sizes Laszlo Ersek
2021-06-29 16:33 ` [PATCH v2 4/6] NetworkPkg/IScsiDxe: support multiple hash algorithms for CHAP Laszlo Ersek
2021-06-29 16:33 ` [PATCH v2 5/6] NetworkPkg/IScsiDxe: support SHA256 in CHAP Laszlo Ersek
2021-06-29 16:33 ` [PATCH v2 6/6] NetworkPkg: introduce the NETWORK_ISCSI_MD5_ENABLE feature test macro Laszlo Ersek
2021-06-29 18:44 ` [edk2-devel] [PATCH v2 0/6] NetworkPkg/IScsiDxe: support SHA256 in CHAP Maciej Rabeda
2021-06-30 20:33 ` Laszlo Ersek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4689cc3f-ff0b-38ae-eba5-69fc35f7556e@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox