From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.2590.1625085230180580832 for ; Wed, 30 Jun 2021 13:33:50 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=blnRAa0D; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625085229; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6MydFgBlrm+En2o0cvq/vxphxSEzo0Q/IAqNY19TMDc=; b=blnRAa0DwJYCI2qT9GPDStavXTDKKBRfIst1WteeKlRWKn85S5g4FK0Vggv1FpXdUXDejm qHcpT+LJu25kUkXrCPl5QQFyWuBN0jab09NylgEp4qoOyGeSmNc1oCo/1QlIwUvKqdPeGz nKN1xULMO68+PzrLwdBlI5xuym4IqDM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-242-QCawcVrUOh6SAtteiyF_wQ-1; Wed, 30 Jun 2021 16:33:44 -0400 X-MC-Unique: QCawcVrUOh6SAtteiyF_wQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E9FCEA40C0; Wed, 30 Jun 2021 20:33:42 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-100.ams2.redhat.com [10.36.112.100]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BC1E419C79; Wed, 30 Jun 2021 20:33:40 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v2 0/6] NetworkPkg/IScsiDxe: support SHA256 in CHAP To: devel@edk2.groups.io, maciej.rabeda@linux.intel.com Cc: Jiaxin Wu , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Siyuan Fu References: <20210629163337.14120-1-lersek@redhat.com> <7d90e66a-8fb7-3772-3aa2-013c8d4a38fb@linux.intel.com> From: "Laszlo Ersek" Message-ID: <4689cc3f-ff0b-38ae-eba5-69fc35f7556e@redhat.com> Date: Wed, 30 Jun 2021 22:33:39 +0200 MIME-Version: 1.0 In-Reply-To: <7d90e66a-8fb7-3772-3aa2-013c8d4a38fb@linux.intel.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 06/29/21 20:44, Maciej Rabeda wrote: > Thanks, Laszlo. I really like moving the condition out of 'if' clause in > IScsiCHAPAuthTarget :) > > For the patchset: > Reviewed-by: Maciej Rabeda Thank you! Merged as commit range 3cde0d553d93..bb33c27fbed6, via . Laszlo > > On 29-Jun-21 18:33, Laszlo Ersek wrote: >> Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=3355 >> Repo:     https://pagure.io/lersek/edk2.git >> Branch:   iscsi_sha256_bz3355_v2 (at commit 73b92e85b4de) >> CI:       https://github.com/tianocore/edk2/pull/1772 >> >> v1 was posted at: >> >> * [edk2-devel] [PATCH 0/6] NetworkPkg/IScsiDxe: support SHA256 in CHAP >> >>    Message-Id: <20210608130652.2434-1-lersek@redhat.com> >>    >> https://listman.redhat.com/archives/edk2-devel-archive/2021-June/msg00331.html >> >>    https://edk2.groups.io/g/devel/message/76213 >>    https://bugzilla.tianocore.org/show_bug.cgi?id=3355#c3 >> >> v2 addresses the v1 review feedback. Please see the Notes section on >> every patch. >> >> v2 has been retested, with results identical to those of v1. (Please see >> the v1 blurb for details.) >> >> Cc: Jiaxin Wu >> Cc: Maciej Rabeda >> Cc: Philippe Mathieu-Daudé >> Cc: Siyuan Fu >> >> Thanks, >> Laszlo >> >> Laszlo Ersek (6): >>    NetworkPkg/IScsiDxe: re-set session-level authentication state before >>      login >>    NetworkPkg/IScsiDxe: add horizontal whitespace to IScsiCHAP files >>    NetworkPkg/IScsiDxe: distinguish "maximum" and "selected" CHAP digest >>      sizes >>    NetworkPkg/IScsiDxe: support multiple hash algorithms for CHAP >>    NetworkPkg/IScsiDxe: support SHA256 in CHAP >>    NetworkPkg: introduce the NETWORK_ISCSI_MD5_ENABLE feature test macro >> >>   NetworkPkg/IScsiDxe/IScsiCHAP.c        | 204 ++++++++++++++++---- >>   NetworkPkg/IScsiDxe/IScsiCHAP.h        |  95 +++++++-- >>   NetworkPkg/IScsiDxe/IScsiDriver.c      |   2 + >>   NetworkPkg/IScsiDxe/IScsiProto.c       |  21 ++ >>   NetworkPkg/NetworkBuildOptions.dsc.inc |   2 +- >>   NetworkPkg/NetworkDefines.dsc.inc      |  20 ++ >>   6 files changed, 293 insertions(+), 51 deletions(-) >> >> >> base-commit: b37cfdd2807181aed2fee1e17bd7ec1190db266a > > > > > >