Re: [edk2-devel] [PATCH v2 02/11] ArmPkg/ArmScmiDxe: Add PERFORMANCE_DESCRIBE_FASTCHANNEL support

["Leif Lindholm" <quic_llindhol@quicinc.com>]

On 2023-11-02 10:19, PierreGondois wrote:

>>> +/// SCMI Message Ids for the Performance Protocol.
>>> +typedef enum {
>>> +  ScmiMessageIdPerformanceDomainAttributes    = 0x3,
>>> +  ScmiMessageIdPerformanceDescribeLevels      = 0x4,
>>> +  ScmiMessageIdPerformanceLimitsSet           = 0x5,
>>> +  ScmiMessageIdPerformanceLimitsGet           = 0x6,
>>> +  ScmiMessageIdPerformanceLevelSet            = 0x7,
>>> +  ScmiMessageIdPerformanceLevelGet            = 0x8,
>>> +  ScmiMessageIdPerformanceDescribeFastchannel = 0xB,
>>> +} SCMI_MESSAGE_ID_PERFORMANCE;
>>
>> This struct appears to move in the code at the same time as having an
>> entry added to it. This seems superficially unmotivated.
>> However it is also moved to inside the pack(1) block, which makes no
>> sense for an enum.
> 
> Yes right, I will move it out of the pack(1) section.

Thx, with that change:
Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com>

> The reason to move the SCMI_MESSAGE_ID_PERFORMANCE definition up in the 
> file
> was that the SCMI_PERFORMANCE_DESCRIBE_FASTCHANNEL interface added in this
> patch takes a SCMI_MESSAGE_ID_PERFORMANCE parameter as an argument, so the
> enum needs to be defined before.
> I can add a comment about this in the commit message.

It doesn't really need to be in the commit message, but it's the kind of 
thing that can be helpful to point out below ---.

Regards,

Leif



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110527): https://edk2.groups.io/g/devel/message/110527
Mute This Topic: https://groups.io/mt/102175812/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-