From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 4397DD8081E for ; Thu, 2 Nov 2023 13:32:44 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=0OpAKsnTF0OXC8PSFCmhwj9EvsBBNiD7Pk7/pLx4i+M=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:CC:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698931963; v=1; b=tD8f/nMSPyZ/HpAkdEaQN9HfoI5mj0IQr23Q5uyHhzIHH2yW/n4HpxLuqiB/aelqfd6M3H6P UImHL1l6PYuvpW3abvueDUYNYrrqq+8siV6QB3ClbxaiEP01pk0m77D/Ki+2r+E1hgaqBr29vib x/DUFkNW5/V9fq6u+H8b/FPg= X-Received: by 127.0.0.2 with SMTP id BfdzYY7687511xGPrT6xbG5T; Thu, 02 Nov 2023 06:32:43 -0700 X-Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by mx.groups.io with SMTP id smtpd.web11.30815.1698931962322204531 for ; Thu, 02 Nov 2023 06:32:42 -0700 X-Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3A2BY6vt010226; Thu, 2 Nov 2023 13:32:32 GMT X-Received: from nasanppmta03.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3u3y5y1gwv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 02 Nov 2023 13:32:32 +0000 X-Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3A2DWVtD023705 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 2 Nov 2023 13:32:31 GMT X-Received: from [10.111.137.10] (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.39; Thu, 2 Nov 2023 06:32:29 -0700 Message-ID: <4697620c-5391-44c7-821d-ce1fb84b5c26@quicinc.com> Date: Thu, 2 Nov 2023 13:32:26 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v2 02/11] ArmPkg/ArmScmiDxe: Add PERFORMANCE_DESCRIBE_FASTCHANNEL support To: , CC: Sami Mujawar , Ard Biesheuvel , Michael D Kinney , Liming Gao References: <20231025112540.1654844-1-pierre.gondois@arm.com> <20231025112540.1654844-3-pierre.gondois@arm.com> <731fa125-5a47-40d2-8062-d2ff8011cc23@arm.com> From: "Leif Lindholm" In-Reply-To: <731fa125-5a47-40d2-8062-d2ff8011cc23@arm.com> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-GUID: NQGbaa7W-BoVcBsGFSzJfE9tvcsBuGt1 X-Proofpoint-ORIG-GUID: NQGbaa7W-BoVcBsGFSzJfE9tvcsBuGt1 X-MIME-Autoconverted: from 8bit to quoted-printable by mx0a-0031df01.pphosted.com id 3A2BY6vt010226 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,quic_llindhol@quicinc.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: KXHpjUAubdBzckCs615xr3fRx7686176AA= Content-Language: en-GB Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="tD8f/nMS"; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=quicinc.com (policy=none) On 2023-11-02 10:19, PierreGondois wrote: >>> +/// SCMI Message Ids for the Performance Protocol. >>> +typedef enum { >>> +=C2=A0 ScmiMessageIdPerformanceDomainAttributes=C2=A0=C2=A0=C2=A0 =3D = 0x3, >>> +=C2=A0 ScmiMessageIdPerformanceDescribeLevels=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 =3D 0x4, >>> +=C2=A0 ScmiMessageIdPerformanceLimitsSet=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =3D 0x5, >>> +=C2=A0 ScmiMessageIdPerformanceLimitsGet=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =3D 0x6, >>> +=C2=A0 ScmiMessageIdPerformanceLevelSet=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =3D 0x7, >>> +=C2=A0 ScmiMessageIdPerformanceLevelGet=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =3D 0x8, >>> +=C2=A0 ScmiMessageIdPerformanceDescribeFastchannel =3D 0xB, >>> +} SCMI_MESSAGE_ID_PERFORMANCE; >> >> This struct appears to move in the code at the same time as having an >> entry added to it. This seems superficially unmotivated. >> However it is also moved to inside the pack(1) block, which makes no >> sense for an enum. >=20 > Yes right, I will move it out of the pack(1) section. Thx, with that change: Reviewed-by: Leif Lindholm > The reason to move the SCMI_MESSAGE_ID_PERFORMANCE definition up in the= =20 > file > was that the SCMI_PERFORMANCE_DESCRIBE_FASTCHANNEL interface added in thi= s > patch takes a SCMI_MESSAGE_ID_PERFORMANCE parameter as an argument, so th= e > enum needs to be defined before. > I can add a comment about this in the commit message. It doesn't really need to be in the commit message, but it's the kind of=20 thing that can be helpful to point out below ---. Regards, Leif -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110527): https://edk2.groups.io/g/devel/message/110527 Mute This Topic: https://groups.io/mt/102175812/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-