From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mout01.posteo.de (mout01.posteo.de [185.67.36.65])
 by mx.groups.io with SMTP id smtpd.web10.2320.1681800030716863383
 for <devel@edk2.groups.io>;
 Mon, 17 Apr 2023 23:40:31 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@posteo.de header.s=2017 header.b=jT+ZAn2b;
 spf=pass (domain: posteo.de, ip: 185.67.36.65, mailfrom: mhaeuser@posteo.de)
Received: from submission (posteo.de [185.67.36.169]) 
	by mout01.posteo.de (Postfix) with ESMTPS id B1CF52401FC
	for <devel@edk2.groups.io>; Tue, 18 Apr 2023 08:40:28 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017;
	t=1681800028; bh=C1BNj2cRh1GNWiLcmwkilTu0FeN7xMQiD5XRjJEBTrQ=;
	h=From:Subject:Date:Cc:To:From;
	b=jT+ZAn2bb/1Zh7pQXBjCJdZFYghrr+s5ex3L+lD+UVkdJNvTiDHqo8HOdxP/Va4C6
	 YAbNlCbRCjHG5MUTm0iKxctDEydNw4SnFtP1Xb2ygOLyA8kuauQccrr/bH0SBfXXVD
	 9jsYjS1s75KhgUuWKMzeLUu35+iJ9hacPaMn3ZyeNGs1oZxCn0ipaK7e7h4CAhfdaq
	 AIZDp0/oiNZyTbsU4WJreg6xT4VzSK/3hZQsd9Z9ob1j2FBY5+8D/VmkRhXkLaglmv
	 +F6Csd4TiA0oHXuRRB4bNOPyY20iGrlrj1mASV627X4w/MFDk8/xxJLkCHYOUxv8xC
	 gVW56Gvz61osQ==
Received: from customer (localhost [127.0.0.1])
	by submission (posteo.de) with ESMTPSA id 4Q0vSC4Znqz9rxH;
	Tue, 18 Apr 2023 08:40:27 +0200 (CEST)
From: =?UTF-8?B?TWFydmluIEjDpHVzZXI=?= <mhaeuser@posteo.de>
Mime-Version: 1.0 (1.0)
Subject: Re: [PATCH 1/2] ArmPkg/AsmMacroIoLibV8: Introduce ASM_FUNC_ALIGN()
Date: Tue, 18 Apr 2023 06:40:27 +0000
Message-Id: <46CED01C-BEA6-49F3-9634-051DC63D248C@posteo.de>
References: <CAMj1kXHMbafkf8WMm0xRUUHvdtq3crEM8c_fcnfX_jUQGvkgFQ@mail.gmail.com>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>, devel@edk2.groups.io,
 Ard Biesheuvel <ardb+tianocore@kernel.org>,
 Sami Mujawar <sami.mujawar@arm.com>,
 Vitaly Cheptsov <vit9696@protonmail.com>
In-Reply-To: <CAMj1kXHMbafkf8WMm0xRUUHvdtq3crEM8c_fcnfX_jUQGvkgFQ@mail.gmail.com>
To: Ard Biesheuvel <ardb@kernel.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


> On 17. Apr 2023, at 23:18, Ard Biesheuvel <ardb@kernel.org> wrote:
>=20
> Agree with all of this.
>=20
> And thanks for tracking this down - must not have been fun :-)

No worries - it wasn=E2=80=99t. :) It was mere luck Vitaly discovered early i=
t was an issue that triggered based on the binary layout rather than a bug i=
n the mapping code itself=E2=80=A6

Speaking of not fun to track down, I initially wanted to add ASSERTs (yes, r=
untime :( ) to check the alignment guarantee is actually met. Leif basically=
 declined any form of regression-testing at runtime. Do you happen to have a=
 simple(!) idea for how it could be checked at build-time? (It=E2=80=99s les=
s about =E2=80=9Cwhich commands do I run?=E2=80=9D and more about integratio=
n with the build process / BaseTools, cross-OS compatibility, etc.)

Thanks!

Best regards,
Marvin=