From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=17.151.62.67; helo=nwk-aaemail-lapp02.apple.com; envelope-from=afish@apple.com; receiver=edk2-devel@lists.01.org Received: from nwk-aaemail-lapp02.apple.com (nwk-aaemail-lapp02.apple.com [17.151.62.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2D2E9211D59DB for ; Thu, 14 Mar 2019 22:54:35 -0700 (PDT) Received: from pps.filterd (nwk-aaemail-lapp02.apple.com [127.0.0.1]) by nwk-aaemail-lapp02.apple.com (8.16.0.27/8.16.0.27) with SMTP id x2F5qKMV055122; Thu, 14 Mar 2019 22:54:34 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=apple.com; h=mime-version : content-transfer-encoding : content-type : sender : subject : from : in-reply-to : date : cc : message-id : references : to; s=20180706; bh=o4bTeUNv/gPbGR9qBiV5rOBBvEbPrmTRCGfKivsmFLQ=; b=SaMdJ3O+MEPoNZuwhSN8sOIxTJFOnFMxjexraMhsWta1pXlIToAM4+VcKasHCy2fKN24 QEpAzUMKkOBT2g6cixs7ndWER7joN/aXKOxdhRNc3ahy8sIxEYOQCp/c4TkACnDkfxkp 2t6IgU6h/bIalyIitthWD+IJfcjLGAkmulGvZIl0s+dO2ZOuQOlUmFhH6bXO8yu9gcWS 4QK0PDEH7RJ0iA0Qc6eowvkIMpLrHFpcEEZEPUDBAVfpWO9G0xniOsd7YzDE/trWWuz4 X1AtGw9hkzsmuso0NCl57aXrL9CRhVfmLSBhoAvTySyOY/UyigszF/jKv9T7BCVmY3xN ig== Received: from mr2-mtap-s01.rno.apple.com (mr2-mtap-s01.rno.apple.com [17.179.226.133]) by nwk-aaemail-lapp02.apple.com with ESMTP id 2r4axunjd8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Thu, 14 Mar 2019 22:54:34 -0700 MIME-version: 1.0 Received: from ma1-mmpp-sz10.apple.com (ma1-mmpp-sz10.apple.com [17.171.128.150]) by mr2-mtap-s01.rno.apple.com (Oracle Communications Messaging Server 8.0.2.3.20181024 64bit (built Oct 24 2018)) with ESMTPS id <0POE00DZ58EXAS00@mr2-mtap-s01.rno.apple.com>; Thu, 14 Mar 2019 22:54:34 -0700 (PDT) Received: from process_milters-daemon.ma1-mmpp-sz10.apple.com by ma1-mmpp-sz10.apple.com (Oracle Communications Messaging Server 8.0.2.3.20181024 64bit (built Oct 24 2018)) id <0POE005008CKPU00@ma1-mmpp-sz10.apple.com>; Thu, 14 Mar 2019 22:54:33 -0700 (PDT) X-Va-A: X-Va-T-CD: 7c79dbb72c71e7cb0fe94f9df7a028fc X-Va-E-CD: 9514e9dff740239d8eed7530a702a736 X-Va-R-CD: ee4dd937949f1fe2c0baf61d5cef464e X-Va-CD: 0 X-Va-ID: b7ee733d-571e-4c98-a2d3-09e4863ee639 X-V-A: X-V-T-CD: 1bb13ab932281aed37ba6e1b2fbc2545 X-V-E-CD: 9514e9dff740239d8eed7530a702a736 X-V-R-CD: ee4dd937949f1fe2c0baf61d5cef464e X-V-CD: 0 X-V-ID: 741bb77f-9f99-4b3b-95cc-746f503f3493 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-03-15_05:,, signatures=0 Received: from [17.234.162.250] (unknown [17.234.162.250]) by ma1-mmpp-sz10.apple.com (Oracle Communications Messaging Server 8.0.2.3.20181024 64bit (built Oct 24 2018)) with ESMTPSA id <0POE003AY8EV5T80@ma1-mmpp-sz10.apple.com>; Thu, 14 Mar 2019 22:54:33 -0700 (PDT) Sender: afish@apple.com From: Andrew Fish In-reply-to: <20190315051749.6564-18-zhichao.gao@intel.com> Date: Thu, 14 Mar 2019 22:54:24 -0700 Cc: edk2-devel , Bret Barkelew , Hao Wu , Michael Turner , Star Zeng Message-id: <46E887C8-DAAB-4855-BB70-69066F6B45FD@apple.com> References: <20190315051749.6564-1-zhichao.gao@intel.com> <20190315051749.6564-18-zhichao.gao@intel.com> To: Zhichao Gao , Mike Kinney , "Gao, Liming" X-Mailer: Apple Mail (2.3445.6.18) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-03-15_05:, , signatures=0 Subject: Re: [PATCH V2 17/17] MdeModulePkg: Add PEIM and lib to dsc file X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Mar 2019 05:54:35 -0000 Content-transfer-encoding: 7BIT Content-type: text/plain; CHARSET=US-ASCII I understand the motivation for this change as I've done something much less portable that looks a lot like this to save the PEI XIP space.... I seem to remember a long time ago we add a public VA_LIST to an API and we ran into an issue due to the marker format being compiler specific. You don't tend to see this on VC++ as it mostly uses a pointer to the frame, but GCC and clang can use a data structure especially not on IA32 (i386) for a VA_LIST (this is part of the reason there are so many #ifdefs in the Base.h VA_LIST section). In the past to fix this Mike Kinney added BASE_LIST. I seem to remember MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode passes a BASE_LIST into ReportStatusCode vs. a VA_LIST for this reason. Was this VA_LIST portability concern taken into consideration for this new API? In general VA_LIST is not an issue as long as all the code is compiled with the same compiler but if binaries are in play then you can have issues. So things like FSB, Option ROMs, OS Loaders, EFI Shell, EFI Apps. are when you can see the issue. Thanks, Andrew Fish > On Mar 14, 2019, at 10:17 PM, Zhichao Gao wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395 > > Add the new PEIM DebugServicePei and library instance > PeiDebugLibDebugPpi to dsc file to verify it can build > correctly. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Zhichao Gao > Cc: Jian J Wang > Cc: Hao Wu > Cc: Ray Ni > Cc: Star Zeng > Cc: Liming Gao > Cc: Sean Brogan > Cc: Michael Turner > Cc: Bret Barkelew > --- > MdeModulePkg/MdeModulePkg.dsc | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/MdeModulePkg/MdeModulePkg.dsc b/MdeModulePkg/MdeModulePkg.dsc > index 6cd1727a0d..dec441e23e 100644 > --- a/MdeModulePkg/MdeModulePkg.dsc > +++ b/MdeModulePkg/MdeModulePkg.dsc > @@ -297,6 +297,7 @@ > MdeModulePkg/Library/PlatformHookLibSerialPortPpi/PlatformHookLibSerialPortPpi.inf > MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf > MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf > + MdeModulePkg/Library/PeiDebugLibDebugPpi/PeiDebugLibDebugPpi.inf > MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf > MdeModulePkg/Library/PlatformBootManagerLibNull/PlatformBootManagerLibNull.inf > MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf > @@ -423,6 +424,8 @@ > MdeModulePkg/Universal/SerialDxe/SerialDxe.inf > MdeModulePkg/Universal/LoadFileOnFv2/LoadFileOnFv2.inf > > + MdeModulePkg/Universal/DebugServicePei/DebugServicePei.inf > + > MdeModulePkg/Application/CapsuleApp/CapsuleApp.inf > MdeModulePkg/Library/FmpAuthenticationLibNull/FmpAuthenticationLibNull.inf > MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.inf > -- > 2.16.2.windows.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel