Re: [edk2-devel] [Patch v3 2/2] MdeModulePkg/Core/Dxe: Set MemoryTypeInfo bin range from HOB

["Laszlo Ersek" <lersek@redhat.com>]

On 1/29/24 19:58, Michael D Kinney wrote:

> +  if (mMemoryTypeInformationInitialized) {
> +    DEBUG ((DEBUG_ERROR, "CoreSetMemoryTypeInformationRange() ignored. Bins already set."));
> +    return;
> +  }

Two suggestions for the DEBUG:

- %a with __func__ is shorter / more robust than open-coding the
function name

- a newline character \n is missing from the end of the message.

I think just these comments don't need a v4 posting; I'd suggest editing
the patch upon merge.

Series
Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks!
Laszlo



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114802): https://edk2.groups.io/g/devel/message/114802
Mute This Topic: https://groups.io/mt/104038200/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-