From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 5D509941CDF for ; Tue, 30 Jan 2024 16:39:51 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=WIaqUqawYevs0qaB3wxsGMdQodHHYkiw+uRWxJSZPho=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1706632789; v=1; b=ci612F9Sk4Ynawad+Uk4ngxbtpqhqfi1EtNLUW0lWEWr0y6pHPPk5Xni8iBVC1XGRhhfLOj7 RfFeGeRI8PK6muaN+5TXI2f6RMpMy5KHdmVrM8bfgEUSKYi4aAFcp17o4LeHGbCiUsMZDK84r/c 45/+YgG+fyLfPGvLYO868jR8= X-Received: by 127.0.0.2 with SMTP id cO78YY7687511xZbpaJqBoZB; Tue, 30 Jan 2024 08:39:49 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.776.1706632789265287098 for ; Tue, 30 Jan 2024 08:39:49 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-651-PIsI1McYO_eyU07gqVYfGw-1; Tue, 30 Jan 2024 11:39:44 -0500 X-MC-Unique: PIsI1McYO_eyU07gqVYfGw-1 X-Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8F394101366B; Tue, 30 Jan 2024 16:39:43 +0000 (UTC) X-Received: from [10.39.192.28] (unknown [10.39.192.28]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 12BB4217B400; Tue, 30 Jan 2024 16:39:41 +0000 (UTC) Message-ID: <46bb68d3-4a33-a880-4b67-758c5d5153ec@redhat.com> Date: Tue, 30 Jan 2024 17:39:40 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [Patch v3 2/2] MdeModulePkg/Core/Dxe: Set MemoryTypeInfo bin range from HOB To: Michael D Kinney , devel@edk2.groups.io Cc: Liming Gao , Aaron Li , Liu Yun , Andrew Fish References: <20240129185808.776-1-michael.d.kinney@intel.com> <20240129185808.776-3-michael.d.kinney@intel.com> From: "Laszlo Ersek" In-Reply-To: <20240129185808.776-3-michael.d.kinney@intel.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: GFUqFl2HBmLWySJuwvhB0ucIx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=ci612F9S; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 1/29/24 19:58, Michael D Kinney wrote: > + if (mMemoryTypeInformationInitialized) { > + DEBUG ((DEBUG_ERROR, "CoreSetMemoryTypeInformationRange() ignored. B= ins already set.")); > + return; > + } Two suggestions for the DEBUG: - %a with __func__ is shorter / more robust than open-coding the function name - a newline character \n is missing from the end of the message. I think just these comments don't need a v4 posting; I'd suggest editing the patch upon merge. Series Reviewed-by: Laszlo Ersek Thanks! Laszlo -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114802): https://edk2.groups.io/g/devel/message/114802 Mute This Topic: https://groups.io/mt/104038200/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-