From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124])
 by mx.groups.io with SMTP id smtpd.web08.581.1616693722548928267
 for <devel@edk2.groups.io>;
 Thu, 25 Mar 2021 10:35:22 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DGm7DLk5;
 spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1616693721;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=0SYtF4CtdKmJrFucY9RILDKKq7GaisuXgeyKF6dbrtg=;
	b=DGm7DLk5i/uJiNPvKV6tzw2K2kRI6rbifirKN/vkgzOPP1eBRkobN6HagjNrdkDja1aK+M
	sO6/KjpQ1sFg/u8qSDRV2EhbPAW74jJDOcnp3uij4MLrORB8/nDIAXeAIxBoaGijGwO25K
	sXH2XyRBb5do8qA7LRM0xL2UEZrNgJ0=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-337-NpSgEA7EO4ax7nCaJEbB_g-1; Thu, 25 Mar 2021 13:35:17 -0400
X-MC-Unique: NpSgEA7EO4ax7nCaJEbB_g-1
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CF074A0CA1;
	Thu, 25 Mar 2021 17:35:15 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-200.ams2.redhat.com [10.36.114.200])
	by smtp.corp.redhat.com (Postfix) with ESMTP id D49265D736;
	Thu, 25 Mar 2021 17:35:14 +0000 (UTC)
Subject: Re: [edk2-devel] [Patch V2 0/2] Let AcpiTableDxe driver install Acpi table from Hob
To: Andrew Fish <afish@apple.com>, edk2-devel-groups-io
 <devel@edk2.groups.io>, ray.ni@intel.com
Cc: Benjamin Doron <benjamin.doron00@gmail.com>
References: <8ecc6ec1-f7a0-7878-ef57-b58f99bc3af2@redhat.com>
 <8402.1616604928827766426@groups.io>
 <2e602df8-b1fc-193b-f61a-86802ace9108@redhat.com>
 <CO1PR11MB4930D853B53167496EE1DA878C629@CO1PR11MB4930.namprd11.prod.outlook.com>
 <DDE554E1-DEFF-4BD5-8562-07BFA02841D6@apple.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <46cbc300-0909-3c2e-92f7-0244d2d8022d@redhat.com>
Date: Thu, 25 Mar 2021 18:35:14 +0100
MIME-Version: 1.0
In-Reply-To: <DDE554E1-DEFF-4BD5-8562-07BFA02841D6@apple.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit

On 03/25/21 04:55, Andrew Fish wrote:
> Ray,
> 
> The other option would be to define a Library Class for the AcpiTableDxe driver to consume and have a NULL version of it in the MdeModulePkg. That would allow more flexibility? It kind of depends if you want to make the implementation depend on a HOB or a LibraryClass? It at least gives the non pure PI implementations more potential options? I’m not sure with the problem you are trying to solve that helps or hurts, but I though I would throw out another option. The other advantage about the lib is could let you define the HOB in another package, if that makes more sense. 
> 
> Not trying to slow down the solution, but just giving some other options in case another partitioning of this problem would be helpful? 

I agree this is another option for separating out the HOB consumption
logic, in case it is complex or large.

Thanks
Laszlo