Re: [edk2-platforms][PATCH 1/1] RPi4: fix missing and misplaced EFIAPI

["Ard Biesheuvel" <ard.biesheuvel@arm.com>]

On 6/1/20 11:51 AM, Andrei Warkentin wrote:
> EFIAPI should be set on all calls that can be called via pointer,
> and it was missing for RpiFirmwareSetLed.
> 
> Signed-off-by: Andrei Warkentin <andrey.warkentin@gmail.com>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@arm.com>

Pushed as 85a50de1b459..01005f9aa73d

> ---
>   Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c b/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c
> index 8cd8db7b..5302ccd8 100644
> --- a/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c
> +++ b/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c
> @@ -1101,7 +1101,6 @@ typedef struct {
>   
>   STATIC
>   EFI_STATUS
> -EFIAPI
>   RpiFirmwareGetClockRate (
>     IN  UINT32 ClockId,
>     IN  UINT32 ClockKind,
> @@ -1193,6 +1192,7 @@ typedef struct {
>   
>   STATIC
>   VOID
> +EFIAPI
>   RpiFirmwareSetLed (
>     IN  BOOLEAN On
>     )
>