* [edk2-platforms][PATCH 1/1] RPi4: fix missing and misplaced EFIAPI
@ 2020-06-01 9:51 Andrei Warkentin
2020-06-01 10:05 ` Ard Biesheuvel
0 siblings, 1 reply; 2+ messages in thread
From: Andrei Warkentin @ 2020-06-01 9:51 UTC (permalink / raw)
To: devel; +Cc: ard.biesheuvel, leif, pete, philmd
EFIAPI should be set on all calls that can be called via pointer,
and it was missing for RpiFirmwareSetLed.
Signed-off-by: Andrei Warkentin <andrey.warkentin@gmail.com>
---
Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c b/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c
index 8cd8db7b..5302ccd8 100644
--- a/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c
+++ b/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c
@@ -1101,7 +1101,6 @@ typedef struct {
STATIC
EFI_STATUS
-EFIAPI
RpiFirmwareGetClockRate (
IN UINT32 ClockId,
IN UINT32 ClockKind,
@@ -1193,6 +1192,7 @@ typedef struct {
STATIC
VOID
+EFIAPI
RpiFirmwareSetLed (
IN BOOLEAN On
)
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [edk2-platforms][PATCH 1/1] RPi4: fix missing and misplaced EFIAPI
2020-06-01 9:51 [edk2-platforms][PATCH 1/1] RPi4: fix missing and misplaced EFIAPI Andrei Warkentin
@ 2020-06-01 10:05 ` Ard Biesheuvel
0 siblings, 0 replies; 2+ messages in thread
From: Ard Biesheuvel @ 2020-06-01 10:05 UTC (permalink / raw)
To: Andrei Warkentin, devel; +Cc: leif, pete, philmd
On 6/1/20 11:51 AM, Andrei Warkentin wrote:
> EFIAPI should be set on all calls that can be called via pointer,
> and it was missing for RpiFirmwareSetLed.
>
> Signed-off-by: Andrei Warkentin <andrey.warkentin@gmail.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
Pushed as 85a50de1b459..01005f9aa73d
> ---
> Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c b/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c
> index 8cd8db7b..5302ccd8 100644
> --- a/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c
> +++ b/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c
> @@ -1101,7 +1101,6 @@ typedef struct {
>
> STATIC
> EFI_STATUS
> -EFIAPI
> RpiFirmwareGetClockRate (
> IN UINT32 ClockId,
> IN UINT32 ClockKind,
> @@ -1193,6 +1192,7 @@ typedef struct {
>
> STATIC
> VOID
> +EFIAPI
> RpiFirmwareSetLed (
> IN BOOLEAN On
> )
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-01 10:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-01 9:51 [edk2-platforms][PATCH 1/1] RPi4: fix missing and misplaced EFIAPI Andrei Warkentin
2020-06-01 10:05 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox