From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.33783.1591005957930139587 for ; Mon, 01 Jun 2020 03:05:58 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 719511FB; Mon, 1 Jun 2020 03:05:56 -0700 (PDT) Received: from [192.168.1.69] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9A1593F305; Mon, 1 Jun 2020 03:05:55 -0700 (PDT) Subject: Re: [edk2-platforms][PATCH 1/1] RPi4: fix missing and misplaced EFIAPI To: Andrei Warkentin , devel@edk2.groups.io Cc: leif@nuviainc.com, pete@akeo.ie, philmd@redhat.com References: <20200601095126.117998-1-andrey.warkentin@gmail.com> From: "Ard Biesheuvel" Message-ID: <46d2d9da-c7aa-ff14-4200-86ff8f46ed15@arm.com> Date: Mon, 1 Jun 2020 12:05:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 In-Reply-To: <20200601095126.117998-1-andrey.warkentin@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 6/1/20 11:51 AM, Andrei Warkentin wrote: > EFIAPI should be set on all calls that can be called via pointer, > and it was missing for RpiFirmwareSetLed. > > Signed-off-by: Andrei Warkentin Reviewed-by: Ard Biesheuvel Pushed as 85a50de1b459..01005f9aa73d > --- > Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c b/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c > index 8cd8db7b..5302ccd8 100644 > --- a/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c > +++ b/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c > @@ -1101,7 +1101,6 @@ typedef struct { > > STATIC > EFI_STATUS > -EFIAPI > RpiFirmwareGetClockRate ( > IN UINT32 ClockId, > IN UINT32 ClockKind, > @@ -1193,6 +1192,7 @@ typedef struct { > > STATIC > VOID > +EFIAPI > RpiFirmwareSetLed ( > IN BOOLEAN On > ) >