From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web10.69.1602085728878631005 for ; Wed, 07 Oct 2020 08:48:49 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Ct5J+A7f; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602085728; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OHZmfyhugBe/CmRvuIK2b84Ufz/O1t0ZOE/e635kVc0=; b=Ct5J+A7fwRa/wS2AF8M7ifU0LECi3w2j3JZM3NFZg0zwb/mHFTTuw2Gp00SNjYxbkLjInz tQoEE87etFd7Jq0ngP1FthaJK3mX0XPr9aTp6DvxSB1jKnRsLVZlHVuWscpsUw1PfS3F6P GvBBbPeOxgaTBVIG/THugroPn0JpdO0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-113--2MUja89PwKe7Ahd_POqbQ-1; Wed, 07 Oct 2020 11:48:45 -0400 X-MC-Unique: -2MUja89PwKe7Ahd_POqbQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D020F81F001; Wed, 7 Oct 2020 15:48:44 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-94.ams2.redhat.com [10.36.113.94]) by smtp.corp.redhat.com (Postfix) with ESMTP id 48BF15C1BD; Wed, 7 Oct 2020 15:48:44 +0000 (UTC) Subject: Re: [edk2-devel] [RedfishPkg PATCH v6 0/4] Inital RedfishPkg To: "Chang, Abner (HPS SW/FW Technologist)" , "devel@edk2.groups.io" References: <20201007021545.25936-1-abner.chang@hpe.com> <5a054523-061b-dea6-54ac-5ce0aaaf8932@redhat.com> From: "Laszlo Ersek" Message-ID: <46df1b8d-9640-8779-3326-314edf8cec47@redhat.com> Date: Wed, 7 Oct 2020 17:48:43 +0200 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 10/07/20 13:23, Chang, Abner (HPS SW/FW Technologist) wrote: > Thanks for that information, I never read through that guidance... and I should. > > One question Leif, > If the patches get the new tag from reviewers, shall I have to send the new version of patches to the mailing list which includes all of reviewer's tag? No. If the feedback you get purely consists of feedback tags, and through them, the patch series becomes eligible for merging, then it is the maintainer's job to apply your series on a local topic branch of theirs (git-am), pick up the feedback tags (git-rebase + reword on each patch), and finally push the topic branch to github, open a PR, set the "push" label, and let the mergify bot merge the series once the CI run passes. https://github.com/tianocore/tianocore.github.io/wiki/Laszlo%27s-unkempt-git-guide-for-edk2-contributors-and-maintainers#maint-04 Thanks Laszlo