public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: Kun Qin <kuqin12@gmail.com>, devel@edk2.groups.io
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Leif Lindholm <leif@nuviainc.com>,
	Sami Mujawar <sami.mujawar@arm.com>
Subject: Re: [PATCH v1 3/4] ArmPkg: SpellCheck: Update valid acronyms in ExtendedWords
Date: Tue, 22 Jun 2021 12:43:02 +0200	[thread overview]
Message-ID: <46ebb670-a4fc-ad76-d36f-d73c76246765@redhat.com> (raw)
In-Reply-To: <20210612034422.536-4-kuqin12@gmail.com>

Hi,

On 06/12/21 05:44, Kun Qin wrote:
> From: Sean Brogan <sean.brogan@microsoft.com>
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3445
> 
> Spellcheck was not covering all specified files due to CSpell v5 and
> Node v10 incompatibility of current CI pipeline configuration.
> 
> This change updates ExtendedWords for ArmPkg with valid acronyms to avoid
> potential spell errors.
> 
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> 
> Signed-off-by: Kun Qin <kuqin12@gmail.com>
> Signed-off-by: Sean Brogan <sean.brogan@microsoft.com>
> ---
>  ArmPkg/ArmPkg.ci.yaml | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)

I'm not an ArmPkg reviewer, so I'm not sure about the Cc.

That said, the patch seems sensible and I guess the sorting should be
OK; the actual mnemonics should be checked by others however :)

Acked-by: Laszlo Ersek <lersek@redhat.com>

Thanks
Laszlo

> 
> diff --git a/ArmPkg/ArmPkg.ci.yaml b/ArmPkg/ArmPkg.ci.yaml
> index d91c03f2acb8..a0d6a75fe881 100644
> --- a/ArmPkg/ArmPkg.ci.yaml
> +++ b/ArmPkg/ArmPkg.ci.yaml
> @@ -94,13 +94,18 @@
>            "ackintid",
>            "actlr",
>            "aeabi",
> +          "asedis",
>            "ashldi",
>            "ashrdi",
> +          "baddr",
>            "ccidx",
>            "ccsidr",
>            "clidr",
>            "clrex",
>            "clzsi",
> +          "cnthctl",
> +          "cortexa",
> +          "cpacr",
>            "cpuactlr",
>            "csselr",
>            "ctzsi",
> @@ -116,6 +121,7 @@
>            "divdi",
>            "divsi",
>            "dmdepkg",
> +          "dpref",
>            "drsub",
>            "fcmpeq",
>            "fcmpge",
> @@ -125,17 +131,25 @@
>            "ffreestanding",
>            "frsub",
>            "hisilicon",
> +          "iccabpr",
>            "iccbpr",
>            "icciar",
>            "iccicr",
>            "icciidr",
> +          "iccpir",
>            "iccpmr",
> +          "iccrpr",
> +          "icdabr",
>            "icdicer",
>            "icdicfr",
> +          "icdicpr",
>            "icdictr",
> +          "icdiidr",
>            "icdiser",
>            "icdisr",
> +          "icdppisr",
>            "icdsgir",
> +          "icdspr",
>            "icenabler",
>            "intid",
>            "ipriority",
> @@ -160,6 +174,7 @@
>            "lshrdi",
>            "moddi",
>            "modsi",
> +          "mpcore",
>            "mpidr",
>            "muldi",
>            "mullu",
> @@ -168,6 +183,9 @@
>            "nsasedis",
>            "nuvia",
>            "oldit",
> +          "pcten",
> +          "plpis",
> +          "procno",
>            "readc",
>            "revsh",
>            "rfedb",
> @@ -189,6 +207,7 @@
>            "smmlsr",
>            "sourcery",
>            "srsdb",
> +          "ssacr",
>            "stmdb",
>            "stmia",
>            "strbt",
> 


  reply	other threads:[~2021-06-22 10:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-12  3:44 [PATCH v1 0/4] Update Node to 14.x to resolve cspell failure Kun Qin
2021-06-12  3:44 ` [PATCH v1 1/4] StandaloneMmPkg: Core: Spelling error in comment Kun Qin
2021-06-12  8:22   ` Ard Biesheuvel
2021-06-14 18:36     ` Kun Qin
2021-06-12  3:44 ` [PATCH v1 2/4] ArmPlatformPkg: SpellCheck: Switch spellcheck CI to AuditOnly Kun Qin
2021-06-12  3:44 ` [PATCH v1 3/4] ArmPkg: SpellCheck: Update valid acronyms in ExtendedWords Kun Qin
2021-06-22 10:43   ` Laszlo Ersek [this message]
2021-06-12  3:44 ` [PATCH v1 4/4] Azurepipeline: SpellCheck: Enforce Node dependency to use version 14.x Kun Qin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46ebb670-a4fc-ad76-d36f-d73c76246765@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox