From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web08.7378.1624358590472369607 for ; Tue, 22 Jun 2021 03:43:10 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ZOdxivUV; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624358589; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hZJbKpMijMSuxiC1VUmCSme7ssnNcHAIzl4PR/6UVvs=; b=ZOdxivUV2gR2QOpnoDPYPaVcLDZdK8SAZ9MobGOvyz8s3N7x8dajSjtXeTXLDfpc541Ttz yPVq/OddRxQPR1vmnSdQGhHFD9dOnC6DvCyl9/YMAmdrcpAOEY/npSqGeOEaJqRxLlMlYk shuXqpY9Hu4lEkNlN9y90a0kGQM88YI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-68-E-7XwAHKMxOUZmTK6eG8-w-1; Tue, 22 Jun 2021 06:43:05 -0400 X-MC-Unique: E-7XwAHKMxOUZmTK6eG8-w-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9E366100C610; Tue, 22 Jun 2021 10:43:04 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-115-52.ams2.redhat.com [10.36.115.52]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 70EF55D6BA; Tue, 22 Jun 2021 10:43:03 +0000 (UTC) Subject: Re: [PATCH v1 3/4] ArmPkg: SpellCheck: Update valid acronyms in ExtendedWords To: Kun Qin , devel@edk2.groups.io Cc: Ard Biesheuvel , Leif Lindholm , Sami Mujawar References: <20210612034422.536-1-kuqin12@gmail.com> <20210612034422.536-4-kuqin12@gmail.com> From: "Laszlo Ersek" Message-ID: <46ebb670-a4fc-ad76-d36f-d73c76246765@redhat.com> Date: Tue, 22 Jun 2021 12:43:02 +0200 MIME-Version: 1.0 In-Reply-To: <20210612034422.536-4-kuqin12@gmail.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi, On 06/12/21 05:44, Kun Qin wrote: > From: Sean Brogan > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3445 > > Spellcheck was not covering all specified files due to CSpell v5 and > Node v10 incompatibility of current CI pipeline configuration. > > This change updates ExtendedWords for ArmPkg with valid acronyms to avoid > potential spell errors. > > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Sami Mujawar > > Signed-off-by: Kun Qin > Signed-off-by: Sean Brogan > --- > ArmPkg/ArmPkg.ci.yaml | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) I'm not an ArmPkg reviewer, so I'm not sure about the Cc. That said, the patch seems sensible and I guess the sorting should be OK; the actual mnemonics should be checked by others however :) Acked-by: Laszlo Ersek Thanks Laszlo > > diff --git a/ArmPkg/ArmPkg.ci.yaml b/ArmPkg/ArmPkg.ci.yaml > index d91c03f2acb8..a0d6a75fe881 100644 > --- a/ArmPkg/ArmPkg.ci.yaml > +++ b/ArmPkg/ArmPkg.ci.yaml > @@ -94,13 +94,18 @@ > "ackintid", > "actlr", > "aeabi", > + "asedis", > "ashldi", > "ashrdi", > + "baddr", > "ccidx", > "ccsidr", > "clidr", > "clrex", > "clzsi", > + "cnthctl", > + "cortexa", > + "cpacr", > "cpuactlr", > "csselr", > "ctzsi", > @@ -116,6 +121,7 @@ > "divdi", > "divsi", > "dmdepkg", > + "dpref", > "drsub", > "fcmpeq", > "fcmpge", > @@ -125,17 +131,25 @@ > "ffreestanding", > "frsub", > "hisilicon", > + "iccabpr", > "iccbpr", > "icciar", > "iccicr", > "icciidr", > + "iccpir", > "iccpmr", > + "iccrpr", > + "icdabr", > "icdicer", > "icdicfr", > + "icdicpr", > "icdictr", > + "icdiidr", > "icdiser", > "icdisr", > + "icdppisr", > "icdsgir", > + "icdspr", > "icenabler", > "intid", > "ipriority", > @@ -160,6 +174,7 @@ > "lshrdi", > "moddi", > "modsi", > + "mpcore", > "mpidr", > "muldi", > "mullu", > @@ -168,6 +183,9 @@ > "nsasedis", > "nuvia", > "oldit", > + "pcten", > + "plpis", > + "procno", > "readc", > "revsh", > "rfedb", > @@ -189,6 +207,7 @@ > "smmlsr", > "sourcery", > "srsdb", > + "ssacr", > "stmdb", > "stmia", > "strbt", >