From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (EUR05-VI1-obe.outbound.protection.outlook.com [40.107.21.71]) by mx.groups.io with SMTP id smtpd.web11.200.1682525878478104597 for ; Wed, 26 Apr 2023 09:17:59 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=Ik97n3Xs; spf=pass (domain: arm.com, ip: 40.107.21.71, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U0YWmkQhRY7Wh9RRi4jGZeSmERU3MihrWQhmCY9K7xY=; b=Ik97n3XsOLSrr5KNLi0TXj+VFpSK4DCUZGcJgFgfSXu2AWNPStZl4JjoT6Limw82VX+t7JqkXOC8oOR2cmphbpAxPtMT0FRBMBk+Ng2spz3NDaSGE/OZDhsC2q/8ituYu5r7FUSapSuXOeyOjsARE8DkZHZi0r778nrI+KlydzA= Received: from AS9PR06CA0134.eurprd06.prod.outlook.com (2603:10a6:20b:467::18) by DBBPR08MB6028.eurprd08.prod.outlook.com (2603:10a6:10:208::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.21; Wed, 26 Apr 2023 16:17:55 +0000 Received: from AM7EUR03FT019.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:467:cafe::ea) by AS9PR06CA0134.outlook.office365.com (2603:10a6:20b:467::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.21 via Frontend Transport; Wed, 26 Apr 2023 16:17:54 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT019.mail.protection.outlook.com (100.127.140.245) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.21 via Frontend Transport; Wed, 26 Apr 2023 16:17:54 +0000 Received: ("Tessian outbound 3a01b65b5aad:v136"); Wed, 26 Apr 2023 16:17:54 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 564777e55b6484b2 X-CR-MTA-TID: 64aa7808 Received: from fdb1ea4eb694.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 924C3BE4-6912-4ADC-B38E-CF0BC8D37426.1; Wed, 26 Apr 2023 16:17:42 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id fdb1ea4eb694.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 26 Apr 2023 16:17:42 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F/Xjfln4x+9ueEg7cZGKld5ufl9xlKcQW4zRFE7AQJ9CLKJ/FmUz1r8wmSunzmJpaYLF0W9e0r6TcYgooR8cauaFzqq9ZRcAzuaSP0fdayh9knRcTEXnwv4i/5rh9iEBFQNboBD/GFfCF9pQO6sMdtrI3VrNPiL/9vRmJlNogupuvRjs8UV0zZRfwTB2wegsbZtygpJVEex+tC2KPn2ijb9K4simJZ0Mokz06cxKYCLpXidtL5ba2pkWKmHrSKfYqowy480uEPE1jqUHERtDSS0/rwWJxMJQS1AF6HzeZkJsbUJvs/lNNLnexLjsK+2COfp8uJusx3A4Xtlgf95HDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U0YWmkQhRY7Wh9RRi4jGZeSmERU3MihrWQhmCY9K7xY=; b=kBZs7wAKxgf2z+fzfuDLrSj1mq8ym1kZot+e5jnp/rs/ffBCVQnmSPID1aEbKsnhw8B8t0zh4nbD0Jr7OA4ul/44P2Cp7WYlb5U7/e6Ft5C1UNNU/yxTZWsuM+krNgbf+CoOyXm258ZLHOlM+86LHZBu//mxu4A9eRv4EXQpI6tfWrdReXMgD6vYpAyvjNsL/H1wQ6J9RksgiteLri+K8LWxFd3TP+31RTIMPdig+fFW8PMaJ47XKMlQP1vZpXoiOI3ZCpj43soEFnVTiz8g2Mzdd5JsBEX0KHGIHY/mkd2NB85j2RWWNlw+n+Af/pyagTm2cyTDTKFpZyAIg1dd2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U0YWmkQhRY7Wh9RRi4jGZeSmERU3MihrWQhmCY9K7xY=; b=Ik97n3XsOLSrr5KNLi0TXj+VFpSK4DCUZGcJgFgfSXu2AWNPStZl4JjoT6Limw82VX+t7JqkXOC8oOR2cmphbpAxPtMT0FRBMBk+Ng2spz3NDaSGE/OZDhsC2q/8ituYu5r7FUSapSuXOeyOjsARE8DkZHZi0r778nrI+KlydzA= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by DB4PR08MB9142.eurprd08.prod.outlook.com (2603:10a6:10:3fe::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.32; Wed, 26 Apr 2023 16:17:40 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::7afd:553d:71b8:4c8c]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::7afd:553d:71b8:4c8c%6]) with mapi id 15.20.6340.021; Wed, 26 Apr 2023 16:17:40 +0000 Message-ID: <471c3802-bad3-1028-b50a-977b308a9072@arm.com> Date: Wed, 26 Apr 2023 17:17:39 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [edk2-platforms][PATCH V3 5/5] Platform/Sgi: Enable SoC expansion block for RD-N2 variants To: Vivek Gautam , devel@edk2.groups.io Cc: ardb+tianocore@kernel.org, leif@nuviainc.com, Pierre.Gondois@arm.com, "nd@arm.com" References: <20230324110303.1168851-1-vivek.gautam@arm.com> <20230324110303.1168851-6-vivek.gautam@arm.com> From: "Sami Mujawar" In-Reply-To: <20230324110303.1168851-6-vivek.gautam@arm.com> X-ClientProxiedBy: LO4P123CA0468.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1aa::23) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|DB4PR08MB9142:EE_|AM7EUR03FT019:EE_|DBBPR08MB6028:EE_ X-MS-Office365-Filtering-Correlation-Id: 2b8c9568-8c2b-42d6-4efd-08db4671ca8d x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 3UyHMYnrskyaRZIFatYeSVKmzhZtW57H4ejmxtiPABAyf1BiufbsWBTfUU49hFwHUFmIXXHjbws9rt4/8FkJpgUpikaceo3+Q29TLL5kpp13Kt4gF78JRnrID0UqK1wep7PeO21cpwrwvNl+qq+qZrKh6xrVOmGJbwmjnznSSP2WJA2ax2h43ec5ZvMYOZ3Z9OzODbnbON/ZJ+DyEu8V4EpIbXQyJknA0gkxPkJf3vxhmUXZXN/HRzbddzFOK/db4OAA0u0dYeTNZ6xV4kL+BEYbfAlCE7huaGIPqHXvESkfFobvNd/Ppk2jXziy7f14GqT+zdZ7FR2rDeo3bjX6+enqhbohYr3izrrVM8aFUpm6rOzROnuvhKVMSwvnHeD3VSXunAzhP5g2H4jOSD1lWx7FvDf/h71GmwtcbFooORH75bi4rrZl0mqB7dbVig4BQglPZp5flffEv2wwoTtXk+yuGPd0S6BZHjFNo26aaRqWe6qcEzKUo8Dtj5aP5kGwK2TG1EUmQCGGkXSV/cIULahMUYjR+7kfzkAt7ghVikrw6kUaTWH3dQy8nu1wH4+dBn+hkrgRl6e9jmRFDVuPJx7wljwMGLwP6I76nM+6mvnW0wrqKQDD0eELM3ZqeR2mfBnpOx6Kp8FdK5LcE4hQ/w== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(396003)(376002)(39860400002)(346002)(136003)(451199021)(19627235002)(6486002)(2906002)(6512007)(6506007)(2616005)(53546011)(4326008)(41300700001)(66946007)(8936002)(66476007)(66556008)(26005)(186003)(316002)(478600001)(44832011)(5660300002)(8676002)(38100700002)(86362001)(31696002)(36756003)(83380400001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR08MB9142 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT019.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 16c7be46-d013-4979-a017-08db4671c205 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eDDXVPrhf9dYyDDiHAQuBw7fOTRfLn6gbNaP0EwrCHmom9P1x2+ydep7DOQo9QCZnVoKXjhG6mUhJsD9xoAJEeRtadcawpwa3zbuayytysoRAgN3oxDpyRC3l2C/MwY4rjQs/9VZ6RKhuuJk4SWgCYrmR1bsubgWcxAkmxtUuCapvXfUCKRqxz6mSOHCZOvXABkdbk27u+9WZsv9grLVf2gKpF5/pGRW64kvsbjpUxzy7A1QAe6FKmJA1JkUR+PsITFXcnp8kOUMEPer6iyaJ1VH4UD5mjelcnEW/sU7+VHMQ9zLWySSIegBtZFBB69WSNWMQ7Y6wyfCpmt9wLY9URk8PuM5Vomz9swKFLfFo/0pHhMmIwFTkNwYxvxDLLIKlIdBtS3bDRDW69/wm4fEVAt/9y+gcR/6HsjMLNmQ713qYXp2opVULKRrpbJqCLX91nUgeJVEoE1q4upA7KT1bxLkFHxj4M5iiUtBqfjaenW9ZeTvvDSYYzvDUTPdNMtAeidSrfZgfvFhhMFSaSxouEnuVeiwKHtZqoRHhDl+BKg7vex5tdA9Gzh89f9xQkNXrdkb/b4Sg7v+8OlcUPflZZJhXjKvuN1E6EeiFDCezEDhSrb8vj2L3UU6ykO7dm09sZ2x7d6FbTez2L12LlkOA6ejSJXCDlwx4Dq4U37Gx84SJi1NPo3TH3dh38Q2qWXYontTCZil2RZr8D7PG3qsiwOoz8JaEz0Yh10PYf0nPTi5GT4Mav9jO2anX3QFk22rw4YUd847jp1W5J9ryFkyUg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(396003)(346002)(136003)(39860400002)(376002)(451199021)(46966006)(36840700001)(40470700004)(41300700001)(81166007)(2616005)(26005)(6512007)(53546011)(6506007)(5660300002)(36860700001)(8936002)(8676002)(31686004)(83380400001)(82740400003)(336012)(356005)(44832011)(47076005)(2906002)(4326008)(316002)(70206006)(40460700003)(70586007)(36756003)(31696002)(478600001)(86362001)(40480700001)(186003)(19627235002)(34020700004)(82310400005)(6486002)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2023 16:17:54.6095 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2b8c9568-8c2b-42d6-4efd-08db4671ca8d X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT019.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6028 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Vivek, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 24/03/2023 11:03 am, Vivek Gautam wrote: > For all the RD-N2 platform variants, include the SSDT ACPI table that > describes the devices present in SoC expansion block that is connected > to the IO virtualization block. > > Signed-off-by: Vivek Gautam > --- > Platform/ARM/SgiPkg/AcpiTables/RdN2AcpiTables.inf | 5 +++++ > Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg1AcpiTables.inf | 5 +++++ > Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg2AcpiTables.inf | 3 +++ > 3 files changed, 13 insertions(+) > > diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN2AcpiTables.inf b/Platform/ARM/SgiPkg/AcpiTables/RdN2AcpiTables.inf > index 833f87c3e4be..8025ef58171b 100644 > --- a/Platform/ARM/SgiPkg/AcpiTables/RdN2AcpiTables.inf > +++ b/Platform/ARM/SgiPkg/AcpiTables/RdN2AcpiTables.inf > @@ -26,6 +26,7 @@ > Spcr.aslc > Ssdt.asl > SsdtEvents.asl > + SsdtIoVirtSocExp.asl > SsdtRos.asl > SsdtRosVirtioP9.asl > > @@ -55,11 +56,15 @@ > gArmTokenSpaceGuid.PcdPciBusMin > gArmTokenSpaceGuid.PcdPciBusMax > > + gArmSgiTokenSpaceGuid.PcdChipCount > gArmSgiTokenSpaceGuid.PcdGpioController0BaseAddress > gArmSgiTokenSpaceGuid.PcdGpioController0Size > gArmSgiTokenSpaceGuid.PcdGpioController0Interrupt > gArmSgiTokenSpaceGuid.PcdGtFrame0Gsiv > gArmSgiTokenSpaceGuid.PcdGtFrame1Gsiv > + gArmSgiTokenSpaceGuid.PcdIoVirtSocExpBlk0Base > + gArmSgiTokenSpaceGuid.PcdIoVirtSocExpBlkUartEnable > + gArmSgiTokenSpaceGuid.PcdMaxAddressBitsPerChip > gArmSgiTokenSpaceGuid.PcdOscLpiEnable > gArmSgiTokenSpaceGuid.PcdOscCppcEnable > gArmSgiTokenSpaceGuid.PcdSp804DualTimerBaseAddress > diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg1AcpiTables.inf b/Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg1AcpiTables.inf > index e3e4e55bc410..88e210933f6d 100644 > --- a/Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg1AcpiTables.inf > +++ b/Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg1AcpiTables.inf > @@ -26,6 +26,7 @@ > Spcr.aslc > Ssdt.asl > SsdtEvents.asl > + SsdtIoVirtSocExp.asl > SsdtRos.asl > SsdtRosVirtioP9.asl > > @@ -55,11 +56,15 @@ > gArmTokenSpaceGuid.PcdPciBusMin > gArmTokenSpaceGuid.PcdPciBusMax > > + gArmSgiTokenSpaceGuid.PcdChipCount > gArmSgiTokenSpaceGuid.PcdGpioController0BaseAddress > gArmSgiTokenSpaceGuid.PcdGpioController0Size > gArmSgiTokenSpaceGuid.PcdGpioController0Interrupt > gArmSgiTokenSpaceGuid.PcdGtFrame0Gsiv > gArmSgiTokenSpaceGuid.PcdGtFrame1Gsiv > + gArmSgiTokenSpaceGuid.PcdIoVirtSocExpBlk0Base > + gArmSgiTokenSpaceGuid.PcdIoVirtSocExpBlkUartEnable > + gArmSgiTokenSpaceGuid.PcdMaxAddressBitsPerChip > gArmSgiTokenSpaceGuid.PcdOscLpiEnable > gArmSgiTokenSpaceGuid.PcdOscCppcEnable > gArmSgiTokenSpaceGuid.PcdSmmuBase > diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg2AcpiTables.inf b/Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg2AcpiTables.inf > index 6ce78582da35..ad81be29cd42 100644 > --- a/Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg2AcpiTables.inf > +++ b/Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg2AcpiTables.inf > @@ -23,6 +23,7 @@ > RdN2Cfg2/Pptt.aslc > RdN2Cfg2/Srat.aslc > Spcr.aslc > + SsdtIoVirtSocExp.asl > SsdtRos.asl > SsdtRosVirtioP9.asl > > @@ -57,6 +58,8 @@ > gArmSgiTokenSpaceGuid.PcdDramBlock2Size > gArmSgiTokenSpaceGuid.PcdGtFrame0Gsiv > gArmSgiTokenSpaceGuid.PcdGtFrame1Gsiv > + gArmSgiTokenSpaceGuid.PcdIoVirtSocExpBlk0Base > + gArmSgiTokenSpaceGuid.PcdIoVirtSocExpBlkUartEnable > gArmSgiTokenSpaceGuid.PcdMaxAddressBitsPerChip > gArmSgiTokenSpaceGuid.PcdOscLpiEnable > gArmSgiTokenSpaceGuid.PcdOscCppcEnable