From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=enhnLgZY; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: philmd@redhat.com) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by groups.io with SMTP; Fri, 27 Sep 2019 13:23:56 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1569615835; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:openpgp:openpgp; bh=FyRfh0y6GiLJnIWlrxBznkH8vSvTO0BL+0E3J3dcdhA=; b=enhnLgZYMdx7hutU9cqdZyrfGF9RKCdEg6wwunBQdlVs9rGXN7Pezavuo7a975Jl1eiy1R aAT1x88QOKYG0FJmzv5qaDAGQM5AtOGzz7Akf2izQ4eLsQRKHawrmFJaWcOwzs/1xfww6L 0AfTIcKzly4wuwM2dKSnSpUZg72Iw/U= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-273-XYNcH6d9PNCiR-LdExz0_w-1; Fri, 27 Sep 2019 16:23:53 -0400 Received: by mail-wr1-f70.google.com with SMTP id n18so1588303wro.11 for ; Fri, 27 Sep 2019 13:23:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=SeRAmrspyx0Z2ApFH0JFv/rwckLmEdqQ/YJGUylr+xI=; b=QRongDm5P/oGRV86igXF37OwNNbD7NSOKcOqx93LnS2992Z5mt9hNdLABIzeSvc7Zq zv3sdgPnwQ459OFnhQFgYLio+jiNIMN6ALJiMuYuVeNAnJ/qqfy1XqQZ2c1yhnvDLc4j /YC0iLBGt5Q1/4IX3IekihWTp5p81UYddc4Zk94407o/ax/tQR3Dxx+6HdEC59peJAVD 5rwFAu8SkRBzs+sc7gq8JW06PSz94E33gtvJqUTSFANYe2UJb6ZdPktvRAHHWxAW1EB+ eQ8VrZrVK3+a/EDYckcnyKLdtZTzFqRWSSqZJHdvimAS2y1hHLMNjex2zyXtVuufkijW cOdg== X-Gm-Message-State: APjAAAXl7ChYzhP9TZINS7D5t24GJrkWWszBPWYXhV/SraWc+Vj/diRH c1YIQ/IP1t5KkTkVVo/OB3ocWFzedtF9FhsVk2V/rJM/4J89HaMlrZrtvxxltRM8FxVu6st18i5 01DN2/6o753JCIA== X-Received: by 2002:a5d:6a09:: with SMTP id m9mr4148003wru.12.1569615832038; Fri, 27 Sep 2019 13:23:52 -0700 (PDT) X-Google-Smtp-Source: APXvYqwWlPXWZIiwj6dNH1dAcyVTWhLu5Fn7i/APxxyseb3EsYkiB5BdV/JQDIfxwZFqnr3q3D8Cqg== X-Received: by 2002:a5d:6a09:: with SMTP id m9mr4147988wru.12.1569615831729; Fri, 27 Sep 2019 13:23:51 -0700 (PDT) Return-Path: Received: from [192.168.1.35] (240.red-88-21-68.staticip.rima-tde.net. [88.21.68.240]) by smtp.gmail.com with ESMTPSA id t6sm12551008wmf.8.2019.09.27.13.23.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Sep 2019 13:23:51 -0700 (PDT) Subject: Re: [edk2-devel] [edk2-platforms PATCH 1/1] Platforms/RPi3: DisplayDxe virtual resolution improvements To: devel@edk2.groups.io, leif.lindholm@linaro.org Cc: pete@akeo.ie, ard.biesheuvel@linaro.org References: <20190927092016.5604-1-pete@akeo.ie> <20190927174923.GP25504@bivouac.eciton.net> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: <471e60ec-2fe4-7d6f-619c-f35b2ec29bf9@redhat.com> Date: Fri, 27 Sep 2019 22:23:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190927174923.GP25504@bivouac.eciton.net> X-MC-Unique: XYNcH6d9PNCiR-LdExz0_w-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 9/27/19 7:49 PM, Leif Lindholm wrote: > On Fri, Sep 27, 2019 at 06:38:07PM +0200, Philippe Mathieu-Daud=C3=A9 wro= te: >> Hi Pete, >> >> On 9/27/19 11:20 AM, Pete Batard wrote: >>> From: Andrei Warkentin >>> >>> The Pi GPU decouples requested resolution from actual physical resoluti= on >>> and can perform scaling of virtual resolutions. This enables platform u= sers >>> to do something like ask for 1024x768 and get a framebuffer of that siz= e, >>> regardless of the actual output (which could be a very blurry SDTV). >>> >>> Specifically, this patch allows selecting which specific virtual >>> resolutions to enable, thus replacing the old all-or-nothing behaviour >>> with either all virtual resolutions supported, or just the native one. >>> >>> This patch also adds enables the common 7" Pi (800x480) screen to be us= ed >>> at 800x600 resolution, instead of forcing 640x480 as the only usable >>> resolution. >> >> I tried to build the RPi3 platform but I get errors because it seems to >> use an older edk2 repository. What tag should I use? >=20 > edk2-platforms master should always build against edk2 - if it does > not, that's a bug. But I can't see any issues when building rpi3 with > the current master branches. > Any platform that is not willing to commit to this state of things can > live on stable- or devel- branches in the edk-platforms repository. > This process is described in > https://github.com/tianocore/edk2-platforms/blob/about/Readme.md >=20 > But please provide some more information than "I get errors". It is a > much better use of maintainer time than sending me off verifying that > something I expected to work still works (for me). Yes, sorry :/ So the first error was: : error 000E: File/directory not found in workspace Platform/RaspberryPi/RPi3/Drivers/LogoDxe/LogoDxe.inf is not found in packages path: And as you noted on IRC, I was missing edk2-non-osi, silly me :S Using it I now get: /home/phil/source/edk2$ GCC5_AARCH64_PREFIX=3Daarch64-linux-gnu- build -a AARCH64 -t GCC5 -b DEBUG -p Platform/RaspberryPi/RPi3/RPi3.dsc -D ATF_BUILD_DIR=3D$ATF_BUILD_DIR -n 1 Build environment: Linux-5.2.11-100.fc29.x86_64-x86_64-with-Ubuntu-16.04-xenial Build start time: 20:10:25, Sep.27 2019 WORKSPACE =3D /home/phil/source/edk2 PACKAGES_PATH =3D /home/phil/source/edk2:/home/phil/source/edk2-platforms:/home/phil/source/e= dk2-non-osi EDK_TOOLS_PATH =3D /home/phil/source/edk2/BaseTools CONF_PATH =3D /home/phil/source/edk2/Conf Architecture(s) =3D AARCH64 Build target =3D DEBUG Processing meta-data .Toolchain =3D GCC5 Active Platform =3D /home/phil/source/edk2-platforms/Platform/RaspberryPi/RPi3/RPi3.dsc ..... done! Building ... /home/phil/source/edk2/ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrins= icsLib.inf [AARCH64] make: Nothing to be done for 'tbuild'. Building ... /home/phil/source/edk2/MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.i= nf [AARCH64] make: Nothing to be done for 'tbuild'. Building ... /home/phil/source/edk2/MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryP= oint.inf [AARCH64] make: Nothing to be done for 'tbuild'. Building ... /home/phil/source/edk2/MdePkg/Library/UefiLib/UefiLib.inf [AARCH64] make: Nothing to be done for 'tbuild'. Building ... /home/phil/source/edk2/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.i= nf [AARCH64] make: Nothing to be done for 'tbuild'. Building ... /home/phil/source/edk2/MdePkg/Library/UefiRuntimeServicesTableLib/UefiRunti= meServicesTableLib.inf [AARCH64] make: Nothing to be done for 'tbuild'. Building ... /home/phil/source/edk2/MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAll= ocationLib.inf [AARCH64] make: Nothing to be done for 'tbuild'. Building ... /home/phil/source/edk2/MdePkg/Library/UefiBootServicesTableLib/UefiBootServ= icesTableLib.inf [AARCH64] make: Nothing to be done for 'tbuild'. Building ... /home/phil/source/edk2/MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSe= rialPort.inf [AARCH64] make: Nothing to be done for 'tbuild'. Building ... /home/phil/source/edk2/MdeModulePkg/Library/BaseSerialPortLib16550/BaseSeri= alPortLib16550.inf [AARCH64] make: Nothing to be done for 'tbuild'. Building ... /home/phil/source/edk2/MdePkg/Library/BasePrintLib/BasePrintLib.inf [AARCH64] make: Nothing to be done for 'tbuild'. Building ... /home/phil/source/edk2/MdePkg/Library/BaseDebugPrintErrorLevelLib/BaseDebug= PrintErrorLevelLib.inf [AARCH64] make: Nothing to be done for 'tbuild'. Building ... /home/phil/source/edk2/MdeModulePkg/Library/BasePlatformHookLibNull/BasePla= tformHookLibNull.inf [AARCH64] make: Nothing to be done for 'tbuild'. Building ... /home/phil/source/edk2/MdePkg/Library/BasePciLibCf8/BasePciLibCf8.inf [AARCH64] make: Nothing to be done for 'tbuild'. Building ... /home/phil/source/edk2/MdePkg/Library/BasePciCf8Lib/BasePciCf8Lib.inf [AARCH64] make: Nothing to be done for 'tbuild'. Building ... /home/phil/source/edk2/MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic= .inf [AARCH64] make: Nothing to be done for 'tbuild'. Building ... /home/phil/source/edk2/MdePkg/Library/DxePcdLib/DxePcdLib.inf [AARCH64] make: Nothing to be done for 'tbuild'. Building ... /home/phil/source/edk2/MdePkg/Library/BaseLib/BaseLib.inf [AARCH64] make: Nothing to be done for 'tbuild'. Building ... /home/phil/source/edk2/MdePkg/Library/BaseMemoryLibOptDxe/BaseMemoryLibOptD= xe.inf [AARCH64] make: Nothing to be done for 'tbuild'. Building ... /home/phil/source/edk2/MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.i= nf [AARCH64] make: Nothing to be done for 'tbuild'. Building ... /home/phil/source/edk2-platforms/Platform/RaspberryPi/RPi3/Drivers/Platform= SmbiosDxe/PlatformSmbiosDxe.inf [AARCH64] test -f /home/phil/source/edk2/Build/RPi3/DEBUG_GCC5/AARCH64/Platform/RaspberryPi/R= Pi3/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe/OUTPUT/PlatformSmbiosDxe.ma= p && cp -f /home/phil/source/edk2/Build/RPi3/DEBUG_GCC5/AARCH64/Platform/RaspberryPi/R= Pi3/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe/OUTPUT/PlatformSmbiosDxe.ma= p /home/phil/source/edk2/Build/RPi3/DEBUG_GCC5/FV/Ffs/BAD0554E-22E9-4D83-9AFD= -CC87727A1A45PlatformSmbiosDxe/BAD0554E-22E9-4D83-9AFD-CC87727A1A45.map GNUmakefile:476: recipe for target '/home/phil/source/edk2/Build/RPi3/DEBUG_GCC5/FV/Ffs/BAD0554E-22E9-4D83-9AF= D-CC87727A1A45PlatformSmbiosDxe/BAD0554E-22E9-4D83-9AFD-CC87727A1A45.map' failed make: *** [/home/phil/source/edk2/Build/RPi3/DEBUG_GCC5/FV/Ffs/BAD0554E-22E9-4D83-9AF= D-CC87727A1A45PlatformSmbiosDxe/BAD0554E-22E9-4D83-9AFD-CC87727A1A45.map] Error 1 build.py... : error 7000: Failed to execute command make tbuild [/home/phil/source/edk2/Build/RPi3/DEBUG_GCC5/AARCH64/edk2-platforms/Platfo= rm/RaspberryPi/RPi3/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe] build.py... : error F002: Failed to build module /home/phil/source/edk2-platforms/Platform/RaspberryPi/RPi3/Drivers/Platform= SmbiosDxe/PlatformSmbiosDxe.inf [AARCH64, GCC5, DEBUG] However I do have this file generated: /home/phil/source/edk2$ find -name PlatformSmbiosDxe.map ./Build/RPi3/DEBUG_GCC5/AARCH64/edk2-platforms/Platform/RaspberryPi/RPi3/Dr= ivers/PlatformSmbiosDxe/PlatformSmbiosDxe/OUTPUT/PlatformSmbiosDxe.map ./Build/RPi3/DEBUG_GCC5/AARCH64/edk2-platforms/Platform/RaspberryPi/RPi3/Dr= ivers/PlatformSmbiosDxe/PlatformSmbiosDxe/DEBUG/PlatformSmbiosDxe.map Let's try dumb symlink: edk2@x1w:/home/phil/source/edk2$ ln -s /home/phil/source/edk2/Build/RPi3/DEBUG_GCC5/AARCH64/edk2-platforms/Platfor= m /home/phil/source/edk2/Build/RPi3/DEBUG_GCC5/AARCH64/Platform Building ... /home/phil/source/edk2-non-osi/Platform/RaspberryPi/RPi3/Drivers/LogoDxe/Lo= goDxe.inf [AARCH64] test -f /home/phil/source/edk2/Build/RPi3/DEBUG_GCC5/AARCH64/Platform/RaspberryPi/R= Pi3/Drivers/LogoDxe/LogoDxe/OUTPUT/LogoDxe.map && cp -f /home/phil/source/edk2/Build/RPi3/DEBUG_GCC5/AARCH64/Platform/RaspberryPi/R= Pi3/Drivers/LogoDxe/LogoDxe/OUTPUT/LogoDxe.map /home/phil/source/edk2/Build/RPi3/DEBUG_GCC5/FV/Ffs/F74D20EE-37E7-48FC-97F7= -9B1047749C69LogoDxe/F74D20EE-37E7-48FC-97F7-9B1047749C69.map make: *** [/home/phil/source/edk2/Build/RPi3/DEBUG_GCC5/FV/Ffs/F74D20EE-37E7-48FC-97F= 7-9B1047749C69LogoDxe/F74D20EE-37E7-48FC-97F7-9B1047749C69.map] Error 1 GNUmakefile:455: recipe for target '/home/phil/source/edk2/Build/RPi3/DEBUG_GCC5/FV/Ffs/F74D20EE-37E7-48FC-97F= 7-9B1047749C69LogoDxe/F74D20EE-37E7-48FC-97F7-9B1047749C69.map' failed Hmmm it seems something is wrong with my paths... I rm'ed -rf ./Build and retried but still the same result. I'll try somewhere else. >>> Signed-off-by: Pete Batard >> >> Hmm shouldn't this patch have a S-o-b from Andrei Warkentin too? >=20 > No. Andrei is the author, he is not the person upstreaming. And the > From: tag retains his authorship. Oh, this is new to me. > Adding a S-o-b in that situation equates to putting in the commit > message that "Oh, and Andrei says he's cool with > https://developercertificate.org/". OK :) Thanks, Phil. [...]