public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [edk2-devel] Could we reconsider the GitHub stale PR bot please?
@ 2024-10-29  2:34 Rebecca Cran
  2024-10-29  5:43 ` Michael D Kinney
  0 siblings, 1 reply; 4+ messages in thread
From: Rebecca Cran @ 2024-10-29  2:34 UTC (permalink / raw)
  To: devel@edk2.groups.io; +Cc: Kinney, Michael D

[-- Attachment #1: Type: text/plain, Size: 737 bytes --]

See the attached screenshot or 
https://github.com/tianocore/edk2/pull/5907#issuecomment-2408745999 .

The PR was marked stale by the bot and the PR author only responded two 
weeks later - which would have been one week too late.

Fortunately I noticed and commented to keep it open, but I think we 
should reconsider the use of the stale bot.


-- 
Rebecca


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120690): https://edk2.groups.io/g/devel/message/120690
Mute This Topic: https://groups.io/mt/109271104/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Screenshot_2024-10-28_20-30-55.png --]
[-- Type: image/png, Size: 93833 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [edk2-devel] Could we reconsider the GitHub stale PR bot please?
  2024-10-29  2:34 [edk2-devel] Could we reconsider the GitHub stale PR bot please? Rebecca Cran
@ 2024-10-29  5:43 ` Michael D Kinney
  2024-10-29  6:04   ` Rebecca Cran
  0 siblings, 1 reply; 4+ messages in thread
From: Michael D Kinney @ 2024-10-29  5:43 UTC (permalink / raw)
  To: Rebecca Cran, devel@edk2.groups.io; +Cc: Kinney, Michael D

I believe the timeframe to mark one stale is configurable.

Is there a proposal for a different wait time?

Mike

> -----Original Message-----
> From: Rebecca Cran <rebecca@bsdio.com>
> Sent: Monday, October 28, 2024 7:35 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: Could we reconsider the GitHub stale PR bot please?
> 
> See the attached screenshot or
> https://github.com/tianocore/edk2/pull/5907#issuecomment-2408745999 .
> 
> The PR was marked stale by the bot and the PR author only responded two
> weeks later - which would have been one week too late.
> 
> Fortunately I noticed and commented to keep it open, but I think we
> should reconsider the use of the stale bot.
> 
> 
> --
> Rebecca


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120691): https://edk2.groups.io/g/devel/message/120691
Mute This Topic: https://groups.io/mt/109271104/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [edk2-devel] Could we reconsider the GitHub stale PR bot please?
  2024-10-29  5:43 ` Michael D Kinney
@ 2024-10-29  6:04   ` Rebecca Cran
  2024-10-29 17:42     ` Michael D Kinney
  0 siblings, 1 reply; 4+ messages in thread
From: Rebecca Cran @ 2024-10-29  6:04 UTC (permalink / raw)
  To: devel, Kinney, Michael D

How about 6 months? And closing it if there’s been no follow-up to the bot’s comment after 3 months?

Rebecca

On Mon, Oct 28, 2024, at 11:43 PM, Michael D Kinney wrote:
> I believe the timeframe to mark one stale is configurable.
>
> Is there a proposal for a different wait time?
>
> Mike
>
>> -----Original Message-----
>> From: Rebecca Cran <rebecca@bsdio.com>
>> Sent: Monday, October 28, 2024 7:35 PM
>> To: devel@edk2.groups.io
>> Cc: Kinney, Michael D <michael.d.kinney@intel.com>
>> Subject: Could we reconsider the GitHub stale PR bot please?
>> 
>> See the attached screenshot or
>> https://github.com/tianocore/edk2/pull/5907#issuecomment-2408745999 .
>> 
>> The PR was marked stale by the bot and the PR author only responded two
>> weeks later - which would have been one week too late.
>> 
>> Fortunately I noticed and commented to keep it open, but I think we
>> should reconsider the use of the stale bot.
>> 
>> 
>> --
>> Rebecca
>
>
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120692): https://edk2.groups.io/g/devel/message/120692
Mute This Topic: https://groups.io/mt/109271104/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [edk2-devel] Could we reconsider the GitHub stale PR bot please?
  2024-10-29  6:04   ` Rebecca Cran
@ 2024-10-29 17:42     ` Michael D Kinney
  0 siblings, 0 replies; 4+ messages in thread
From: Michael D Kinney @ 2024-10-29 17:42 UTC (permalink / raw)
  To: Rebecca Cran, devel@edk2.groups.io; +Cc: Kinney, Michael D

Hi Rebecca,

Here is the link to the full description of the action and all of its settings

	https://github.com/actions/stale

Here is the link to the edk2 repo GitHub Action workflow that uses this action

	https://github.com/tianocore/edk2/blob/master/.github/workflows/stale.yml

Current settings ate 60 days to slate and 7 days to close.

I think you are suggesting changing those to 180 days and 90 days.

Do you want to create a PR with those changes?

Mike



> -----Original Message-----
> From: Rebecca Cran <rebecca@bsdio.com>
> Sent: Monday, October 28, 2024 11:04 PM
> To: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: Re: [edk2-devel] Could we reconsider the GitHub stale PR bot
> please?
> 
> How about 6 months? And closing it if there’s been no follow-up to the
> bot’s comment after 3 months?
> 
> Rebecca
> 
> On Mon, Oct 28, 2024, at 11:43 PM, Michael D Kinney wrote:
> > I believe the timeframe to mark one stale is configurable.
> >
> > Is there a proposal for a different wait time?
> >
> > Mike
> >
> >> -----Original Message-----
> >> From: Rebecca Cran <rebecca@bsdio.com>
> >> Sent: Monday, October 28, 2024 7:35 PM
> >> To: devel@edk2.groups.io
> >> Cc: Kinney, Michael D <michael.d.kinney@intel.com>
> >> Subject: Could we reconsider the GitHub stale PR bot please?
> >>
> >> See the attached screenshot or
> >> https://github.com/tianocore/edk2/pull/5907#issuecomment-2408745999 .
> >>
> >> The PR was marked stale by the bot and the PR author only responded
> two
> >> weeks later - which would have been one week too late.
> >>
> >> Fortunately I noticed and commented to keep it open, but I think we
> >> should reconsider the use of the stale bot.
> >>
> >>
> >> --
> >> Rebecca
> >
> >
> > 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120693): https://edk2.groups.io/g/devel/message/120693
Mute This Topic: https://groups.io/mt/109271104/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-10-29 17:42 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-29  2:34 [edk2-devel] Could we reconsider the GitHub stale PR bot please? Rebecca Cran
2024-10-29  5:43 ` Michael D Kinney
2024-10-29  6:04   ` Rebecca Cran
2024-10-29 17:42     ` Michael D Kinney

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox