[edk2-devel] [PATCH v2 2/2] edk2-test: uefi-sct: Correct the vlanId check in DevicePath Test

[edk2-devel] [PATCH v2 2/2] edk2-test: uefi-sct: Correct the vlanId check in DevicePath Test

[G Edhaya Chandran]

The DevicePathBBTest wrongly flags the failure for a valid VLAN device
path node. For e.g. value 4040
The range check for vlanId is corrected to fix this issue.

https://bugzilla.tianocore.org/show_bug.cgi?id=4710

Signed-off-by: G Edhaya Chandran <edhaya.chandran@arm.com>
---
 uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePath/BlackBoxTest/DevicePathBBTestFunction.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePath/BlackBoxTest/DevicePathBBTestFunction.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePath/BlackBoxTest/DevicePathBBTestFunction.c
index c8757e958a22..21c286ea4096 100644
--- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePath/BlackBoxTest/DevicePathBBTestFunction.c
+++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePath/BlackBoxTest/DevicePathBBTestFunction.c
@@ -682,7 +682,7 @@ BBTestDevicePathNodeConformanceAutoTest (
     //
     else if ((Type == 3) && (SubType == 20)) {
       Vlan = (VLAN_DEVICE_PATH *) DevicePath;
-      if (Vlan->VlanId > 4094 || Vlan->VlanId) {
+      if (Vlan->VlanId > 4094) {
         AssertionType = EFI_TEST_ASSERTION_FAILED;
       } else {
         AssertionType = EFI_TEST_ASSERTION_PASSED;
-- 
2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120661): https://edk2.groups.io/g/devel/message/120661
Mute This Topic: https://groups.io/mt/109165242/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 2/2] edk2-test: uefi-sct: Correct the vlanId check in DevicePath Test

[Sunny Wang]

[-- Attachment #1: Type: text/plain, Size: 2880 bytes --]

Looks good. Thanks, Edhaya.

Reviewed-by: Sunny Wang <sunny.wang@arm.com<mailto:sunny.wang@arm.com>>



-----Original Message-----
From: G Edhaya Chandran via groups.io<http://groups.io> <edhaya.chandran=arm.com@groups.io<mailto:arm.com@groups.io>>
Date: Tue, Oct 22, 2024 at 10:36 PM
Subject: [edk2-devel] [PATCH v2 2/2] edk2-test: uefi-sct: Correct the vlanId check in DevicePath Test
To: <devel@edk2.groups.io<mailto:devel@edk2.groups.io>>


The DevicePathBBTest wrongly flags the failure for a valid VLAN device
path node. For e.g. value 4040
The range check for vlanId is corrected to fix this issue.

https://bugzilla.tianocore.org/show_bug.cgi?id=4710

Signed-off-by: G Edhaya Chandran <edhaya.chandran@arm.com<mailto:edhaya.chandran@arm.com>>
---
 uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePath/BlackBoxTest/DevicePathBBTestFunction.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePath/BlackBoxTest/DevicePathBBTestFunction.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePath/BlackBoxTest/DevicePathBBTestFunction.c
index c8757e958a22..21c286ea4096 100644
--- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePath/BlackBoxTest/DevicePathBBTestFunction.c
+++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePath/BlackBoxTest/DevicePathBBTestFunction.c
@@ -682,7 +682,7 @@ BBTestDevicePathNodeConformanceAutoTest (
     //
     else if ((Type == 3) && (SubType == 20)) {
       Vlan = (VLAN_DEVICE_PATH *) DevicePath;
-      if (Vlan->VlanId > 4094 || Vlan->VlanId) {
+      if (Vlan->VlanId > 4094) {
         AssertionType = EFI_TEST_ASSERTION_FAILED;
       } else {
         AssertionType = EFI_TEST_ASSERTION_PASSED;
--
2.25.1



------------
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120661): https://edk2.groups.io/g/devel/message/120661
Mute This Topic: https://groups.io/mt/109165242/5907162
Group Owner: devel+owner@edk2.groups.io<mailto:devel%2Bowner@edk2.groups.io>
Unsubscribe: https://edk2.groups.io/g/devel/unsub [sunny.hsuanwen.wang@gmail.com<mailto:sunny.hsuanwen.wang@gmail.com>]
------------

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120684): https://edk2.groups.io/g/devel/message/120684
Mute This Topic: https://groups.io/mt/109165242/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 6483 bytes --]

Re: [edk2-devel] [PATCH v2 2/2] edk2-test: uefi-sct: Correct the vlanId check in DevicePath Test

[G Edhaya Chandran via groups.io]

[-- Attachment #1: Type: text/plain, Size: 502 bytes --]

The solution is upstreamed through the commit:
https://github.com/tianocore/edk2-test/commit/8ac40d6809a62661ab71a8d9d8a9b58ad06df522


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120905): https://edk2.groups.io/g/devel/message/120905
Mute This Topic: https://groups.io/mt/109165242/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 936 bytes --]