From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) by mx.groups.io with SMTP id smtpd.web10.27760.1595448182462978623 for ; Wed, 22 Jul 2020 13:03:03 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@broadcom.com header.s=google header.b=LI2/q4p+; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: broadcom.com, ip: 209.85.208.182, mailfrom: vladimir.olovyannikov@broadcom.com) Received: by mail-lj1-f182.google.com with SMTP id r19so3796297ljn.12 for ; Wed, 22 Jul 2020 13:03:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:references:in-reply-to:mime-version:thread-index:date :message-id:subject:to:cc; bh=/uejsQj73Vheh8TfgQLztxZmz5rA3CTjjEzFjLr/2WY=; b=LI2/q4p+vmqXX/e7GG0P0LGRELjSQ0xMNb98am+GI+vA7/6NXIK4G9NFTFk1hW9H+N 2UBTy/ASorwvHr/RQEuuyBqVg30/02aM/WyvrBL8/Q1CY6jWY1AJPBYaNoUsIPWtPgOl qyg43Aw21SA4603WIBsC/4ruNuFj8gSFnm+xQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:references:in-reply-to:mime-version :thread-index:date:message-id:subject:to:cc; bh=/uejsQj73Vheh8TfgQLztxZmz5rA3CTjjEzFjLr/2WY=; b=ZCQq0ZCXUBQ+9Dk2Lk8T6IkwD692BYaW4UGQmmLiKP3kwC3iIl6MWTHGOy+lWK9R+K bkgzJS1sSIOWG8qV5Hm9GqSCAMD0yez9Gc0gYTU2gMiWum+hnpxi19YXBkKPzg1VvJla roH6em0W61YzwjsROfWB95jc8SOs179WPi+CFwb5+mMPlAb58LTHiw+LbunwprBC/m8j lZ9YrRq8ZSWqFwcQgrZ+o9Pu5tX4XDWmr3K7LCxcMiq4FPyHiKK6eXyP/wDHxevMIyhk NAGpLWfEokJ58Y/rXbpBsEVYPNqpfk01HZWChRXKqMl+Jy5RdlxyBkTTo+eHho4JImse Cozg== X-Gm-Message-State: AOAM531+BnPImYTVXil6HSBEAcriWKfFEc+GW6bHOpzt7H2VhUD+Zh5+ PHsHCSywx/gVBDfEntbJCKmGIPLsuxlojqD/aFh6CA== X-Google-Smtp-Source: ABdhPJwsrqUQR67du0VQcABGlPZaj8GekjEuR/0yaVckNI7OTvffdpO0JH6cXRtlzJdK5u8f3AQE265x4CfLL6SS6Zc= X-Received: by 2002:a2e:b4d0:: with SMTP id r16mr391068ljm.332.1595448180593; Wed, 22 Jul 2020 13:03:00 -0700 (PDT) From: "Vladimir Olovyannikov" References: <20200721172305.9011-1-vladimir.olovyannikov@broadcom.com> <20200721172305.9011-3-vladimir.olovyannikov@broadcom.com> In-Reply-To: MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQIbThj8YFYraaimShvXbtiVFtYD2wKMhnr2Ake8lOaoY4cHkA== Date: Wed, 22 Jul 2020 13:02:55 -0700 Message-ID: <4767b4be3123d81816ad90be93e67f1b@mail.gmail.com> Subject: Re: [PATCH 2/2] OvmfPkg: enable HttpDynamicCommand To: Laszlo Ersek , devel@edk2.groups.io Cc: Ard Biesheuvel , Leif Lindholm Content-Type: text/plain; charset="UTF-8" Hi Laszlo, Thank you for reviewing the patchset. > -----Original Message----- > From: Laszlo Ersek > Sent: Wednesday, July 22, 2020 12:52 PM > To: Vladimir Olovyannikov ; > devel@edk2.groups.io > Cc: Ard Biesheuvel ; Leif Lindholm > > Subject: Re: [PATCH 2/2] OvmfPkg: enable HttpDynamicCommand > > On 07/21/20 19:23, Vladimir Olovyannikov wrote: > > Enable HttpDynamicCommand (Shell command "http") for OvmfPkg > platforms > > > > Signed-off-by: Vladimir Olovyannikov > > > > --- > > OvmfPkg/OvmfPkgIa32.dsc | 6 ++++++ > > OvmfPkg/OvmfPkgIa32X64.dsc | 6 ++++++ > > OvmfPkg/OvmfPkgX64.dsc | 6 ++++++ > > OvmfPkg/OvmfXen.dsc | 6 ++++++ > > 4 files changed, 24 insertions(+) > > > > diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc index > > 9178ffeb71cb..aed3a73c0172 100644 > > --- a/OvmfPkg/OvmfPkgIa32.dsc > > +++ b/OvmfPkg/OvmfPkgIa32.dsc > > @@ -883,6 +883,12 @@ [Components] > > > > gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE > > } > > + > > + > ShellPkg/DynamicCommand/HttpDynamicCommand/HttpDynamicCommand > .inf { > > + > > + gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE > > + } > > + > > > OvmfPkg/LinuxInitrdDynamicShellCommand/LinuxInitrdDynamicShellComma > nd.inf { > > > > gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE > > diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc > b/OvmfPkg/OvmfPkgIa32X64.dsc > > index a665f78f0dc7..6c07326cc0fe 100644 > > --- a/OvmfPkg/OvmfPkgIa32X64.dsc > > +++ b/OvmfPkg/OvmfPkgIa32X64.dsc > > @@ -897,6 +897,12 @@ [Components.X64] > > > > gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE > > } > > + > > + > ShellPkg/DynamicCommand/HttpDynamicCommand/HttpDynamicCommand > .inf { > > + > > + gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE > > + } > > + > > > OvmfPkg/LinuxInitrdDynamicShellCommand/LinuxInitrdDynamicShellComma > nd.inf { > > > > gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE > > diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc index > > 17f345acf4ee..d5e5bcf8e66c 100644 > > --- a/OvmfPkg/OvmfPkgX64.dsc > > +++ b/OvmfPkg/OvmfPkgX64.dsc > > @@ -893,6 +893,12 @@ [Components] > > > > gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE > > } > > + > > + > ShellPkg/DynamicCommand/HttpDynamicCommand/HttpDynamicCommand > .inf { > > + > > + gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE > > + } > > + > > > OvmfPkg/LinuxInitrdDynamicShellCommand/LinuxInitrdDynamicShellComma > nd.inf { > > > > gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE > > diff --git a/OvmfPkg/OvmfXen.dsc b/OvmfPkg/OvmfXen.dsc index > > 782803cb2787..fe549502863a 100644 > > --- a/OvmfPkg/OvmfXen.dsc > > +++ b/OvmfPkg/OvmfXen.dsc > > @@ -675,6 +675,12 @@ [Components] > > > > gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE > > } > > + > > + > ShellPkg/DynamicCommand/HttpDynamicCommand/HttpDynamicCommand > .inf { > > + > > + gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE > > + } > > + > > > OvmfPkg/LinuxInitrdDynamicShellCommand/LinuxInitrdDynamicShellComma > nd.inf { > > > > gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE > > > > Basically same comments as under the ArmVirtPkg patch: > > (1) Please mention > in the commit message. OK, will do. For future contributions related to a BZ ticket - does it mean that mentioning of BZ id in the cover letter is not enough? > > (2) Please don't introduce the extra whitespace in the DSC files. > > (3) Please also add the new module to the following (FDF) files: > > - OvmfPkgIa32.fdf > - OvmfPkgIa32X64.fdf > - OvmfPkgX64.fdf > - OvmfXen.fdf OK, will do, thanks. > > Once you post v2 of this series, with the above points fixed (especially > the > FDF files), I'd like to test the new command (with both ArmVirtQemu and > OVMF). Sure, that would be great. > > Thanks! > Laszlo Thank you, Vladimir