From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 3932C7803D1 for ; Wed, 5 Jun 2024 15:19:50 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=j27X1jNsyeIrWPaoXLR8KFoCOtff1WUVGITZuFcVpvU=; c=relaxed/simple; d=groups.io; h=Received-SPF:Authentication-Results-Original:Message-ID:Date:User-Agent:Subject:To:Cc:References:From:In-Reply-To:MIME-Version:NoDisclaimer:Original-Authentication-Results:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1717600789; v=1; b=yIm4GXJb5hHDC43gofywBEfYSt65xBgrnjBeZ9D47MQmZYrXRzDTGIe/8BsPXV/sNIWu2At+ jN9BM+u+dZFhhwB15fBYLEajoE7pgijJ7xQKTnMfi9e5z++oK+yyJw3wTo5pHPinw71XxyqQStL aA5zOv15jhTjBvjU8x8kU522CPKkCCtA+3gYuklUkj3lcXpN0UBg4HKdoN07d0dKEX1lrpS6R6D D91HmrX4WM58ow7HtXUQHQqSAQGJHNRZ5iT7sHo9AFDCaifZ/LlBwDJEI5jb3ly3F4U4TUN1iYX /8rXuGNaBjgIgB5wOONx4CBm0SYyg1zRrJ+9x4WCh/xIA== X-Received: by 127.0.0.2 with SMTP id 7YeVYY7687511xPz2hTBKP4v; Wed, 05 Jun 2024 08:19:48 -0700 X-Received: from EUR01-VE1-obe.outbound.protection.outlook.com (EUR01-VE1-obe.outbound.protection.outlook.com [40.107.14.73]) by mx.groups.io with SMTP id smtpd.web10.18218.1717600787634284724 for ; Wed, 05 Jun 2024 08:19:48 -0700 X-Received: from DUZPR01CA0204.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b6::25) by AS8PR08MB9694.eurprd08.prod.outlook.com (2603:10a6:20b:616::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.31; Wed, 5 Jun 2024 15:19:42 +0000 X-Received: from DB1PEPF000509E8.eurprd03.prod.outlook.com (2603:10a6:10:4b6:cafe::d0) by DUZPR01CA0204.outlook.office365.com (2603:10a6:10:4b6::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.31 via Frontend Transport; Wed, 5 Jun 2024 15:19:42 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB1PEPF000509E8.mail.protection.outlook.com (10.167.242.58) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.7633.15 via Frontend Transport; Wed, 5 Jun 2024 15:19:40 +0000 X-Received: ("Tessian outbound 58fd6e711286:v327"); Wed, 05 Jun 2024 15:19:40 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 3544236ab895f5f5 X-CR-MTA-TID: 64aa7808 X-Received: from 3cc0261b71ea.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id CCE69986-4368-47B0-93AB-4C61BEFECF4C.1; Wed, 05 Jun 2024 15:19:30 +0000 X-Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 3cc0261b71ea.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 05 Jun 2024 15:19:29 +0000 Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by PA4PR08MB7387.eurprd08.prod.outlook.com (2603:10a6:102:2a2::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.21; Wed, 5 Jun 2024 15:19:26 +0000 X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::3935:6d9d:93a2:cbf3]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::3935:6d9d:93a2:cbf3%5]) with mapi id 15.20.7633.021; Wed, 5 Jun 2024 15:19:26 +0000 Message-ID: <476d4e56-d6d5-4918-a76c-132f531f4341@arm.com> Date: Wed, 5 Jun 2024 16:19:24 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 0/5] Platform/Sgi: Extend SMBIOS support for RD-V2 and RD-Fremont To: Prabin CA , devel@edk2.groups.io Cc: Ard Biesheuvel , Leif Lindholm , Thomas Abraham , nd@arm.com References: <20240403173334.3063987-1-prabin.ca@arm.com> From: "Sami Mujawar" In-Reply-To: <20240403173334.3063987-1-prabin.ca@arm.com> X-ClientProxiedBy: LO4P265CA0012.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ad::7) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|PA4PR08MB7387:EE_|DB1PEPF000509E8:EE_|AS8PR08MB9694:EE_ X-MS-Office365-Filtering-Correlation-Id: 5f2a715e-34cb-4056-c351-08dc8572ebd5 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0;ARA:13230031|366007|1800799015|376005; X-Microsoft-Antispam-Message-Info-Original: =?utf-8?B?OEYyN3U4cUh3VVYzbEVDV05LOHUvWDQyaGQwc2JJb1ovU0tjMTlBcWIxcE8z?= =?utf-8?B?cDN1UzUyYUVrNmZ3UjV5ejJlOTBUZ3hTK21yS3hpdGs4REtxTUZIRW1wczlW?= =?utf-8?B?eTJCSm83bEg5aEpUMTNQdWdxSDd4SktVZ2VCaDFVa3NCOWdnSnJWaktmT0hq?= =?utf-8?B?cExYMFBIdCttQ3c1RnkwRGJIOWlJOVlzZ0dSNm9OWFY5NUdDRm9LQis4Nzd2?= =?utf-8?B?VU1KMWhLUHIrQlFONmNmUHJMdDZEc21iZFE1NVdjL3hhdS9BYjhFSGRoQVBm?= =?utf-8?B?OGk5K29LRGtwaGpuSE9oK0pCUWdDQkpjUnU2VHlET3UyMFBWM2RCMm5ONlY2?= =?utf-8?B?ZCszUnRpa3p0bExta0lMelIrS0NrVWxuMFgzYmwzbS9CTUtnZWV5L0c2M2Z6?= =?utf-8?B?dCtsV3lyRzYxakZ6REd6ZnFZRDFJWm5hcEl0UnlXek9jaEFVTnd1Q1h4L1Rp?= =?utf-8?B?dFlNRzdZbURtMFlINDV3ajBVVU9VZUxJWEhtWFVYeUk4UVowaHFDMmlnRmdH?= =?utf-8?B?MHJaOGJVUGRoR0U2NHA2blNFOXdyYmw1amZodEtJZ01PR1ZWSC9vV3JrcUZX?= =?utf-8?B?S3V0UzlzRWpjUzR6eTcrUXZsZ1hMVkdSV3hXVkpQZFhkeVlaL1o5TEk1eEE0?= =?utf-8?B?bDBFb2w2eXFlZ2hxZUtET1ZQbVRhL0ZkVXRXaGlaRUZ5VEY2aysyTzhhRlBw?= =?utf-8?B?eC9OcUVkQkdNWHZndXBOYTBRNWpaS3BjWWUwTWdDS2F0V292eE02Ym9JWXd3?= =?utf-8?B?ajV1ajgrcUlSdUIvQXZBR2U5TTJBclFwdXQySGR3TlRLdXpadWluVVQ2bjVG?= =?utf-8?B?aSt4OVdxdDYzZnFNeGxjMG42b0ZSOWswbXJWYVYrS3lTRWhyMk00SlVRVTFJ?= =?utf-8?B?UysrVlBYYldYZXE2aXB6dlRsQ1dSUzZ5R1BYZC9yWkNzS090RGFUNnFONWRz?= =?utf-8?B?OHdrVTNudDNrMk9PazVWNkRDUStwdFRlblZOZTMzWTdMOFBOTlpuSlorR0J5?= =?utf-8?B?aHQwQ3U5LzFzY1ZoZ25TV2ZPYmRpbmJ2aEhuZVZUaFAweDh4WldmZyttemRG?= =?utf-8?B?aHQ5KzlYcG9oOWd3TGJ6OE9OZk4zbDRqdDBvOG5yRjViT2JXQnVMMFM4Z0pC?= =?utf-8?B?VlFwcXdaRTdPM0lmanRQekl1MjFHa3dUbGZweU5za2RKMm9XZ2JZOVRVWmVQ?= =?utf-8?B?S1YrcFNCbUsvWGROaWRqWmRFc082amNkbjZsNFdrQjRJaHd0eG9CQjJoYkY2?= =?utf-8?B?Z0lmeENLV1JDeGZpWFI4d1Avd2xXVkRrTSt5TUt0VGNISzQvY003Z2VVVzhP?= =?utf-8?B?M2drRXdpZUJkbHA0aFVsemNoSTJUczBJNVdjQi9Ca2k5V1BmT1RCY3FkeEZE?= =?utf-8?B?cjVKZk1GZHM3ZDdqUWxDR2pCS1V1V2RPTDJQR1ZHSkFWY0FTTkc3REVXcnk3?= =?utf-8?B?Nlc4Y1ZGY25IbEQ2Z2FRd2dkWGpHTk9Bc2xXVmFtdm9zRGVaTGhLUHZFemJa?= =?utf-8?B?SGtNdVJDM01YZ0VkRk9VSDdqNlhna1UrUllqZDV2Y0lTUno4VE51ZzRhQ2pa?= =?utf-8?B?OHpCVFpvU3c3MjdOcUdxZ2RDZTBKQ241bWdYYm4xRzduNW5pTjllVDVpZjhs?= =?utf-8?B?R3ZlSytEb2t6aTVGSGRrVndtcHQwa1V4MU0wS3hRTFFUWW1mRWt2d3FycVZ3?= =?utf-8?B?VXd6b0MzaHB5TGFpS2djWDREZ1ZUUzlwd2x4WHBtbW9HVjVBR3ZjbEF3PT0=?= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366007)(1800799015)(376005);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB7387 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB1PEPF000509E8.eurprd03.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 6e539ce8-1ba4-4511-d413-08dc8572e303 X-Microsoft-Antispam-Message-Info: =?utf-8?B?U3lOa1hqL3dBWmtZWTZIN0toWmhlTkRmREh0aTdlQlVwci9OSmc0amNRYVFy?= =?utf-8?B?Qy8vbm9STUNvQnhMYkZUWHpQd2d6V3JaMGVQSGt3KzhGUnVnY1JaZXFYOGNl?= =?utf-8?B?bjkxWFovd09SU0FXNHNQN0tVZFNsNng3QklEU25FMGFDR0FFQ25NTzNpWGFF?= =?utf-8?B?VUQrb3VHZWNFZkw1MXkvenJLR0R6eVlwTmtreDFXMmVOWjVzSURWdVlxODc4?= =?utf-8?B?NVUwbEhYbkMrU3FxL3doZjhkb1VGYXdTRGpNUjFwZTNHOHRBcXQzYVdBSTZY?= =?utf-8?B?MmVKSy9zYk5KTjNTUzV3L1gxWGVKQTJIWkNIQVpJRkdVYmJxcFJad2p3M0Jw?= =?utf-8?B?cThWNUhDakJVOFJ3ZWh4WllLVVpXNGFGQ1dyOVlzL1ZWVDRNcjhvYUdudFE0?= =?utf-8?B?UHNpVXhrcTBqb0lvNkYvd1N5RFUxaHZpaTZ4V0U1cmZHK2piZ2ZzTDVjbzIv?= =?utf-8?B?ZkNSd2tHTFNEZlVBcHFqNHZDak9NTkZDUDhPeElEWFVmZTd2RjlYMFNzWTF3?= =?utf-8?B?ZGQyRkxIek1kTnRtZEpXUlN5Y2RsMlhTbkxKc3lLcE9mQmF0L0w5RGIvYkRG?= =?utf-8?B?T2FOaThha2V0WGkvZk5jQWtZWjZSdGp5SHVZMGRRS3lkaDJkc3FnbmR1OXFa?= =?utf-8?B?UFFzYzhlQnJ5YkNyWnVTWWpXV2tUUStUVzR1U1p0OS9yaFlCL0JDUlhxK2hj?= =?utf-8?B?ZldBVVZoSnZ5S01zZzRucjE1MHFmZFVWTkI5amFzbDQxQk1DcGdhVlp4UDcw?= =?utf-8?B?Qm9Lc0pQc3hNeUYwa1kyRTlxN20zRHNXK1I1S3pHWGxRWXMwNCs3dkQvbmZr?= =?utf-8?B?SlV5eXBjb284NWN4VVZyUklhY0FJWVlyaE0zRjJQcDNkdWZiYlo2d0FmbGc1?= =?utf-8?B?RzlaMDQyRmhsYi8rcjdUamRibVdGc1VqVTdwcUx4MUtPM3ROV1g5N0FYMWlW?= =?utf-8?B?cUk3NFpsWHRKdXRpbVBCV2VHdEtjQnZ3NlR4dzdXZ0dDNnIvMnVmUWRHT3Np?= =?utf-8?B?U1ZkQmM2YnplTmFiZ0RtZmYzY3c3S3BNYm5BdjZ3UVo4akpZQXQvSFozNEpx?= =?utf-8?B?WStkbmlIaHVESzF0ZkN3Ni9CKzVuZTlxbmxqOU5KSlFoYzMvZ3Fmd1ovek8z?= =?utf-8?B?emRCNFF5TTVPMFRaZ28ydENtTkU3cS9MUWpYY1lNbVJ4RTltQWM1QThmMlRN?= =?utf-8?B?eWh3UmNSckQyUTFSZWZIblJaVXBNemoxa0cvUTI3SXRGRG9oNkp5cHlaZDZ2?= =?utf-8?B?ZnJ5RXZ3ZGR0clQyeE1jQVlmMjcyWkpLdnNxRnVHS0hBRDU0VGVydkJ0ckQ1?= =?utf-8?B?QTFTMUIyYW56dkJtN2VrWjhlR0xtWHQxTDA5QTdSNzdsSTRtcldIa0xTdWZV?= =?utf-8?B?cFBlZHZUdGsxdjRFZHBkaS9xaWtqMTBOYlFLS3ppd0Q1UzdBbm1vS1RXekIx?= =?utf-8?B?VU82aDRlNGV3V3UwSWlqQTR2ODlMRmF4REhFRWJXcUR5UWJHY25KQTNmVmlD?= =?utf-8?B?U0NUZ1dWeHNCak56ZmtCZWFIcU5vZGRKOXdwazB1ZDNyVzRma3o2NWU0a2hG?= =?utf-8?B?WVg3dy9TMDkrdXk2UDZoQkU5ZjNjMjdhRHprSFFlQWRQTjhFVjUzK29YYXRj?= =?utf-8?B?TEh5cG9vVnpDR3NXUU40WkQ5bmVrVE50UkJaUGMvTFVHbG1sNGZUSzdUa0hR?= =?utf-8?B?U3J6bHo2TnVPWXZyS0RXcE4vSm9GL0lIR2RKU2d4Y1JBREsvMU4xem4rWDF5?= =?utf-8?B?aE4wditxcG5ZQTJNME5mWFBUVUxHL0RReWt3Wjl6OWhkMXdsbWNzQ1B1cG9X?= =?utf-8?B?cFQ4djdlVEFXUU56aDM0WG4rZVBJVXlFVWY3QWxNa1IyTHluVW94RnE2aVFV?= =?utf-8?B?NUNtbk5ORHZLTElXM3VDNkpSMkFCVHQzV0tFZnhJbTFqR1E9PQ==?= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2024 15:19:40.9032 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5f2a715e-34cb-4056-c351-08dc8572ebd5 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB1PEPF000509E8.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9694 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 05 Jun 2024 08:19:48 -0700 Resent-From: sami.mujawar@arm.com Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: oC7YPLRQldwrE2UkmCp3Wabrx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=yIm4GXJb; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Prabin, If you agree with my suggestions for patch 2/5, can you reply back on=20 the list, please? I will then fix that patch locally before merging. Other than patch 2/5 the rest of the series looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 4/3/24 18:33, Prabin CA wrote: > Each CPUs of RD-V2 has 64KB of L1 instruction/data cache, 2MB of L2 > cache and 32MB of system level cache. The system architecture of the > RD-V2 platform is similar to the RD-N2 platform, except for the CPU > and L2 cache size. So existing RD-N2 SMBIOS support is extended for > RD-V2 platform to reuse rest of the RD-N2 SMBIOS configuration for the > RD-V2 platform. > > Each CPUs of RD-Fremont include 64KB L1 instruction/data cache, 2MB L2 > cache and 2MB of system level cache. This patch series adding the > extended SMBIOS support for RD-Fremont platform. > > In addition to patches that extend the SMBIO support for these two > platforms, there are two patches that update support for existing > platforms. The first patch in this series introduce a PCD to specify > L2 cache size. The second patch make use of this PCD in PPTT table. > > Link to gitlab branch with the patches in this series - > https://gitlab.arm.com/infra-solutions/reference-design/platsw/edk2-platf= orms/-/commits/topics/rdv2/?ref_type=3Dheads > > Prabin CA (3): > Platform/Sgi: Add a new PCD for L2 cache size > Platform/Sgi: Use PCD value for L2 cache size in PPTT table > Platform/Sgi: Extend SMBIOS support for RD-Fremont > > Pranav Madhu (2): > Platform/Sgi: Define RD-V2 platform id values > Platform/Sgi: Extend SMBIOS support for RD-V2 platform > > Platform/ARM/SgiPkg/SgiPlatform.dec = | 3 +++ > Platform/ARM/SgiPkg/RdN2/RdN2.dsc = | 4 ++++ > Platform/ARM/SgiPkg/AcpiTables/RdN2AcpiTables.inf = | 1 + > Platform/ARM/SgiPkg/Include/SgiPlatform.h = | 12 ++++++++++- > Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type1SystemInformation.c = | 10 ++++++++-- > Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type4ProcessorInformation= .c | 12 ++++++++--- > Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type7CacheInformation.c = | 21 +++++++++++++++++++- > Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLib.c = | 14 ++++++++++++- > Platform/ARM/SgiPkg/AcpiTables/RdN2/Pptt.aslc = | 4 +++- > 9 files changed, 72 insertions(+), 9 deletions(-) > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119477): https://edk2.groups.io/g/devel/message/119477 Mute This Topic: https://groups.io/mt/105313647/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-