public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Stefan Berger" <stefanb@linux.ibm.com>
To: Ard Biesheuvel <ardb@kernel.org>,
	edk2-devel-groups-io <devel@edk2.groups.io>
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Jiewen Yao" <jiewen.yao@intel.com>,
	"Ard Biesheuvel" <ardb+tianocore@kernel.org>,
	"Leif Lindholm" <leif@nuviainc.com>,
	"Sami Mujawar" <sami.mujawar@arm.com>,
	"Stefan Berger" <stefanb@linux.vnet.ibm.com>
Subject: Re: [edk2-devel] [RFC PATCH 1/3] ArmVirtPkg/TPM: Add a NULL implementation of TpmPlatformHierarchyLib
Date: Wed, 22 Sep 2021 12:29:09 -0400	[thread overview]
Message-ID: <47731adc-9eaa-15fd-3508-5dd78ac0c776@linux.ibm.com> (raw)
In-Reply-To: <CAMj1kXGYo=MJ0wyVGbcLHF6Uh1D2ppEEGHoX2pKM8ccG0tSQOA@mail.gmail.com>

On 9/22/21 7:39 AM, Ard Biesheuvel wrote:

>
>>>> +[Defines]
>>>> +  INF_VERSION                    = 0x00010005
>>> 1.27
>> Originally all comes from this file here:
>> https://github.com/tianocore/edk2/blob/master/SecurityPkg/Library/PeiDxeTpmPlatformHierarchyLib/PeiDxeTpmPlatformHierarchyLib.inf#L16
>>
> Doesn't matter. New INFs use the latest version
>
>>>> +  BASE_NAME                      = PeiDxeTpmPlatformHierarchyLibNull
>>> Make this BasePlatform....
>> Even though it will be different than here?
>> https://github.com/tianocore/edk2/blob/master/SecurityPkg/Library/PeiDxeTpmPlatformHierarchyLib/PeiDxeTpmPlatformHierarchyLib.inf#L17
>>
> Yes.



Fixed in upcoming v3.


    Stefan



  reply	other threads:[~2021-09-22 16:29 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-16 21:17 [RFC PATCH 0/3] ArmVirtPkg: Disable the TPM 2 platform hierarchy Stefan Berger
2021-09-16 21:17 ` [RFC PATCH 1/3] ArmVirtPkg/TPM: Add a NULL implementation of TpmPlatformHierarchyLib Stefan Berger
2021-09-18  7:55   ` [edk2-devel] " Ard Biesheuvel
2021-09-18 11:53     ` Stefan Berger
2021-09-22 11:39       ` Ard Biesheuvel
2021-09-22 16:29         ` Stefan Berger [this message]
2021-09-18  8:48   ` Sami Mujawar
2021-09-18 11:57     ` [edk2-devel] " Stefan Berger
2021-09-16 21:17 ` [RFC PATCH 2/3] ArmVirtPkg: Reference new TPM classes in the build system for compilation Stefan Berger
2021-09-18  8:49   ` Sami Mujawar
2021-09-18 11:59     ` [edk2-devel] " Stefan Berger
2021-09-16 21:17 ` [RFC PATCH 3/3] ArmVirtPkg: Disable the TPM2 platform hierarchy Stefan Berger
2021-09-18  8:51   ` Sami Mujawar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47731adc-9eaa-15fd-3508-5dd78ac0c776@linux.ibm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox