public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* TDX patches have broken edk2 bisectability in OVMF
@ 2022-04-12 21:00 James Bottomley
  2022-04-15 17:44 ` [edk2-devel] " Lendacky, Thomas
  0 siblings, 1 reply; 2+ messages in thread
From: James Bottomley @ 2022-04-12 21:00 UTC (permalink / raw)
  To: Min Xu, Jiewen Yao; +Cc: Gerd Hoffmann, devel

I've identified a serious performance regression in recent edk2, so
I've been trying to identify it by bisection, but it seems that the TDX
patches have broken bisection in edk2.  You can see this by trying to
checkout b6b2de884864 and build it.  It will give you

Active Platform          = /home/jejb/git/edk2/OvmfPkg/OvmfPkgX64.dsc
.

build.py...
/home/jejb/git/edk2/OvmfPkg/OvmfPkgX64.dsc(...): error 4000: Instance of library class [TdxLib] is not found
	in [/home/jejb/git/edk2/MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsicSev.inf] [X64]
	consumed by module [/home/jejb/git/edk2/OvmfPkg/Sec/SecMain.inf]
 

I think I can work around this, but it makes bisection extremely
painful, please don't do it again ...

James



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [edk2-devel] TDX patches have broken edk2 bisectability in OVMF
  2022-04-12 21:00 TDX patches have broken edk2 bisectability in OVMF James Bottomley
@ 2022-04-15 17:44 ` Lendacky, Thomas
  0 siblings, 0 replies; 2+ messages in thread
From: Lendacky, Thomas @ 2022-04-15 17:44 UTC (permalink / raw)
  To: devel, James.Bottomley, Min Xu, Jiewen Yao; +Cc: Gerd Hoffmann

On 4/12/22 16:00, James Bottomley via groups.io wrote:
> I've identified a serious performance regression in recent edk2, so
> I've been trying to identify it by bisection, but it seems that the TDX
> patches have broken bisection in edk2.  You can see this by trying to
> checkout b6b2de884864 and build it.  It will give you
> 
> Active Platform          = /home/jejb/git/edk2/OvmfPkg/OvmfPkgX64.dsc
> .
> 
> build.py...
> /home/jejb/git/edk2/OvmfPkg/OvmfPkgX64.dsc(...): error 4000: Instance of library class [TdxLib] is not found
> 	in [/home/jejb/git/edk2/MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsicSev.inf] [X64]
> 	consumed by module [/home/jejb/git/edk2/OvmfPkg/Sec/SecMain.inf]
>   
> 
> I think I can work around this, but it makes bisection extremely
> painful, please don't do it again ...

+1 for this as I'm trying to bisect an SEV-ES breakage on latest tree.

Thanks,
Tom

> 
> James
> 
> 
> 
> 
> 
> 
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-04-15 17:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-12 21:00 TDX patches have broken edk2 bisectability in OVMF James Bottomley
2022-04-15 17:44 ` [edk2-devel] " Lendacky, Thomas

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox