From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: bowen.zhou@intel.com) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by groups.io with SMTP; Tue, 09 Apr 2019 22:59:58 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Apr 2019 22:59:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,332,1549958400"; d="scan'208";a="336515209" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga005.fm.intel.com with ESMTP; 09 Apr 2019 22:59:56 -0700 Received: from fmsmsx125.amr.corp.intel.com (10.18.125.40) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 9 Apr 2019 22:59:56 -0700 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by FMSMSX125.amr.corp.intel.com (10.18.125.40) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 9 Apr 2019 22:59:56 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.164]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.153]) with mapi id 14.03.0415.000; Wed, 10 Apr 2019 13:56:56 +0800 From: "Zhou, Bowen" To: "Bi, Dandan" , "devel@edk2.groups.io" CC: "Lu, Shifei A" , "Oram, Isaac W" Subject: Re: [edk2-platforms/devel-MinPlatform] [patch 3/3] PurleyOpenBoardPkg/BoardMtOlympus: Use shell source directly Thread-Topic: [edk2-platforms/devel-MinPlatform] [patch 3/3] PurleyOpenBoardPkg/BoardMtOlympus: Use shell source directly Thread-Index: AQHU7179YW+6nCDgRkOjo63VkXG7aqY05Y8w Date: Wed, 10 Apr 2019 05:56:55 +0000 Message-ID: <477DBD36544FF849A8AD024E912EEC0F63B0CD7A@SHSMSX101.ccr.corp.intel.com> References: <20190410053302.18856-1-dandan.bi@intel.com> <20190410053302.18856-4-dandan.bi@intel.com> In-Reply-To: <20190410053302.18856-4-dandan.bi@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: bowen.zhou@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Xiaohu Zhou -----Original Message----- From: Bi, Dandan=20 Sent: Wednesday, April 10, 2019 1:33 PM To: devel@edk2.groups.io Cc: Lu, Shifei A ; Zhou, Bowen ; Oram, Isaac W Subject: [edk2-platforms/devel-MinPlatform] [patch 3/3] PurleyOpenBoardPkg/= BoardMtOlympus: Use shell source directly REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1675 In long term we will remove ShellBinPkg, so now update platform to use Shel= lPkg directly. Cc: Shifei A Lu Cc: Xiaohu Zhou Cc: Isaac W Oram Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan Bi --- .../BoardMtOlympus/PlatformPkg.dsc | 22 ++++++++++++++++++- .../BoardMtOlympus/PlatformPkg.fdf | 2 +- 2 files changed, 22 insertions(+), 2 deletions(-) diff --git a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkg.d= sc b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkg.dsc index 384e70a832..aa8bde5460 100644 --- a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkg.dsc +++ b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkg.dsc @@ -225,11 +225,31 @@ AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicDxe.inf !endif =20 PurleyOpenBoardPkg/Policy/S3NvramSave/S3NvramSave.inf =20 - ShellBinPkg/UefiShell/UefiShell.inf + # + # Shell + # + ShellPkg/Application/Shell/Shell.inf { + + gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE + + NULL|ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2Comma= ndsLib.inf + NULL|ShellPkg/Library/UefiShellLevel1CommandsLib/UefiShellLevel1Comma= ndsLib.inf + NULL|ShellPkg/Library/UefiShellLevel3CommandsLib/UefiShellLevel3Comma= ndsLib.inf + NULL|ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1Com= mandsLib.inf + NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1C= ommandsLib.inf + NULL|ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comma= ndsLib.inf + NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1C= ommandsLib.inf + NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2C= ommandsLib.inf + ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellCommand= Lib.inf + HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandlePars= ingLib.inf + BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfg= CommandLib.inf + ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib= .inf + ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf + } =20 MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf =20 PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf =20 diff --git a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkg.f= df b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkg.fdf index 610aa18d49..0100f88aa3 100644 --- a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkg.fdf +++ b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkg.fdf @@ -297,11 +297,11 @@ INF $(BOARD_PKG)/Policy/IioUdsDataDxe/IioUdsDataDxe.= inf INF $(BOARD_PKG)/Policy/PlatformCpuPolicy/PlatformCpuPolicy.inf INF $(BOARD_PKG)/Pci/PciPlatform/PciPlatform.inf =20 INF MinPlatformPkg/PlatformInit/PlatformInitDxe/PlatformInitDxe.inf =20 -INF ShellBinPkg/UefiShell/UefiShell.inf +INF ShellPkg/Application/Shell/Shell.inf =20 INF PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf =20 INF MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf =20 -- 2.18.0.windows.1