* [edk2-platforms/devel-MinPlatform] [patch 1/3] ClevoOpenBoardPkg/N1xxWU: Use shell source directly
2019-04-10 5:32 [edk2-platforms/devel-MinPlatform] [patch 0/3] Update to use shell source directly Dandan Bi
@ 2019-04-10 5:33 ` Dandan Bi
2019-04-10 5:33 ` [edk2-platforms/devel-MinPlatform] [patch 2/3] KabylakeOpenBoardPkg/KBLRvp3: " Dandan Bi
` (4 subsequent siblings)
5 siblings, 0 replies; 9+ messages in thread
From: Dandan Bi @ 2019-04-10 5:33 UTC (permalink / raw)
To: devel; +Cc: Michael Kubacki, Ankit Sinha, Nate DeSimone
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1675
In long term we will remove ShellBinPkg, so now update
platform to use ShellPkg directly.
Cc: Michael Kubacki <michael.a.kubacki@intel.com>
Cc: Ankit Sinha <ankit.sinha@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
.../ClevoOpenBoardPkg/N1xxWU/OpenBoardPkg.dsc | 22 ++++++++++++++++++-
.../ClevoOpenBoardPkg/N1xxWU/OpenBoardPkg.fdf | 2 +-
2 files changed, 22 insertions(+), 2 deletions(-)
diff --git a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkg.dsc b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkg.dsc
index c43a30de34..4fc4c9c141 100644
--- a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkg.dsc
+++ b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkg.dsc
@@ -272,11 +272,31 @@
MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf
MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf
MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf
MdeModulePkg/Universal/Console/GraphicsOutputDxe/GraphicsOutputDxe.inf
- ShellBinPkg/UefiShell/UefiShell.inf
+ #
+ # Shell
+ #
+ ShellPkg/Application/Shell/Shell.inf {
+ <PcdsFixedAtBuild>
+ gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE
+ <LibraryClasses>
+ NULL|ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLib.inf
+ NULL|ShellPkg/Library/UefiShellLevel1CommandsLib/UefiShellLevel1CommandsLib.inf
+ NULL|ShellPkg/Library/UefiShellLevel3CommandsLib/UefiShellLevel3CommandsLib.inf
+ NULL|ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1CommandsLib.inf
+ NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf
+ NULL|ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf
+ NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
+ NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.inf
+ ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
+ HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
+ BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
+ ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
+ ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
+ }
#
# Silicon
#
!include $(PLATFORM_SI_PACKAGE)/SiPkgDxe.dsc
diff --git a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkg.fdf b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkg.fdf
index 7f3e965c75..6b8cb4a0b5 100644
--- a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkg.fdf
+++ b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkg.fdf
@@ -337,11 +337,11 @@ INF MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf
INF MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf
INF MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf
INF MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf
INF MdeModulePkg/Universal/Console/GraphicsOutputDxe/GraphicsOutputDxe.inf
-INF ShellBinPkg/UefiShell/UefiShell.inf
+INF ShellPkg/Application/Shell/Shell.inf
INF $(PLATFORM_PACKAGE)/PlatformInit/PlatformInitDxe/PlatformInitDxe.inf
INF IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.inf
INF $(PLATFORM_PACKAGE)/Test/TestPointStubDxe/TestPointStubDxe.inf
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* [edk2-platforms/devel-MinPlatform] [patch 2/3] KabylakeOpenBoardPkg/KBLRvp3: Use shell source directly
2019-04-10 5:32 [edk2-platforms/devel-MinPlatform] [patch 0/3] Update to use shell source directly Dandan Bi
2019-04-10 5:33 ` [edk2-platforms/devel-MinPlatform] [patch 1/3] ClevoOpenBoardPkg/N1xxWU: Use " Dandan Bi
@ 2019-04-10 5:33 ` Dandan Bi
2019-04-10 12:40 ` [edk2-devel] " Chiu, Chasel
2019-04-10 5:33 ` [edk2-platforms/devel-MinPlatform] [patch 3/3] PurleyOpenBoardPkg/BoardMtOlympus: " Dandan Bi
` (3 subsequent siblings)
5 siblings, 1 reply; 9+ messages in thread
From: Dandan Bi @ 2019-04-10 5:33 UTC (permalink / raw)
To: devel; +Cc: Chasel Chiu, Michael Kubacki
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1675
In long term we will remove ShellBinPkg, so now update
platform to use ShellPkg directly.
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Michael Kubacki <michael.a.kubacki@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
.../KabylakeRvp3/OpenBoardPkg.dsc | 22 ++++++++++++++++++-
.../KabylakeRvp3/OpenBoardPkg.fdf | 2 +-
2 files changed, 22 insertions(+), 2 deletions(-)
diff --git a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
index d1fb795f15..8602052666 100644
--- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
+++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
@@ -261,11 +261,31 @@
MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf
MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf
MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf
MdeModulePkg/Universal/Console/GraphicsOutputDxe/GraphicsOutputDxe.inf
- ShellBinPkg/UefiShell/UefiShell.inf
+ #
+ # Shell
+ #
+ ShellPkg/Application/Shell/Shell.inf {
+ <PcdsFixedAtBuild>
+ gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE
+ <LibraryClasses>
+ NULL|ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLib.inf
+ NULL|ShellPkg/Library/UefiShellLevel1CommandsLib/UefiShellLevel1CommandsLib.inf
+ NULL|ShellPkg/Library/UefiShellLevel3CommandsLib/UefiShellLevel3CommandsLib.inf
+ NULL|ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1CommandsLib.inf
+ NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf
+ NULL|ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf
+ NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
+ NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.inf
+ ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
+ HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
+ BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
+ ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
+ ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
+ }
#
# Silicon
#
!include $(PLATFORM_SI_PACKAGE)/SiPkgDxe.dsc
diff --git a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf
index dc2a5d7e12..8e8abab0dc 100644
--- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf
+++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf
@@ -333,11 +333,11 @@ INF MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf
INF MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf
INF MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf
INF MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf
INF MdeModulePkg/Universal/Console/GraphicsOutputDxe/GraphicsOutputDxe.inf
-INF ShellBinPkg/UefiShell/UefiShell.inf
+INF ShellPkg/Application/Shell/Shell.inf
INF $(PLATFORM_PACKAGE)/PlatformInit/PlatformInitDxe/PlatformInitDxe.inf
INF IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.inf
INF $(PLATFORM_PACKAGE)/Test/TestPointStubDxe/TestPointStubDxe.inf
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [edk2-devel] [edk2-platforms/devel-MinPlatform] [patch 2/3] KabylakeOpenBoardPkg/KBLRvp3: Use shell source directly
2019-04-10 5:33 ` [edk2-platforms/devel-MinPlatform] [patch 2/3] KabylakeOpenBoardPkg/KBLRvp3: " Dandan Bi
@ 2019-04-10 12:40 ` Chiu, Chasel
0 siblings, 0 replies; 9+ messages in thread
From: Chiu, Chasel @ 2019-04-10 12:40 UTC (permalink / raw)
To: devel@edk2.groups.io, Bi, Dandan; +Cc: Kubacki, Michael A
Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Dandan Bi
> Sent: Wednesday, April 10, 2019 1:33 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Kubacki, Michael A
> <michael.a.kubacki@intel.com>
> Subject: [edk2-devel] [edk2-platforms/devel-MinPlatform] [patch 2/3]
> KabylakeOpenBoardPkg/KBLRvp3: Use shell source directly
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1675
>
> In long term we will remove ShellBinPkg, so now update platform to use ShellPkg
> directly.
>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Michael Kubacki <michael.a.kubacki@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
> .../KabylakeRvp3/OpenBoardPkg.dsc | 22 ++++++++++++++++++-
> .../KabylakeRvp3/OpenBoardPkg.fdf | 2 +-
> 2 files changed, 22 insertions(+), 2 deletions(-)
>
> diff --git
> a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
> index d1fb795f15..8602052666 100644
> --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
> +++
> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
> @@ -261,11 +261,31 @@
> MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf
> MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf
> MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf
>
> MdeModulePkg/Universal/Console/GraphicsOutputDxe/GraphicsOutputDxe.i
> nf
>
> - ShellBinPkg/UefiShell/UefiShell.inf
> + #
> + # Shell
> + #
> + ShellPkg/Application/Shell/Shell.inf {
> + <PcdsFixedAtBuild>
> + gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE
> + <LibraryClasses>
> +
> NULL|ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2Comman
> dsLib.inf
> +
> NULL|ShellPkg/Library/UefiShellLevel1CommandsLib/UefiShellLevel1Comman
> dsLib.inf
> +
> NULL|ShellPkg/Library/UefiShellLevel3CommandsLib/UefiShellLevel3Comman
> dsLib.inf
> +
> NULL|ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1Comm
> andsLib.inf
> +
> NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1Comma
> ndsLib.inf
> +
> NULL|ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comm
> andsLib.inf
> +
> NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1C
> ommandsLib.inf
> +
> NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2C
> ommandsLib.inf
> +
> ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellCommand
> Lib.inf
> +
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLi
> b.inf
> +
> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCo
> mmandLib.inf
> +
> ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
> + ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
> + }
>
> #
> # Silicon
> #
> !include $(PLATFORM_SI_PACKAGE)/SiPkgDxe.dsc
> diff --git
> a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf
> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf
> index dc2a5d7e12..8e8abab0dc 100644
> --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf
> +++
> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf
> @@ -333,11 +333,11 @@ INF
> MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf
> INF MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf
> INF MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf
> INF MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf
> INF
> MdeModulePkg/Universal/Console/GraphicsOutputDxe/GraphicsOutputDxe.i
> nf
>
> -INF ShellBinPkg/UefiShell/UefiShell.inf
> +INF ShellPkg/Application/Shell/Shell.inf
>
> INF
> $(PLATFORM_PACKAGE)/PlatformInit/PlatformInitDxe/PlatformInitDxe.inf
> INF IntelFsp2WrapperPkg/FspWrapperNotifyDxe/FspWrapperNotifyDxe.inf
>
> INF $(PLATFORM_PACKAGE)/Test/TestPointStubDxe/TestPointStubDxe.inf
> --
> 2.18.0.windows.1
>
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [edk2-platforms/devel-MinPlatform] [patch 3/3] PurleyOpenBoardPkg/BoardMtOlympus: Use shell source directly
2019-04-10 5:32 [edk2-platforms/devel-MinPlatform] [patch 0/3] Update to use shell source directly Dandan Bi
2019-04-10 5:33 ` [edk2-platforms/devel-MinPlatform] [patch 1/3] ClevoOpenBoardPkg/N1xxWU: Use " Dandan Bi
2019-04-10 5:33 ` [edk2-platforms/devel-MinPlatform] [patch 2/3] KabylakeOpenBoardPkg/KBLRvp3: " Dandan Bi
@ 2019-04-10 5:33 ` Dandan Bi
2019-04-10 5:56 ` Zhou, Bowen
2019-04-10 17:15 ` [edk2-platforms/devel-MinPlatform] [patch 0/3] Update to use " Kubacki, Michael A
` (2 subsequent siblings)
5 siblings, 1 reply; 9+ messages in thread
From: Dandan Bi @ 2019-04-10 5:33 UTC (permalink / raw)
To: devel; +Cc: Shifei A Lu, Xiaohu Zhou, Isaac W Oram
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1675
In long term we will remove ShellBinPkg, so now update
platform to use ShellPkg directly.
Cc: Shifei A Lu <shifei.a.lu@intel.com>
Cc: Xiaohu Zhou <bowen.zhou@intel.com>
Cc: Isaac W Oram <isaac.w.oram@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
.../BoardMtOlympus/PlatformPkg.dsc | 22 ++++++++++++++++++-
.../BoardMtOlympus/PlatformPkg.fdf | 2 +-
2 files changed, 22 insertions(+), 2 deletions(-)
diff --git a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkg.dsc b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkg.dsc
index 384e70a832..aa8bde5460 100644
--- a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkg.dsc
+++ b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkg.dsc
@@ -225,11 +225,31 @@
AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicDxe.inf
!endif
PurleyOpenBoardPkg/Policy/S3NvramSave/S3NvramSave.inf
- ShellBinPkg/UefiShell/UefiShell.inf
+ #
+ # Shell
+ #
+ ShellPkg/Application/Shell/Shell.inf {
+ <PcdsFixedAtBuild>
+ gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE
+ <LibraryClasses>
+ NULL|ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLib.inf
+ NULL|ShellPkg/Library/UefiShellLevel1CommandsLib/UefiShellLevel1CommandsLib.inf
+ NULL|ShellPkg/Library/UefiShellLevel3CommandsLib/UefiShellLevel3CommandsLib.inf
+ NULL|ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1CommandsLib.inf
+ NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf
+ NULL|ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf
+ NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
+ NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.inf
+ ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
+ HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
+ BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
+ ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
+ ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
+ }
MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf
PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf
diff --git a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkg.fdf b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkg.fdf
index 610aa18d49..0100f88aa3 100644
--- a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkg.fdf
+++ b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkg.fdf
@@ -297,11 +297,11 @@ INF $(BOARD_PKG)/Policy/IioUdsDataDxe/IioUdsDataDxe.inf
INF $(BOARD_PKG)/Policy/PlatformCpuPolicy/PlatformCpuPolicy.inf
INF $(BOARD_PKG)/Pci/PciPlatform/PciPlatform.inf
INF MinPlatformPkg/PlatformInit/PlatformInitDxe/PlatformInitDxe.inf
-INF ShellBinPkg/UefiShell/UefiShell.inf
+INF ShellPkg/Application/Shell/Shell.inf
INF PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf
INF MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [edk2-platforms/devel-MinPlatform] [patch 3/3] PurleyOpenBoardPkg/BoardMtOlympus: Use shell source directly
2019-04-10 5:33 ` [edk2-platforms/devel-MinPlatform] [patch 3/3] PurleyOpenBoardPkg/BoardMtOlympus: " Dandan Bi
@ 2019-04-10 5:56 ` Zhou, Bowen
0 siblings, 0 replies; 9+ messages in thread
From: Zhou, Bowen @ 2019-04-10 5:56 UTC (permalink / raw)
To: Bi, Dandan, devel@edk2.groups.io; +Cc: Lu, Shifei A, Oram, Isaac W
Reviewed-by: Xiaohu Zhou <bowen.zhou@intel.com>
-----Original Message-----
From: Bi, Dandan
Sent: Wednesday, April 10, 2019 1:33 PM
To: devel@edk2.groups.io
Cc: Lu, Shifei A <shifei.a.lu@intel.com>; Zhou, Bowen <bowen.zhou@intel.com>; Oram, Isaac W <isaac.w.oram@intel.com>
Subject: [edk2-platforms/devel-MinPlatform] [patch 3/3] PurleyOpenBoardPkg/BoardMtOlympus: Use shell source directly
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1675
In long term we will remove ShellBinPkg, so now update platform to use ShellPkg directly.
Cc: Shifei A Lu <shifei.a.lu@intel.com>
Cc: Xiaohu Zhou <bowen.zhou@intel.com>
Cc: Isaac W Oram <isaac.w.oram@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
.../BoardMtOlympus/PlatformPkg.dsc | 22 ++++++++++++++++++-
.../BoardMtOlympus/PlatformPkg.fdf | 2 +-
2 files changed, 22 insertions(+), 2 deletions(-)
diff --git a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkg.dsc b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkg.dsc
index 384e70a832..aa8bde5460 100644
--- a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkg.dsc
+++ b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkg.dsc
@@ -225,11 +225,31 @@
AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicDxe.inf
!endif
PurleyOpenBoardPkg/Policy/S3NvramSave/S3NvramSave.inf
- ShellBinPkg/UefiShell/UefiShell.inf
+ #
+ # Shell
+ #
+ ShellPkg/Application/Shell/Shell.inf {
+ <PcdsFixedAtBuild>
+ gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE
+ <LibraryClasses>
+ NULL|ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLib.inf
+ NULL|ShellPkg/Library/UefiShellLevel1CommandsLib/UefiShellLevel1CommandsLib.inf
+ NULL|ShellPkg/Library/UefiShellLevel3CommandsLib/UefiShellLevel3CommandsLib.inf
+ NULL|ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1CommandsLib.inf
+ NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf
+ NULL|ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf
+ NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
+ NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.inf
+ ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
+ HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
+ BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
+ ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
+ ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
+ }
MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf
PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf
diff --git a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkg.fdf b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkg.fdf
index 610aa18d49..0100f88aa3 100644
--- a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkg.fdf
+++ b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkg.fdf
@@ -297,11 +297,11 @@ INF $(BOARD_PKG)/Policy/IioUdsDataDxe/IioUdsDataDxe.inf
INF $(BOARD_PKG)/Policy/PlatformCpuPolicy/PlatformCpuPolicy.inf
INF $(BOARD_PKG)/Pci/PciPlatform/PciPlatform.inf
INF MinPlatformPkg/PlatformInit/PlatformInitDxe/PlatformInitDxe.inf
-INF ShellBinPkg/UefiShell/UefiShell.inf
+INF ShellPkg/Application/Shell/Shell.inf
INF PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf
INF MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [edk2-platforms/devel-MinPlatform] [patch 0/3] Update to use shell source directly
2019-04-10 5:32 [edk2-platforms/devel-MinPlatform] [patch 0/3] Update to use shell source directly Dandan Bi
` (2 preceding siblings ...)
2019-04-10 5:33 ` [edk2-platforms/devel-MinPlatform] [patch 3/3] PurleyOpenBoardPkg/BoardMtOlympus: " Dandan Bi
@ 2019-04-10 17:15 ` Kubacki, Michael A
2019-04-10 20:38 ` Nate DeSimone
2019-04-10 20:44 ` Sinha, Ankit
5 siblings, 0 replies; 9+ messages in thread
From: Kubacki, Michael A @ 2019-04-10 17:15 UTC (permalink / raw)
To: Bi, Dandan, devel@edk2.groups.io
Cc: Sinha, Ankit, Desimone, Nathaniel L, Chiu, Chasel, Lu, Shifei A,
Zhou, Bowen, Oram, Isaac W
Reviewed-by: Michael Kubacki <michael.a.kubacki@intel.com>
> -----Original Message-----
> From: Bi, Dandan
> Sent: Tuesday, April 9, 2019 10:33 PM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A <michael.a.kubacki@intel.com>; Sinha, Ankit
> <ankit.sinha@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>;
> Lu, Shifei A <shifei.a.lu@intel.com>; Zhou, Bowen
> <bowen.zhou@intel.com>; Oram, Isaac W <isaac.w.oram@intel.com>
> Subject: [edk2-platforms/devel-MinPlatform] [patch 0/3] Update to use shell
> source directly
>
> The series will update ClevoOpenBoardPkg KabylakeOpenBoardPkg and
> PurleyOpenBoardPkg to use ShellPkg directly.
>
> Test done for the series:
> Build pass for ClevoOpenBoardPkg KabylakeOpenBoardPkg and
> PurleyOpenBoardPkg.
> Boot to shell with KBLRvp3.
>
> Cc: Michael Kubacki <michael.a.kubacki@intel.com>
> Cc: Ankit Sinha <ankit.sinha@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Shifei A Lu <shifei.a.lu@intel.com>
> Cc: Xiaohu Zhou <bowen.zhou@intel.com>
> Cc: Isaac W Oram <isaac.w.oram@intel.com>
>
> Dandan Bi (3):
> ClevoOpenBoardPkg/N1xxWU: Use shell source directly
> KabylakeOpenBoardPkg/KBLRvp3: Use shell source directly
> PurleyOpenBoardPkg/BoardMtOlympus: Use shell source directly
>
> .../ClevoOpenBoardPkg/N1xxWU/OpenBoardPkg.dsc | 22
> ++++++++++++++++++- .../ClevoOpenBoardPkg/N1xxWU/OpenBoardPkg.fdf
> | 2 +-
> .../KabylakeRvp3/OpenBoardPkg.dsc | 22 ++++++++++++++++++-
> .../KabylakeRvp3/OpenBoardPkg.fdf | 2 +-
> .../BoardMtOlympus/PlatformPkg.dsc | 22 ++++++++++++++++++-
> .../BoardMtOlympus/PlatformPkg.fdf | 2 +-
> 6 files changed, 66 insertions(+), 6 deletions(-)
>
> --
> 2.18.0.windows.1
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [edk2-platforms/devel-MinPlatform] [patch 0/3] Update to use shell source directly
2019-04-10 5:32 [edk2-platforms/devel-MinPlatform] [patch 0/3] Update to use shell source directly Dandan Bi
` (3 preceding siblings ...)
2019-04-10 17:15 ` [edk2-platforms/devel-MinPlatform] [patch 0/3] Update to use " Kubacki, Michael A
@ 2019-04-10 20:38 ` Nate DeSimone
2019-04-10 20:44 ` Sinha, Ankit
5 siblings, 0 replies; 9+ messages in thread
From: Nate DeSimone @ 2019-04-10 20:38 UTC (permalink / raw)
To: Bi, Dandan, devel@edk2.groups.io
Cc: Kubacki, Michael A, Sinha, Ankit, Chiu, Chasel, Lu, Shifei A,
Zhou, Bowen, Oram, Isaac W
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
-----Original Message-----
From: Bi, Dandan
Sent: Tuesday, April 9, 2019 10:33 PM
To: devel@edk2.groups.io
Cc: Kubacki, Michael A <michael.a.kubacki@intel.com>; Sinha, Ankit <ankit.sinha@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>; Lu, Shifei A <shifei.a.lu@intel.com>; Zhou, Bowen <bowen.zhou@intel.com>; Oram, Isaac W <isaac.w.oram@intel.com>
Subject: [edk2-platforms/devel-MinPlatform] [patch 0/3] Update to use shell source directly
The series will update ClevoOpenBoardPkg KabylakeOpenBoardPkg and PurleyOpenBoardPkg to use ShellPkg directly.
Test done for the series:
Build pass for ClevoOpenBoardPkg KabylakeOpenBoardPkg and PurleyOpenBoardPkg.
Boot to shell with KBLRvp3.
Cc: Michael Kubacki <michael.a.kubacki@intel.com>
Cc: Ankit Sinha <ankit.sinha@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Shifei A Lu <shifei.a.lu@intel.com>
Cc: Xiaohu Zhou <bowen.zhou@intel.com>
Cc: Isaac W Oram <isaac.w.oram@intel.com>
Dandan Bi (3):
ClevoOpenBoardPkg/N1xxWU: Use shell source directly
KabylakeOpenBoardPkg/KBLRvp3: Use shell source directly
PurleyOpenBoardPkg/BoardMtOlympus: Use shell source directly
.../ClevoOpenBoardPkg/N1xxWU/OpenBoardPkg.dsc | 22 ++++++++++++++++++- .../ClevoOpenBoardPkg/N1xxWU/OpenBoardPkg.fdf | 2 +-
.../KabylakeRvp3/OpenBoardPkg.dsc | 22 ++++++++++++++++++-
.../KabylakeRvp3/OpenBoardPkg.fdf | 2 +-
.../BoardMtOlympus/PlatformPkg.dsc | 22 ++++++++++++++++++-
.../BoardMtOlympus/PlatformPkg.fdf | 2 +-
6 files changed, 66 insertions(+), 6 deletions(-)
--
2.18.0.windows.1
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [edk2-platforms/devel-MinPlatform] [patch 0/3] Update to use shell source directly
2019-04-10 5:32 [edk2-platforms/devel-MinPlatform] [patch 0/3] Update to use shell source directly Dandan Bi
` (4 preceding siblings ...)
2019-04-10 20:38 ` Nate DeSimone
@ 2019-04-10 20:44 ` Sinha, Ankit
5 siblings, 0 replies; 9+ messages in thread
From: Sinha, Ankit @ 2019-04-10 20:44 UTC (permalink / raw)
To: Bi, Dandan, devel@edk2.groups.io
Cc: Kubacki, Michael A, Desimone, Nathaniel L, Chiu, Chasel,
Lu, Shifei A, Zhou, Bowen, Oram, Isaac W
Reviewed-by: Ankit Sinha <ankit.sinha@intel.com>
-----Original Message-----
From: Bi, Dandan
Sent: Tuesday, April 9, 2019 10:33 PM
To: devel@edk2.groups.io
Cc: Kubacki, Michael A <michael.a.kubacki@intel.com>; Sinha, Ankit <ankit.sinha@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>; Lu, Shifei A <shifei.a.lu@intel.com>; Zhou, Bowen <bowen.zhou@intel.com>; Oram, Isaac W <isaac.w.oram@intel.com>
Subject: [edk2-platforms/devel-MinPlatform] [patch 0/3] Update to use shell source directly
The series will update ClevoOpenBoardPkg KabylakeOpenBoardPkg and PurleyOpenBoardPkg to use ShellPkg directly.
Test done for the series:
Build pass for ClevoOpenBoardPkg KabylakeOpenBoardPkg and PurleyOpenBoardPkg.
Boot to shell with KBLRvp3.
Cc: Michael Kubacki <michael.a.kubacki@intel.com>
Cc: Ankit Sinha <ankit.sinha@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Shifei A Lu <shifei.a.lu@intel.com>
Cc: Xiaohu Zhou <bowen.zhou@intel.com>
Cc: Isaac W Oram <isaac.w.oram@intel.com>
Dandan Bi (3):
ClevoOpenBoardPkg/N1xxWU: Use shell source directly
KabylakeOpenBoardPkg/KBLRvp3: Use shell source directly
PurleyOpenBoardPkg/BoardMtOlympus: Use shell source directly
.../ClevoOpenBoardPkg/N1xxWU/OpenBoardPkg.dsc | 22 ++++++++++++++++++- .../ClevoOpenBoardPkg/N1xxWU/OpenBoardPkg.fdf | 2 +-
.../KabylakeRvp3/OpenBoardPkg.dsc | 22 ++++++++++++++++++-
.../KabylakeRvp3/OpenBoardPkg.fdf | 2 +-
.../BoardMtOlympus/PlatformPkg.dsc | 22 ++++++++++++++++++-
.../BoardMtOlympus/PlatformPkg.fdf | 2 +-
6 files changed, 66 insertions(+), 6 deletions(-)
--
2.18.0.windows.1
^ permalink raw reply [flat|nested] 9+ messages in thread