From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.107.94.47]) by mx.groups.io with SMTP id smtpd.web10.65806.1597756218469077612 for ; Tue, 18 Aug 2020 06:10:18 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@amdcloud.onmicrosoft.com header.s=selector2-amdcloud-onmicrosoft-com header.b=xu17U1qz; spf=none, err=SPF record not found (domain: amd.com, ip: 40.107.94.47, mailfrom: thomas.lendacky@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ObgAsL0S26U4fLV3bHTCPJOtuHQl/n+TCR9ISj33eVhim7A701P5GfujDDl4QnLSbSRS7LXaNNSzKLx2wUVivkwIDhjZJwkmCvy6rl+Tzc/QDmx45MzvhvMHDsO+AAZ6uVyI1lho+b/Kc0eReR0mJ7XuAK3LueMcWewMwfEJkK5z4kQcMs1MqZ6WwqGiOWjeiFiOsQG7HteXIbITdY0gL0SYZdG6XP9g1uT/bRQ17/4JO3enkZJHjA/e3mYx6rNpFbgu1o7RJ48xXXeM6iwmbtgOl7cVAI3TlRLQNwDu97plNtnDZEEucUFfOKUUMryhH826F60hol41+BeAAhcwfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BIzwr1ITovo92puDeHh0AmADDHy9uuwRMSnGbXoXOAA=; b=W+zOiHm/ZOGB4yNLnnwb5Kvg2+nlV+PBXkNSOzculmPAC3c0CsrPeKTxGuxSq8jAhQqz4NLG5eDUxa99e+WquEN2Gh+hkeVMxMI+x/VzVq5XaknmSo/qIZIq1BGTJvwgHRtzK0Y4QXXuN16KwDogXxIPIyHKifSa5tGPVJTZguidnK4F+iU1I0H8wkq7QMf+Q7KMsUu3rSkxmvgLsry2no4krLmurxb7Jfc6+gCKiHv77gta8pZT9GRjt5dYXpHmBj3O41Y1aieRjcaOzyRNrkTTLItLk35cNIzRbWp73bDU1YMG8IJBWQ/UKSBmXvL+oaO/bzobqcPLk3Q82QCLjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BIzwr1ITovo92puDeHh0AmADDHy9uuwRMSnGbXoXOAA=; b=xu17U1qz2vgL92tFCS/+5LZcKdPwy2ULa7Jq1MQ22DMK26BVnw/0sFz7n6NHvrQvZ+JKKEYzeeakJkpdR2Puv8UXteaHwhNF2UYkMItMtDfJi1cIsQ2Hj1Mk3WrAOl+EdHEEm5hrRsD1g/WoKszNuA+7YhN5FtBBQ8FjvRihFew= Authentication-Results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=amd.com; Received: from DM5PR12MB1355.namprd12.prod.outlook.com (2603:10b6:3:6e::7) by DM6PR12MB3082.namprd12.prod.outlook.com (2603:10b6:5:11b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3305.24; Tue, 18 Aug 2020 13:10:17 +0000 Received: from DM5PR12MB1355.namprd12.prod.outlook.com ([fe80::299a:8ed2:23fc:6346]) by DM5PR12MB1355.namprd12.prod.outlook.com ([fe80::299a:8ed2:23fc:6346%3]) with mapi id 15.20.3283.027; Tue, 18 Aug 2020 13:10:17 +0000 From: "Lendacky, Thomas" To: devel@edk2.groups.io CC: Liming Gao , Eric Dong , Ray Ni , Laszlo Ersek , Rahul Kumar Subject: [PATCH 1/1] UefiCpuPkg/MpInitLib: Always initialize the DoDecrement variable Date: Tue, 18 Aug 2020 08:10:07 -0500 Message-ID: <477f5449c898cd96240729105dde26b1fd75baa9.1597756206.git.thomas.lendacky@amd.com> X-Mailer: git-send-email 2.28.0 X-ClientProxiedBy: SN4PR0801CA0002.namprd08.prod.outlook.com (2603:10b6:803:29::12) To DM5PR12MB1355.namprd12.prod.outlook.com (2603:10b6:3:6e::7) Return-Path: thomas.lendacky@amd.com MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from tlendack-t1.amd.com (165.204.77.1) by SN4PR0801CA0002.namprd08.prod.outlook.com (2603:10b6:803:29::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3283.22 via Frontend Transport; Tue, 18 Aug 2020 13:10:16 +0000 X-Mailer: git-send-email 2.28.0 X-Originating-IP: [165.204.77.1] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: f828d225-9e14-4191-c0bf-08d843780d23 X-MS-TrafficTypeDiagnostic: DM6PR12MB3082: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4303; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Zad7yoMqYExV0aeyZMLzZ1R+5lUxqs8uynXf5eh2omLH6rX3gYDqV6VZIEe2cZ7lf7EwwtxdPuPkYl70MYW4vxFMFzWB8PMBUMXLX5UjthIEpInx8M/FRgJTqXUK6XCFw2aaxnqCotm9VZroNGzXVEAyIPzjRblmDB6M0nQW5fsqEG5MvISbe+l3MNJYjEdb618F7arFirDpeQG3VVOCDRVCvjVeNUoXwcAzR3Z0J2a395s3RlMj8m6i6b6XNVgH5AqpY6dIZ5ADhg2jOOImOEfwR83dtqg1s/8K5TcWFL0oAWEPNBmsYJbdC91JfipzJ4INxDMKraMwS8j8oZ+ytrRgA6GQwWJW4tAaEj9CIPrV/VB75wbvMue/HaHYc5TYyIUIxttlby5vktI0iXoP0eQixqw5ODJIRRk2gryfb4o3IawOBDd3hZsPYyGJi4vIAllhorfeq0ze5N5NzGkAog== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR12MB1355.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(4636009)(366004)(396003)(39860400002)(136003)(376002)(346002)(52116002)(54906003)(7696005)(4326008)(6916009)(6486002)(86362001)(66946007)(5660300002)(316002)(66556008)(66476007)(26005)(36756003)(6666004)(8936002)(956004)(83380400001)(966005)(8676002)(478600001)(186003)(2906002)(2616005)(16526019)(136400200001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: sSVdBldK/F1YU3Mn1jbtaYhhBc+oFSTOGP7gmUdVbTLnO+UNpyTK3q35ocomJwC3rVPh7Ix8Q4OVr58CLb+6AX4pXMNB5tU6N0J2wtOSeXKeSPaD+wOkJ8CxpxQALaBb1PviK3oGQ3jhMTSCJXSO9QFSvlBN0IKkH2QJmVFndtyjszMez+4Dzyk5VIjFa4+7QqYiPLN+k5B+7SMLLTMT3nayKIdbXuMAqwtsHaBPTrl2cPfGhwKxdYYFOUXpxx57NNnZY5Z3rEerGyRECRB5l4HtT4Ih1XDLfPTGWoVmXgbwpy2p28aYETDzvNvdMHoMCWsbM/MPu4Rvg8NmB8VMyGxDZFxGhoAQOKeaY8znv6HMU8tcVNerfWiwt5uCENCky9g5yV5jO86PktnHZxRdajxpoJmgSlHWBWdGLv4kieFiFWSYv/+lLuC/YV/d1aKtua00K6o1Sqfs11Dxq0SrC6V9vVNJrdxNanASPbL36bWR00otEwF3yaT+BJlTbJVmVKAZjfI/S6QMxGwZ6cc1sR3qzuRcXS8HhLNgTnJGmnNQrwWBsTWY4UnQ0Lyr1q1FtOAua4EceDFHsSJAG+6qYS4B+VjVgfUPA68GukQG7Dbr469X3QucGxlDq1MkJ6PQyzlY2BxV5fcEHkQaLK+1lg== X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: f828d225-9e14-4191-c0bf-08d843780d23 X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB1355.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Aug 2020 13:10:17.0767 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: V8yHASv0tXYLWis6QjKc1OT6nBAgRNezHcdvz9N+XCSJgZgleG/YUsZFGmed5fl4iouLIwVy+4wQDo2r1qdUSw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3082 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable From: Tom Lendacky REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2901 The DoDecrement variable in ApWakeupFunction () wasn't always being initialized. Update the code to always fully initialize it. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Cc: Rahul Kumar Signed-off-by: Tom Lendacky --- UefiCpuPkg/Library/MpInitLib/MpLib.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.c b/UefiCpuPkg/Library/MpIn= itLib/MpLib.c index 90416c81b616..e24bdc64f930 100644 --- a/UefiCpuPkg/Library/MpInitLib/MpLib.c +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.c @@ -885,9 +885,7 @@ ApWakeupFunction ( UINT64 Status; BOOLEAN DoDecrement; =20 - if (CpuMpData->InitFlag =3D=3D ApInitConfig) { - DoDecrement =3D TRUE; - } + DoDecrement =3D (CpuMpData->InitFlag =3D=3D ApInitConfig) ? TRUE= : FALSE; =20 while (TRUE) { Msr.GhcbPhysicalAddress =3D AsmReadMsr64 (MSR_SEV_ES_GHCB); --=20 2.28.0