public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "maobibo" <bibo_mao@163.com>
To: devel@edk2.groups.io, kraxel@redhat.com
Subject: Re: [edk2-devel] one possible issue with ovmf fvb
Date: Fri, 26 Nov 2021 10:37:44 +0800	[thread overview]
Message-ID: <477f7ae6-37af-8a9f-ac4b-273eaa03f138@163.com> (raw)
In-Reply-To: <20211125103810.qtydjqvysuvak5c4@sirius.home.kraxel.org>



On 11/25/2021 06:38 PM, Gerd Hoffmann wrote:
>   Hi,
> 
>>   PcdStatus = PcdSet64S (PcdFlashNvStorageVariableBase64, (UINT32)(UINTN) Ptr);
>>   ASSERT_RETURN_ERROR (PcdStatus);
> 
> I guess you are referring to that UINT32 cast?
> Not sure why it is there.  I think you can just drop it.
Yes, it is. There will be problem if the loongarch bios uses ovmf fvb dxe and
there is only one flat memory hob. UEFI bios memory may be allocated with 64bit
address, so there will be problem.

I will submit one patch to fix this in order to use these common code.

regards
bibo, mao

> 
>> Can uefi bios manage memory beyond 4G?
> 
> The X64 builds can do that just fine, although they usually store
> everything below 4G, so issues like the one above go unnoticed.
> 
> HTH,
>   Gerd
> 
> 
> 
> 
> 


  reply	other threads:[~2021-11-26  2:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-25  9:43 one possible issue with ovmf fvb maobibo
2021-11-25 10:38 ` Gerd Hoffmann
2021-11-26  2:37   ` maobibo [this message]
2021-11-27 19:45 ` [edk2-devel] " Andrew Fish
2021-11-29  9:50   ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=477f7ae6-37af-8a9f-ac4b-273eaa03f138@163.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox