public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Feng, YunhuaX" <yunhuax.feng@intel.com>
To: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Zhu, Yonghong" <yonghong.zhu@intel.com>,
	"Gao, Liming" <liming.gao@intel.com>
Subject: [PATCH] BaseTools: Fix VOID* type bug
Date: Fri, 9 Feb 2018 04:31:10 +0000	[thread overview]
Message-ID: <47C64442C08CCD4089DC43B6B5E46BC482AB5E@shsmsx102.ccr.corp.intel.com> (raw)

Code miss UINT32 and UINT64 value type setting in
VOID*, like as {UINT32({TRUE})}

Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yunhua Feng <yunhuax.feng@intel.com>
---
 BaseTools/Source/Python/Common/Expression.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/BaseTools/Source/Python/Common/Expression.py b/BaseTools/Source/Python/Common/Expression.py
index 6a1103df2c..13212b32a9 100644
--- a/BaseTools/Source/Python/Common/Expression.py
+++ b/BaseTools/Source/Python/Common/Expression.py
@@ -874,12 +874,14 @@ class ValueExpressionEx(ValueExpression):
                                 elif Item.startswith('UINT16'):
                                     ItemSize = 2
                                     ValueType = "UINT16"
                                 elif Item.startswith('UINT32'):
                                     ItemSize = 4
+                                    ValueType = "UINT32"
                                 elif Item.startswith('UINT64'):
                                     ItemSize = 8
+                                    ValueType = "UINT64"
                                 else:
                                     ItemSize = 0
                                 if ValueType:
                                     TmpValue = ValueExpressionEx(Item, ValueType, self._Symb)(True)
                                 else:
-- 
2.12.2.windows.2



             reply	other threads:[~2018-02-09  4:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-09  4:31 Feng, YunhuaX [this message]
2018-02-10 11:54 ` [PATCH] BaseTools: Fix VOID* type bug Zhu, Yonghong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47C64442C08CCD4089DC43B6B5E46BC482AB5E@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox