public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Feng, YunhuaX" <yunhuax.feng@intel.com>
To: "Carsey, Jaben" <jaben.carsey@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Zhu, Yonghong" <yonghong.zhu@intel.com>,
	"Gao, Liming" <liming.gao@intel.com>
Subject: Re: [PATCH] BaseTools: Fix regression issue by b23414f6540d
Date: Tue, 21 Aug 2018 00:45:29 +0000	[thread overview]
Message-ID: <47C64442C08CCD4089DC43B6B5E46BC48BAD21@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <CB6E33457884FA40993F35157061515CA4120849@FMSMSX103.amr.corp.intel.com>

OK, I will update the patch renaming function DepexExpressionTokenList to DepexExpressionDict instead of changing the callers.

Any question, please let me know. Thanks.

Best Regards
Feng, Yunhua


-----Original Message-----
From: Carsey, Jaben 
Sent: Tuesday, August 21, 2018 4:43 AM
To: Feng, YunhuaX <yunhuax.feng@intel.com>; edk2-devel@lists.01.org
Cc: Zhu, Yonghong <yonghong.zhu@intel.com>; Gao, Liming <liming.gao@intel.com>
Subject: RE: [PATCH] BaseTools: Fix regression issue by b23414f6540d

I think that the error may be the renaming of the original function in my patch that caused this.  Should that function be renamed to DepexExpressionDict instead of changing the callers?  I was not intending to change the external API of the class.

-Jaben

> -----Original Message-----
> From: Feng, YunhuaX
> Sent: Monday, August 20, 2018 1:04 AM
> To: edk2-devel@lists.01.org
> Cc: Zhu, Yonghong <yonghong.zhu@intel.com>; Gao, Liming 
> <liming.gao@intel.com>; Carsey, Jaben <jaben.carsey@intel.com>
> Subject: [PATCH] BaseTools: Fix regression issue by b23414f6540d
> 
> Fix regression issue by b23414f6540d4f336b6f00b44681911d469f9a04
> AttributeError: 'ModuleAutoGen' object has no attribute 
> 'DepexExpressionDict'
> 
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Yonghong Zhu <yonghong.zhu@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Yunhua Feng <yunhuax.feng@intel.com>
> ---
>  BaseTools/Source/Python/build/BuildReport.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/BaseTools/Source/Python/build/BuildReport.py
> b/BaseTools/Source/Python/build/BuildReport.py
> index deb88a7817..63c040ec07 100644
> --- a/BaseTools/Source/Python/build/BuildReport.py
> +++ b/BaseTools/Source/Python/build/BuildReport.py
> @@ -423,11 +423,11 @@ class DepexReport(object):
>                  if Match:
>                      self.Depex = Match.group(1).strip()
>                      self.Source = "DXS"
>                      break
>          else:
> -            self.Depex = M.DepexExpressionDict.get(M.ModuleType, "")
> +            self.Depex = M.DepexExpressionTokenList.get(M.ModuleType, 
> + "")
>              self.ModuleDepex = " 
> ".join(M.Module.DepexExpression[M.Arch,
> M.ModuleType])
>              if not self.ModuleDepex:
>                  self.ModuleDepex = "(None)"
> 
>              LibDepexList = []
> --
> 2.12.2.windows.2



      reply	other threads:[~2018-08-21  0:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-20  8:04 [PATCH] BaseTools: Fix regression issue by b23414f6540d Feng, YunhuaX
2018-08-20 20:43 ` Carsey, Jaben
2018-08-21  0:45   ` Feng, YunhuaX [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47C64442C08CCD4089DC43B6B5E46BC48BAD21@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox