From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=yunhuax.feng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 045AA210E38CB for ; Mon, 20 Aug 2018 17:45:33 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Aug 2018 17:45:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,267,1531810800"; d="scan'208";a="63920028" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga007.fm.intel.com with ESMTP; 20 Aug 2018 17:45:32 -0700 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 20 Aug 2018 17:45:32 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 20 Aug 2018 17:45:32 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.226]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.143]) with mapi id 14.03.0319.002; Tue, 21 Aug 2018 08:45:30 +0800 From: "Feng, YunhuaX" To: "Carsey, Jaben" , "edk2-devel@lists.01.org" CC: "Zhu, Yonghong" , "Gao, Liming" Thread-Topic: [PATCH] BaseTools: Fix regression issue by b23414f6540d Thread-Index: AdQ4XGqpQ+eudac/RN6W1OFVOs7xpwAaS9QgAAiSQmA= Date: Tue, 21 Aug 2018 00:45:29 +0000 Message-ID: <47C64442C08CCD4089DC43B6B5E46BC48BAD21@shsmsx102.ccr.corp.intel.com> References: <47C64442C08CCD4089DC43B6B5E46BC48BAC64@shsmsx102.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNmQ1ZWI2MzItMTMzNS00MGQwLTlkYWMtYWU2ZDcxMTdmMjAwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSnpXdEgzcVFNZ2YzOStMSURCYVVoV25nelZPbDVSbk96U1pkQlkwZDFRSWN0dGs2OHFmOUVhaG1TSDNzQWMyRSJ9 x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] BaseTools: Fix regression issue by b23414f6540d X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Aug 2018 00:45:34 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable OK, I will update the patch renaming function DepexExpressionTokenList to D= epexExpressionDict instead of changing the callers. Any question, please let me know. Thanks. Best Regards Feng, Yunhua -----Original Message----- From: Carsey, Jaben=20 Sent: Tuesday, August 21, 2018 4:43 AM To: Feng, YunhuaX ; edk2-devel@lists.01.org Cc: Zhu, Yonghong ; Gao, Liming Subject: RE: [PATCH] BaseTools: Fix regression issue by b23414f6540d I think that the error may be the renaming of the original function in my p= atch that caused this. Should that function be renamed to DepexExpressionD= ict instead of changing the callers? I was not intending to change the ext= ernal API of the class. -Jaben > -----Original Message----- > From: Feng, YunhuaX > Sent: Monday, August 20, 2018 1:04 AM > To: edk2-devel@lists.01.org > Cc: Zhu, Yonghong ; Gao, Liming=20 > ; Carsey, Jaben > Subject: [PATCH] BaseTools: Fix regression issue by b23414f6540d >=20 > Fix regression issue by b23414f6540d4f336b6f00b44681911d469f9a04 > AttributeError: 'ModuleAutoGen' object has no attribute=20 > 'DepexExpressionDict' >=20 > Cc: Liming Gao > Cc: Yonghong Zhu > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Yunhua Feng > --- > BaseTools/Source/Python/build/BuildReport.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/BaseTools/Source/Python/build/BuildReport.py > b/BaseTools/Source/Python/build/BuildReport.py > index deb88a7817..63c040ec07 100644 > --- a/BaseTools/Source/Python/build/BuildReport.py > +++ b/BaseTools/Source/Python/build/BuildReport.py > @@ -423,11 +423,11 @@ class DepexReport(object): > if Match: > self.Depex =3D Match.group(1).strip() > self.Source =3D "DXS" > break > else: > - self.Depex =3D M.DepexExpressionDict.get(M.ModuleType, "") > + self.Depex =3D M.DepexExpressionTokenList.get(M.ModuleType,= =20 > + "") > self.ModuleDepex =3D "=20 > ".join(M.Module.DepexExpression[M.Arch, > M.ModuleType]) > if not self.ModuleDepex: > self.ModuleDepex =3D "(None)" >=20 > LibDepexList =3D [] > -- > 2.12.2.windows.2