From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 978EB941BE7 for ; Thu, 10 Aug 2023 19:54:45 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=nvpDSHnzVKEupCiHILGOMP4iM/wthRByJ0rQoym/rGQ=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1691697284; v=1; b=Sp2R++K3EbL6Vo3tJK+6q5fbiwov3MwypNICxoE6LhCgpwtjiBliAlegBa10vyA36lNBswNd FiT8eJ9m9b4lKGlDij1Tmk3ePFWVunsj4uGaqpJKpyPFljRFFmZcNEB29FntF2NDKIowD7eXl+r Jh3Yl9+BA8t/9aaV+et2rcCU= X-Received: by 127.0.0.2 with SMTP id rWlDYY7687511xrA7kl05Bfr; Thu, 10 Aug 2023 12:54:44 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.27441.1691697283819128215 for ; Thu, 10 Aug 2023 12:54:43 -0700 X-Received: from [192.168.4.22] (unknown [47.201.241.95]) by linux.microsoft.com (Postfix) with ESMTPSA id 36BF220FD029; Thu, 10 Aug 2023 12:54:42 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 36BF220FD029 Message-ID: <47a7e3eb-2049-bbc3-3e74-0c115f00702e@linux.microsoft.com> Date: Thu, 10 Aug 2023 15:54:40 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg/Bhyve: build platform info HOB To: devel@edk2.groups.io, ardb@kernel.org, =?UTF-8?Q?Corvin_K=C3=B6hne?= , Rebecca Cran , Michael Kinney Cc: Jiewen Yao , Jordan Justen , Gerd Hoffmann , Peter Grehan References: <20230724130006.427522-1-corvink@FreeBSD.org> <20230724130006.427522-2-corvink@FreeBSD.org> <899bbdac-5aa3-50c4-f6e2-926b7a22c799@bsdio.com> From: "Michael Kubacki" In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: zUxJeanZ4u9wqMaDroIOVDihx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Sp2R++K3; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io I'm not sure why test results are not being reported that may be a=20 larger issue. I pulled the branch locally, run uncrustify, and it automatically fixed=20 the code to pass. The issue is the following function call: BuildPlatformInfoHob(); Should be: BuildPlatformInfoHob (); On 8/10/2023 11:46 AM, Ard Biesheuvel wrote: > Could someone please decipher this for us please? I am sick and tired > of the CI impeding my work. >=20 >=20 > On Thu, 10 Aug 2023 at 15:33, Corvin K=C3=B6hne wro= te: >> >> On Thu, 2023-08-10 at 14:55 +0200, Ard Biesheuvel wrote: >>> On Thu, 10 Aug 2023 at 14:53, Corvin K=C3=B6hne >>> wrote: >>>> >>>> On Tue, 2023-08-08 at 18:25 +0200, Ard Biesheuvel wrote: >>>>> On Tue, 8 Aug 2023 at 15:33, Rebecca Cran >>>>> wrote: >>>>>> >>>>>> Nit: "sizeof" is normally used like a function. And this patch >>>>>> mixes the >>>>>> two styles. >>>>>> >>>>> >>>>> Actually, this is not unidiomatic for OVMF - sizeof takes either >>>>> a >>>>> type name (in which case the () are required) or an expression >>>>> (in >>>>> which case they are optional), and we have always permitted both >>>>> idioms for the latter case. >>>>> >>>>> $ git grep -cE 'sizeof\s*[:alnum:]' OvmfPkg/ >>>>> OvmfPkg/Bhyve/BhyveRfbDxe/VbeShim.c:4 >>>>> OvmfPkg/EnrollDefaultKeys/AuthData.c:4 >>>>> OvmfPkg/IncompatiblePciDeviceSupportDxe/IncompatiblePciDeviceSupp >>>>> ort. >>>>> c:7 >>>>> OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.c >>>>> :1 >>>>> OvmfPkg/PlatformPei/MemTypeInfo.c:1 >>>>> OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.c:5 >>>>> OvmfPkg/QemuVideoDxe/VbeShim.c:4 >>>>> OvmfPkg/SmmControl2Dxe/SmiFeatures.c:4 >>>>> OvmfPkg/Virtio10Dxe/Virtio10.c:1 >>>>> OvmfPkg/VirtioGpuDxe/DriverBinding.c:4 >>>>> >>>>> >>>>>> Other than that: >>>>>> >>>>>> >>>>>> Reviewed-by: Rebecca Cran >>>>>> >>>>> >>>>> Thanks >>>>> >>>>> >>>>> I've tried to merge this but I am getting errors and I cannot >>>>> figure >>>>> out what they are: >>>>> >>>>> https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=3D9950= 5&view=3Dresults >>>>> >>>> >>>> Thanks. Have you tried >>>> https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Code-Form= atting#how-to-find-uncrustify-formatting-errors-in-continuous-integration-c= i >>>> >>>> I'm stuck at step 5. I can't see something like "92.5% passed". >>>> Maybe I >>>> don't have the permission to see it? >>>> >>> >>> I was having the same problem. The instructions don't match the >>> actual >>> situation, so it is impossible for me to figure why the CI decided to >>> reject the series. >> >> The function is copied from OvmfPkg/PlatformPei. So, it's unlikely that >> it causes issues. Nevertheless, I found a candidate: >> >>> diff --git a/OvmfPkg/Bhyve/PlatformPei/Platform.c >> b/OvmfPkg/Bhyve/PlatformPei/Platform.c >>> index 5bfe435327c1..bdfc1614d284 100644 >>> --- a/OvmfPkg/Bhyve/PlatformPei/Platform.c >>> +++ b/OvmfPkg/Bhyve/PlatformPei/Platform.c >>> @@ -17,6 +17,7 @@ >>> // >>> // The Library classes this module consumes >>> // >>> +#include >>> #include >> >> This is not in alphabetical order. >> >>> #include >>> #include >> >> >> -- >> Kind regards, >> Corvin >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107701): https://edk2.groups.io/g/devel/message/107701 Mute This Topic: https://groups.io/mt/100327419/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-