From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8E74820352A8A for ; Mon, 8 Jan 2018 03:25:36 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3AB72883CA; Mon, 8 Jan 2018 11:30:46 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-150.rdu2.redhat.com [10.10.120.150]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8710560467; Mon, 8 Jan 2018 11:30:45 +0000 (UTC) To: Jian J Wang , edk2-devel@lists.01.org References: <20180108053958.11988-1-jian.j.wang@intel.com> From: Laszlo Ersek Message-ID: <47bdd692-9312-0bc6-5190-b1e3ec769774@redhat.com> Date: Mon, 8 Jan 2018 12:30:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180108053958.11988-1-jian.j.wang@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Mon, 08 Jan 2018 11:30:46 +0000 (UTC) Subject: Re: [PATCH v3 0/2] Fix wrong address set as Stack Guard for APs X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Jan 2018 11:25:37 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 01/08/18 06:39, Jian J Wang wrote: >> v3 changes: >> a. Split the patch into two patch files. >> b. Pass MpServiceProtocol test cases in PI SCT. > >> v2 changes: >> a. Use each AP's ApTopOfStack to get the stack base address instead of >> cpu0's ApTopOfStack which is actually set incorrectly before. >> b. Fix cpu0's ApTopOfStack initialization. >> c. Fix wrong debug print format. > > The reason is that DXE part initialization will reuse the stack allocated > at PEI phase, if MP was initialized before. Some code added to check this > situation and use stack base address saved in HOB passed from PEI. > > Jian J Wang (2): > UefiCpuPkg/MpInitLib: fix incorrect stack base init for cpu0 > UefiCpuPkg/MpInitLib: fix wrong address set as Stack Guard for APs > > UefiCpuPkg/Library/MpInitLib/DxeMpLib.c | 19 ++++++++++++++++++- > UefiCpuPkg/Library/MpInitLib/MpLib.c | 2 +- > 2 files changed, 19 insertions(+), 2 deletions(-) > series Reviewed-by: Laszlo Ersek Thanks! Laszlo