From: "Rebecca Cran" <rebecca@nuviainc.com>
To: devel@edk2.groups.io, gaoliming@byosoft.com.cn
Cc: ray.ni@intel.com, zhichao.gao@intel.com
Subject: Re: [EXTERNAL] 回复: [edk2-devel] [PATCH 1/2] ShellPkg: add ARM64 SoC ID to Processor Characteristics in smbiosview
Date: Tue, 20 Oct 2020 22:22:42 -0600 [thread overview]
Message-ID: <47d089ff-3c2d-ede3-0276-b7253e12c3c6@nuviainc.com> (raw)
In-Reply-To: <004501d6a745$de8be360$9ba3aa20$@byosoft.com.cn>
On 10/20/20 7:02 PM, gaoliming wrote:
> Rebecca:
> ARM64 SoC ID Processor Characteristics is also required to be added into
> struct PROCESSOR_CHARACTERISTIC_FLAGS in
> edk2\MdePkg\Include\IndustryStandard\SmBios.h. Can you provide another patch
> for the change in MdePkg?
Yes, I'll submit another patch to fix that.
The PROCESSOR_CHARACTERISTIC_FLAGS structure needs some other work:
ProcessorCharacteristics is a UINT16 not UINT32 field, and several of
the fields have spelling mistakes (e.g. Processor64BitCapble). Once
that's fixed we can probably change the type in the SMBIOS_TABLE_TYPE4
from UINT16 to PROCESSOR_CHARACTERISTICS_FLAGS.
--
Rebecca Cran
prev parent reply other threads:[~2020-10-21 4:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 19:59 [PATCH 1/2] ShellPkg: add ARM64 SoC ID to Processor Characteristics in smbiosview Rebecca Cran
2020-10-20 21:05 ` [edk2-devel] " Samer El-Haj-Mahmoud
2020-10-21 1:02 ` 回复: " gaoliming
2020-10-21 4:22 ` Rebecca Cran [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47d089ff-3c2d-ede3-0276-b7253e12c3c6@nuviainc.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox