[PATCH 1/2] ShellPkg: add ARM64 SoC ID to Processor Characteristics in smbiosview

[PATCH 1/2] ShellPkg: add ARM64 SoC ID to Processor Characteristics in smbiosview

[Rebecca Cran]

SMBIOS 3.4.0 defines bit 9 of the Type 4 table Processor Characteristics
field to be the ARM64 SoC ID support. Add support for it to the
smbiosview command.

Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
---
 .../UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c        | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
index 17a2a89d512e..d0796a0e5141 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
@@ -624,6 +624,10 @@ TABLE_ITEM  ProcessorCharacteristicsTable[] = {
   {
     8,
     L" 128-bit Capable"
+  },
+  {
+    9,
+    L" ARM64 SoC ID"
   }
 };
 
-- 
2.26.2

Re: [edk2-devel] [PATCH 1/2] ShellPkg: add ARM64 SoC ID to Processor Characteristics in smbiosview

[Samer El-Haj-Mahmoud]

Thanks for adding this!

Reviewed-By: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca
> Cran via groups.io
> Sent: Tuesday, October 20, 2020 4:00 PM
> To: devel@edk2.groups.io
> Cc: Rebecca Cran <rebecca@nuviainc.com>; ray.ni@intel.com;
> zhichao.gao@intel.com
> Subject: [edk2-devel] [PATCH 1/2] ShellPkg: add ARM64 SoC ID to Processor
> Characteristics in smbiosview
>
> SMBIOS 3.4.0 defines bit 9 of the Type 4 table Processor Characteristics field
> to be the ARM64 SoC ID support. Add support for it to the smbiosview
> command.
>
> Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
> ---
>  .../UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c        | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.
> c
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.
> c
> index 17a2a89d512e..d0796a0e5141 100644
> ---
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.
> c
> +++
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.
> +++ c
> @@ -624,6 +624,10 @@ TABLE_ITEM  ProcessorCharacteristicsTable[] = {
>    {
>      8,
>      L" 128-bit Capable"
> +  },
> +  {
> +    9,
> +    L" ARM64 SoC ID"
>    }
>  };
>
> --
> 2.26.2
>
>
>
> 
>

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

回复: [edk2-devel] [PATCH 1/2] ShellPkg: add ARM64 SoC ID to Processor Characteristics in smbiosview

[gaoliming]

Rebecca:
  ARM64 SoC ID Processor Characteristics is also required to be added into
struct PROCESSOR_CHARACTERISTIC_FLAGS in
edk2\MdePkg\Include\IndustryStandard\SmBios.h. Can you provide another patch
for the change in MdePkg?

Thanks
Liming
> -----邮件原件-----
> 发件人: bounce+27952+66457+4905953+8761045@groups.io
> <bounce+27952+66457+4905953+8761045@groups.io> 代表 Rebecca Cran
> 发送时间: 2020年10月21日 4:00
> 收件人: devel@edk2.groups.io
> 抄送: Rebecca Cran <rebecca@nuviainc.com>; ray.ni@intel.com;
> zhichao.gao@intel.com
> 主题: [edk2-devel] [PATCH 1/2] ShellPkg: add ARM64 SoC ID to Processor
> Characteristics in smbiosview
> 
> SMBIOS 3.4.0 defines bit 9 of the Type 4 table Processor Characteristics
> field to be the ARM64 SoC ID support. Add support for it to the
> smbiosview command.
> 
> Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
> ---
>  .../UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c        | 4
> ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
> index 17a2a89d512e..d0796a0e5141 100644
> ---
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
> +++
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
> @@ -624,6 +624,10 @@ TABLE_ITEM  ProcessorCharacteristicsTable[] = {
>    {
>      8,
>      L" 128-bit Capable"
> +  },
> +  {
> +    9,
> +    L" ARM64 SoC ID"
>    }
>  };
> 
> --
> 2.26.2
> 
> 
> 
> 
> 

Re: [EXTERNAL] 回复: [edk2-devel] [PATCH 1/2] ShellPkg: add ARM64 SoC ID to Processor Characteristics in smbiosview

[Rebecca Cran]

On 10/20/20 7:02 PM, gaoliming wrote:

> Rebecca:
>    ARM64 SoC ID Processor Characteristics is also required to be added into
> struct PROCESSOR_CHARACTERISTIC_FLAGS in
> edk2\MdePkg\Include\IndustryStandard\SmBios.h. Can you provide another patch
> for the change in MdePkg?

Yes, I'll submit another patch to fix that.

The PROCESSOR_CHARACTERISTIC_FLAGS structure needs some other work: 
ProcessorCharacteristics is a UINT16 not UINT32 field, and several of 
the fields have spelling mistakes (e.g. Processor64BitCapble). Once 
that's fixed we can probably change the type in the SMBIOS_TABLE_TYPE4 
from UINT16 to PROCESSOR_CHARACTERISTICS_FLAGS.


-- 
Rebecca Cran