From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f66.google.com (mail-pj1-f66.google.com [209.85.216.66]) by mx.groups.io with SMTP id smtpd.web11.6750.1603254165364078470 for ; Tue, 20 Oct 2020 21:22:45 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=19qebU2G; spf=pass (domain: nuviainc.com, ip: 209.85.216.66, mailfrom: rebecca@nuviainc.com) Received: by mail-pj1-f66.google.com with SMTP id g16so483945pjv.3 for ; Tue, 20 Oct 2020 21:22:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=805AW48P0OK7+fan/u+0IOPtABZivGC9OqfG2VvrhYA=; b=19qebU2G+K94y1QcVEA2EEUN/FdqGu5Hi7wqoR+pdS/o/BZckxmKKrCYtQvAUcOfCo /EPAhOcJRoL0U7hCOF5pzmofBs+/lhUEUxa2MC1Hfnp3ecBpEqEc+qnkPUNchfAI8boJ xmhx4aM92Tcas+wg6wvKzfYGsVzRIrNs9bUwddTKe4HXLoPkOsy0tutCVOhbxYkStm6k Ok5yusMt0CdyUGpqIoBtInrcCQguirNYxYLgTc7Gejn9QKPIJtl3LBjH25Zqw4glJkge XSXWmuox2T2Y3AIVG3cyf+XTAqMU3iFNyad2pD0m3eNo372LrezCkmWDQmj7GN9PMIJU FHFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=805AW48P0OK7+fan/u+0IOPtABZivGC9OqfG2VvrhYA=; b=HO78DbDAsHgEx9xRh1PMSNulnXLmDVFXCw1QsquDx3kd4JFok8I3HeV1PunmPoe+I+ Uu4LuSVxk/T90hue2b0Kb6L3KZeu1C33fSY9wStNAYjnoLO20t6LE7/IAWaj8CDFAQlG LmbfV9S1dxgySXa0ALKZ58N6CHvCqVsSRINY7h+niyQkMpM36QuofPDn7f48Uj+4nwZx pTX4Iy17Cx0qg9SKOGzZbtTG7UkMVBlrZu/C8ooQyqDj5VhNqmBydG74u3Rc09m/vQxe 8+Kj2JyLpWNfif0DIH9/ZlVdILcKyvB9064z62ZKbQIei5bPEGeBjTRqAvscGyaiVV1i ltgA== X-Gm-Message-State: AOAM531h4xHl/WoPjsI/ziUNi0LJApsng3eLViAiLcKfpuKpLeBFWYrc /hcEicf4S+ES2jwBn/WSnmdo5Q== X-Google-Smtp-Source: ABdhPJzjlZZoELd0M+LrjLWChrpqqWyEsPhrEIV6ewbkZrv3T4LAUJ3JMRGC+0zMGXh1SPLTDEdZAA== X-Received: by 2002:a17:902:bc8a:b029:d4:dc57:6c29 with SMTP id bb10-20020a170902bc8ab02900d4dc576c29mr1553153plb.77.1603254164829; Tue, 20 Oct 2020 21:22:44 -0700 (PDT) Return-Path: Received: from [10.0.10.142] (c-174-52-16-57.hsd1.ut.comcast.net. [174.52.16.57]) by smtp.gmail.com with ESMTPSA id kc21sm564746pjb.36.2020.10.20.21.22.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Oct 2020 21:22:44 -0700 (PDT) Subject: =?UTF-8?B?UmU6IFtFWFRFUk5BTF0g5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIDEvMl0gU2hlbGxQa2c6IGFkZCBBUk02NCBTb0MgSUQgdG8gUHJvY2Vzc29yIENoYXJhY3RlcmlzdGljcyBpbiBzbWJpb3N2aWV3?= To: devel@edk2.groups.io, gaoliming@byosoft.com.cn Cc: ray.ni@intel.com, zhichao.gao@intel.com References: <20201020195952.13314-1-rebecca@nuviainc.com> <004501d6a745$de8be360$9ba3aa20$@byosoft.com.cn> From: "Rebecca Cran" Message-ID: <47d089ff-3c2d-ede3-0276-b7253e12c3c6@nuviainc.com> Date: Tue, 20 Oct 2020 22:22:42 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <004501d6a745$de8be360$9ba3aa20$@byosoft.com.cn> Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US On 10/20/20 7:02 PM, gaoliming wrote: > Rebecca: > ARM64 SoC ID Processor Characteristics is also required to be added into > struct PROCESSOR_CHARACTERISTIC_FLAGS in > edk2\MdePkg\Include\IndustryStandard\SmBios.h. Can you provide another patch > for the change in MdePkg? Yes, I'll submit another patch to fix that. The PROCESSOR_CHARACTERISTIC_FLAGS structure needs some other work: ProcessorCharacteristics is a UINT16 not UINT32 field, and several of the fields have spelling mistakes (e.g. Processor64BitCapble). Once that's fixed we can probably change the type in the SMBIOS_TABLE_TYPE4 from UINT16 to PROCESSOR_CHARACTERISTICS_FLAGS. -- Rebecca Cran