* [edk2-devel] [PATCH V2 1/1] CryptoPkg: Remove outdated code related to deprecated SHA-1 [not found] <cover.1715826321.git.qingyu.shang@intel.com> @ 2024-05-16 2:27 ` Qingyu 2024-05-16 2:42 ` Li, Yi 0 siblings, 1 reply; 2+ messages in thread From: Qingyu @ 2024-05-16 2:27 UTC (permalink / raw) To: devel; +Cc: Jiewen Yao, Yi Li REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4698 The default drbg type of randlib has been switched to aes_256_ctr in openssl1.1.1, so sha1 is not really used in RandomSeed(). Remove related code which do SHA-1 support checking in CryptRand.c and CryptRandTsc.c to avoid potential compatibility errors. Signed-off-by: Shang Qingyu <qingyu.shang@intel.com> Cc: Jiewen Yao <jiewen.yao@intel.com> Cc: Yi Li <yi1.li@intel.com> --- CryptoPkg/Library/BaseCryptLib/Rand/CryptRandTsc.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/CryptoPkg/Library/BaseCryptLib/Rand/CryptRandTsc.c b/CryptoPkg/Library/BaseCryptLib/Rand/CryptRandTsc.c index 30454bf10f9b..b94c16de562d 100644 --- a/CryptoPkg/Library/BaseCryptLib/Rand/CryptRandTsc.c +++ b/CryptoPkg/Library/BaseCryptLib/Rand/CryptRandTsc.c @@ -40,14 +40,6 @@ RandomSeed ( return FALSE; } - // - // The software PRNG implementation built in OpenSSL depends on message digest algorithm. - // Make sure SHA-1 digest algorithm is available here. - // - if (EVP_add_digest (EVP_sha1 ()) == 0) { - return FALSE; - } - // // Seed the pseudorandom number generator with user-supplied value. // NOTE: A cryptographic PRNG must be seeded with unpredictable data. -- 2.44.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118942): https://edk2.groups.io/g/devel/message/118942 Mute This Topic: https://groups.io/mt/106127679/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [edk2-devel] [PATCH V2 1/1] CryptoPkg: Remove outdated code related to deprecated SHA-1 2024-05-16 2:27 ` [edk2-devel] [PATCH V2 1/1] CryptoPkg: Remove outdated code related to deprecated SHA-1 Qingyu @ 2024-05-16 2:42 ` Li, Yi 0 siblings, 0 replies; 2+ messages in thread From: Li, Yi @ 2024-05-16 2:42 UTC (permalink / raw) To: Shang, Qingyu, devel@edk2.groups.io; +Cc: Yao, Jiewen Hi, Qingyu I am still not see any codes related to CryptRand.c, are you missed 'git add' for new change? Regards, Yi -----Original Message----- From: Shang, Qingyu <qingyu.shang@intel.com> Sent: Thursday, May 16, 2024 10:28 AM To: devel@edk2.groups.io Cc: Yao, Jiewen <jiewen.yao@intel.com>; Li, Yi1 <yi1.li@intel.com> Subject: [PATCH V2 1/1] CryptoPkg: Remove outdated code related to deprecated SHA-1 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4698 The default drbg type of randlib has been switched to aes_256_ctr in openssl1.1.1, so sha1 is not really used in RandomSeed(). Remove related code which do SHA-1 support checking in CryptRand.c and CryptRandTsc.c to avoid potential compatibility errors. Signed-off-by: Shang Qingyu <qingyu.shang@intel.com> Cc: Jiewen Yao <jiewen.yao@intel.com> Cc: Yi Li <yi1.li@intel.com> --- CryptoPkg/Library/BaseCryptLib/Rand/CryptRandTsc.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/CryptoPkg/Library/BaseCryptLib/Rand/CryptRandTsc.c b/CryptoPkg/Library/BaseCryptLib/Rand/CryptRandTsc.c index 30454bf10f9b..b94c16de562d 100644 --- a/CryptoPkg/Library/BaseCryptLib/Rand/CryptRandTsc.c +++ b/CryptoPkg/Library/BaseCryptLib/Rand/CryptRandTsc.c @@ -40,14 +40,6 @@ RandomSeed ( return FALSE; } - // - // The software PRNG implementation built in OpenSSL depends on message digest algorithm. - // Make sure SHA-1 digest algorithm is available here. - // - if (EVP_add_digest (EVP_sha1 ()) == 0) { - return FALSE; - } - // // Seed the pseudorandom number generator with user-supplied value. // NOTE: A cryptographic PRNG must be seeded with unpredictable data. -- 2.44.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118944): https://edk2.groups.io/g/devel/message/118944 Mute This Topic: https://groups.io/mt/106127679/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-05-16 2:43 UTC | newest] Thread overview: 2+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- [not found] <cover.1715826321.git.qingyu.shang@intel.com> 2024-05-16 2:27 ` [edk2-devel] [PATCH V2 1/1] CryptoPkg: Remove outdated code related to deprecated SHA-1 Qingyu 2024-05-16 2:42 ` Li, Yi
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox