From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, jian.j.wang@intel.com, "Jiang,
Guomin" <guomin.jiang@intel.com>
Cc: "Lu, XiaoyuX" <xiaoyux.lu@intel.com>, GuoMinJ <newexplorerj@gmail.com>
Subject: Re: [edk2-devel] [PATCH 1/1] CryptoPkg/OpensslLib: Upgrade OpenSSL to 1.1.1g
Date: Thu, 16 Jul 2020 15:09:12 +0200 [thread overview]
Message-ID: <480db282-9db5-f0f3-9753-8a1f18923e17@redhat.com> (raw)
In-Reply-To: <SN6PR11MB33121638DF48ACCCADBBEFE9B67F0@SN6PR11MB3312.namprd11.prod.outlook.com>
On 07/16/20 10:12, Wang, Jian J wrote:
> Guomin,
>
> Thank you very much for this upgrade.
>
> Just one comment. The opensslconf.h and dso_conf.h generated after calling
> process_files.pl are unix EOL. But the EOL in the patch is correct. I guess you
> converted them manually.
This answers my question (1).
Before the patch, "dso_conf.h" uses LF, while "opensslconf.h" uses CRLF.
After the patch, both files use CRLF.
So it seems that the *previous* openssl update forgot to convert
"dso_conf.h" to CRLF. Because, apparently, we want both header files to
use CRLF.
Thanks
Laszlo
prev parent reply other threads:[~2020-07-16 13:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 2:27 [PATCH 1/1] CryptoPkg/OpensslLib: Upgrade OpenSSL to 1.1.1g Guomin Jiang
2020-07-13 10:57 ` [edk2-devel] " Laszlo Ersek
2020-07-16 8:12 ` Wang, Jian J
2020-07-16 13:09 ` Laszlo Ersek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=480db282-9db5-f0f3-9753-8a1f18923e17@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox