From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81])
 by mx.groups.io with SMTP id smtpd.web12.14798.1594904960376205884
 for <devel@edk2.groups.io>;
 Thu, 16 Jul 2020 06:09:20 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=LVsvvsoc;
 spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1594904959;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=J7InNEVYpcPsz7WnITU2THwuKlfpXw3u9bfr3dbzbv4=;
	b=LVsvvsoclbaROVA7xHfa6Ao/MnfONpT8koUsGK1y/SGo9WsrYhd3D3QxH3FfEkHZ7vkaCA
	UK/3E2CrcJS6W+13YTwrZLFjsdLkwRwans+pO8Y9iw7gyulh8Kwz3E/i2IVsD5yN0u6N6x
	KzPn+GidPf/Ix5xprHzEA9otDoCVPQQ=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-43-SwAYyDyiPgurLQKbKvpCvw-1; Thu, 16 Jul 2020 09:09:15 -0400
X-MC-Unique: SwAYyDyiPgurLQKbKvpCvw-1
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 44E571081;
	Thu, 16 Jul 2020 13:09:14 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-123.ams2.redhat.com [10.36.112.123])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 2220F72ADA;
	Thu, 16 Jul 2020 13:09:12 +0000 (UTC)
Subject: Re: [edk2-devel] [PATCH 1/1] CryptoPkg/OpensslLib: Upgrade OpenSSL to 1.1.1g
To: devel@edk2.groups.io, jian.j.wang@intel.com,
 "Jiang, Guomin" <guomin.jiang@intel.com>
Cc: "Lu, XiaoyuX" <xiaoyux.lu@intel.com>, GuoMinJ <newexplorerj@gmail.com>
References: <20200710022736.408-1-guomin.jiang@intel.com>
 <SN6PR11MB33121638DF48ACCCADBBEFE9B67F0@SN6PR11MB3312.namprd11.prod.outlook.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <480db282-9db5-f0f3-9753-8a1f18923e17@redhat.com>
Date: Thu, 16 Jul 2020 15:09:12 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Firefox/52.0 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <SN6PR11MB33121638DF48ACCCADBBEFE9B67F0@SN6PR11MB3312.namprd11.prod.outlook.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

On 07/16/20 10:12, Wang, Jian J wrote:
> Guomin,
> 
> Thank you very much for this upgrade.
> 
> Just one comment. The opensslconf.h and dso_conf.h generated after calling
> process_files.pl are unix EOL. But the EOL in the patch is correct. I guess you
> converted them manually.

This answers my question (1).

Before the patch, "dso_conf.h" uses LF, while "opensslconf.h" uses CRLF.

After the patch, both files use CRLF.

So it seems that the *previous* openssl update forgot to convert
"dso_conf.h" to CRLF. Because, apparently, we want both header files to
use CRLF.

Thanks
Laszlo