From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.68]) by mx.groups.io with SMTP id smtpd.web11.20118.1678714971246537293 for ; Mon, 13 Mar 2023 06:42:51 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=tu0VxXh8; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.92.68, mailfrom: thomas.lendacky@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Rgy06JJ36IvLNSE+yhk5J2ckUAFepQF4ohyznqXHyojqy4BZVI2nfpVU18HZ95EpmzoeN6VHR40Wil9FpQMC5svdD5XI9X4YCr01t7j/32blpwZyfnIgvSGKEmoRXIkho7fvDASm5PH+A6H333fBCemROWPM8XAKnIwf2NAKu/f+lhmPrVCl59VWveWD6PmFDEN3P0l6w/gdINjrI89NnE4+W6mce4IIH8tO6iSbuVucENZY1U2Ml6GPYGdDxRZw3qTrP3I7Z4vBnM6cfY3CbhvWjxXRcKkB8vPPZBBLt7fxkcwOxJ0XpIwoO5YPePWq1OOg8Kbq0wWTJNnW7k7UWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HL01H+26ffPvWHzuZlJiogYJqD5sPF4cvG7jK4A8Plo=; b=ExsliYJcrmfseaVEYGY6QG4WRYbL2LCYgAs9RkesF2xJpiLZFBtEOZ/rg671hosl3aYCC2xW6UY0HI4RimlKJTU//399WnBgL49a0sfozvN0OoHtqfkKzi3rx9qzL5/CyfOgh6Zz669CVHJxh1GU+2g4rk6K+0NZZ4hx+PDh+9KhjWzkCVwdN/zaK/WLU3h456bO6oGTQZbecwlz0TTWM/Xj//S185GmF6HLKnSl5Q1GfhV/Gu7L9+bLcEhuldZTuD8rSFKKge/77IuExxaDc+ncWdrojmIwk6TRTgrkXLgDyPhCSRWUZJ/758ukCx5nHXxBog486gRZ3AOAIIW7Pg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HL01H+26ffPvWHzuZlJiogYJqD5sPF4cvG7jK4A8Plo=; b=tu0VxXh8rHqYDdS15M77JxzCwYO5MbL3kQAoGps3QrjEF+uwSnqOUEeu0IyllpugeUVn7ArM4b7bVl84q8Qh543yxlVQojqq2nt2l8G0Y1rOrjL+ZHrAPAjTasaz6pl6ZKHxkv5LmCQ15aIYudBnmcwoZRVyBTniSTVoNg/N0ZY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM4PR12MB5229.namprd12.prod.outlook.com (2603:10b6:5:398::12) by CH3PR12MB7740.namprd12.prod.outlook.com (2603:10b6:610:145::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.24; Mon, 13 Mar 2023 13:42:49 +0000 Received: from DM4PR12MB5229.namprd12.prod.outlook.com ([fe80::5b56:bf13:70be:ea60]) by DM4PR12MB5229.namprd12.prod.outlook.com ([fe80::5b56:bf13:70be:ea60%7]) with mapi id 15.20.6178.024; Mon, 13 Mar 2023 13:42:49 +0000 Message-ID: <48267b49-c88d-0122-8772-1453f7f144a2@amd.com> Date: Mon, 13 Mar 2023 08:42:46 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 1/2] UefiCpuPkg/MpInitLib: Ensure SEV-SNP VMSA allocations are not 2MB aligned To: "Ni, Ray" , "devel@edk2.groups.io" Cc: "Dong, Eric" , "Kumar, Rahul R" , Gerd Hoffmann , Michael Roth , Ashish Kalra References: <0ae6206c682709f09214222bd597d4aa6578c56a.1678467840.git.thomas.lendacky@amd.com> From: "Lendacky, Thomas" In-Reply-To: X-ClientProxiedBy: CH0PR03CA0187.namprd03.prod.outlook.com (2603:10b6:610:e4::12) To DM4PR12MB5229.namprd12.prod.outlook.com (2603:10b6:5:398::12) Return-Path: Thomas.Lendacky@amd.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR12MB5229:EE_|CH3PR12MB7740:EE_ X-MS-Office365-Filtering-Correlation-Id: 67699c41-6d16-48a2-6cff-08db23c8d5ac X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ttH1Y0YUXhkC3gcxKI1PeLPDOl7DW7nAbm+r2cNZHyyDJFqvgL70Al5Vne8fXQ+fRUJIcm5Ea9DpgViP8VSZ4CogFu6RACU7mhA0EHykWcOdgDOgKQiI2Pvna0DhnIE/17Ijw4q7jr0dT7LYUwjRaNdQluUmYK0HmgTIRHHdK4mXoK/BIpjQrFXVLXuE1i9ipYAxlayCf5O4hy1rOzJLF76kkkwEQlK4s7j4Xb4rtVKsuZ92qKtDOjhAvIXMkq+gJ0yH0DB9nbR0DJFIxMTi7FWuN+T0fLYPN+Xn6UTIAsiHQ0MSeQk7wZeMc/uOazL1ns9P593GEI+5r7RimfdVBJ/9rsKoyRYO+uMt2N++u+KhcctkQyrM10vF0VXxO83HWUHfg182iYdtEZ06h73yC/lOe/Tkwzf4SL348/r938sHtsi9iyvmDMeepSImPdXCXIek0h3SWdqFXmR0Dg5t/mSN/KEEoKhFtBo1EJkwddj0KU8P5rL9I3ghKlWLO8jf5x9gcjkhMdjPAkGbe1Bs9Tsd/bdkSAvUUDxNpO2oR22Pjlwq/9TqEZ5+t3WPLy38adZpRXycFJSSQie70H4vjJgfEuMvKIxrAavN/wA5ixmimtxEBSMRzrW0fMlYA8pGes7ddO+/P0QMacTGlZRU/5V7vvN1AI5KAgS4KBhazmtmitIuyT6GDLcLwiXAHf6PMC6cEWta/oYSaAheXmkPynaXoD+Xu0tnb95iuSTSZJg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB5229.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(6029001)(4636009)(396003)(346002)(376002)(136003)(39860400002)(366004)(451199018)(36756003)(31696002)(86362001)(186003)(41300700001)(6506007)(26005)(53546011)(6512007)(5660300002)(4326008)(2616005)(8936002)(316002)(110136005)(478600001)(54906003)(8676002)(66946007)(6666004)(66556008)(66476007)(6486002)(38100700002)(2906002)(4744005)(83380400001)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WjNSQ0lZVFlLNTlGVUhlNU5QNHR2N3NPZkhRenB1VjczNjRLMllCbFJ6aEVZ?= =?utf-8?B?UlRzbFNmUVpUWXNEdllxb2dkS29ZejV6K3hWR09JczhRWjNUaHVmZlVBcmht?= =?utf-8?B?R1hKMGlNd0owZjVRTmRxRWhyNVBOdURNZmVCQ3pWOW9UelZ0d1l4YVNSd1JO?= =?utf-8?B?eFdXZGRwRnhoUjMvZFV0a2RoMnBwMjRCZ0dwVlQrbHB0Y29maHorcnB5SUZo?= =?utf-8?B?bjIwU2crWEhLMER0VVowaVNGR2RUai9LRUt2SWRVemRGcGc0UGhZUk9LTGs5?= =?utf-8?B?TFEyM3VCOE1BSFlkME9BSWM3VEtMRUVjb1RrZUMvTzllWndZYXM0QkliRFhp?= =?utf-8?B?OEg0S2pGcWhLbldtdVRRNFVvVzZFajZsWUFQWlFGYms1UDJRM3dUOVdhSkpS?= =?utf-8?B?Ymdvajd2a2pYaFhwdklkTkdBRUZyR0tlNC9oKzVlL2REUXhkaElkV0lzVFJ3?= =?utf-8?B?Z0txZ1lSaXFjbFlOaWV5dnJIVGlCNmtNeFVqZDBhOExIQU8rZTVtR3NuRkFU?= =?utf-8?B?Z3Z0VHMxRVF3dG1UbFhLb0RFUTdraU5zcW1EYXhsVjZqR1FhK09RanJOcC83?= =?utf-8?B?ekw2NjAvbWVPdjF4eVhEelNQcmdERmF2bXI5MmoyY0ZSZGhlLytESS83N2Nh?= =?utf-8?B?YUFBdVprR3RpbjNZRm14UkVSaVFNTzRwcWRiQ0ZYSWh4eGRmUFd3R2psL2Zn?= =?utf-8?B?SGQyQ2JDVDhOUktnWVlqVUNGeGExVXlkMTdCK0MxSnc5OFZjMGIzNnhHUGd6?= =?utf-8?B?anFzSFF3VHRqUUJjbmtFNXc3SjI5bGFFRzIrVGdBR0VDc3ZpWHo0OUQrZUFV?= =?utf-8?B?VkFVOHJkMnFYcFllVWlmOUt1cXFuMUMwUGhVdWF0UGNENmV2ei9BbHMxcGZK?= =?utf-8?B?VkhyanUwS29QekNWQmdFc0tvcGNnZ3c1blJHOE1NQVhUWnZsSEpIcGkzcnI4?= =?utf-8?B?cG9LTzhLOGFIUXJyTEM2K0FqQTlqaFdTdTlwTkZiaEYvdGxpL0grVHEvSmF5?= =?utf-8?B?djA2ODZ5UzRIMHgxVWlYZ0pIQlpDNjZ1SmJMR0lHRFZmQ295c3RBc0lUM2Rm?= =?utf-8?B?L1FPM2VmOFdpNWI1RHpKQjJYa2w3SUcyTGpTRlovWDkzdkhvb2VYS3VLUVd1?= =?utf-8?B?Y2grSFA0ZGpYNDczbncrajBWUXk2bmI2SmErdXpuNnExV2ZnK010NTJlYjc0?= =?utf-8?B?KzN0azk1NGxaYyswMWtzL1h3c2loVk83V3V0K1JOeVhBcHRRdVBuVkFhbVpL?= =?utf-8?B?bytVRUFFSGk4S1owOHdqT0dtQ2xVViszSEpsdGVocmRlc2lmc3E1NDd6Z2p1?= =?utf-8?B?QWpSYUkyTkZuOGZWdnVvRnVRbWdhdC9MdzNzS2RTcVNFTHBIUmplcXJXQlQ5?= =?utf-8?B?RzloZllYSTZhQ3p0MGN1WS9sakdWYi9sVFByQjd1T2dDNDhET2Y4SVFFRVAw?= =?utf-8?B?d2NVSXFzSHVUQjh0cVp5a0VOdm9kUTFyTkJVdkNuNzYvK1lyNTVJMUVGM2lS?= =?utf-8?B?TTRpQ1BNdWFwMG5NVUl3MENjamNyYmRpM1IzSm00TnZNRWk2N0czTmEvcXVi?= =?utf-8?B?K3YwMTkxVTdvUCtRNmxld3EwdDYrUDZtdmpkd3lESS80a3FuQ1dQaTNpb3VZ?= =?utf-8?B?YTJ2eUg3L1hWbmdoOVM1L2NIckR2VU82Slo1WDcvTjVycXpYNUJ0ZWpvOUFs?= =?utf-8?B?a1RGWnI2NmZRSitEZ3VlU0N3L2w0WW8xaUpic1lWaWRTUHdIdHdTVWdJZGZB?= =?utf-8?B?NUJTNjBnb0lQcDRFMlhyODBPbmZKMVV6WUFBbENjTkRjeG9neGVzOExONTNI?= =?utf-8?B?ZllmektVT0ZzUlhTb0ZqVS9IRUNMNkhPcjQvWVhhWFA5NEsxUWdBc2JiajFr?= =?utf-8?B?eFNPNStrWURQVFlyb0p3Q1JaQW1wMGd0eUQ3Zlk5NmJpd28xVXY1WVd3b3JR?= =?utf-8?B?ZWg5Z2FrNkM3bkNyWVpBNkRkU2QyNWJuRHZiUHk2cG5IeHNtaEpHNDVRVDJt?= =?utf-8?B?bDRaKy9MNms5eW1aN2poTklHaGJlMGoyTXh6VEpzZzlrY3YzMUd0TFJCSUR0?= =?utf-8?B?WmorNXNma3FHZlZpQnR0eTlTemxyQk9Ba3BMUnFDU1o0bmRTSXhoSTBMai9y?= =?utf-8?Q?QhMw6b+mevFQ/bAMo2hOlriQg?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 67699c41-6d16-48a2-6cff-08db23c8d5ac X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2023 13:42:48.9741 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fEZJ+04HXzAGHohfSpBXuJqRfChDixyVm5BVygJKdBJ2++z3UFXJGoQ46xYwQCGQJf7yDRmBil312rfqw5515A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7740 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/13/23 03:28, Ni, Ray wrote: >> >> +#define IS_ALIGNED(x, y) ((((UINTN)(x) & (y - 1)) == 0)) > > 1. Can you use the existing macro ALIGN_POINTER() defined in Base.h? See my reply to the cover letter where I say I want to replace the usage with Gerd's definitions/updates series (but wanted general feedback now on the series). Thanks, Tom