Re: [edk2-devel] [PATCH 1/1] ShellPkg: Do not connect handles without device paths

["Gao, Zhichao" <zhichao.gao@intel.com>]

Hi,

What does 'freeze' mean? System blocked for a while or it hung up forever?

The change would affect the operation of the 'load' command. If some drivers need to connect to the device controller but it doesn't have a device path protocol, the behavior of 'load' may be incorrect.
Is the option '-nc' working for your request?

Thanks,
Zhichao

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Vitaly Cheptsov via Groups.Io
> Sent: Monday, January 13, 2020 5:39 AM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [PATCH 1/1] ShellPkg: Do not connect handles without
> device paths
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2460
> 
> Doing this reduces the amount of needless work during device connection
> and resolves issues with firmwares that freeze when connecting handles
> without device paths.
> 
> Signed-off-by: Vitaly Cheptsov <vit9696@protonmail.com>
> ---
>  ShellPkg/Library/UefiShellLevel2CommandsLib/Load.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/ShellPkg/Library/UefiShellLevel2CommandsLib/Load.c
> b/ShellPkg/Library/UefiShellLevel2CommandsLib/Load.c
> index b6e7c952fa..083aac0dba 100644
> --- a/ShellPkg/Library/UefiShellLevel2CommandsLib/Load.c
> +++ b/ShellPkg/Library/UefiShellLevel2CommandsLib/Load.c
> @@ -32,8 +32,8 @@ ConnectAllEfi (
>    UINTN       Index;
> 
>    Status = gBS->LocateHandleBuffer (
> -                  AllHandles,
> -                  NULL,
> +                  ByProtocol,
> +                  &gEfiDevicePathProtocolGuid,
>                    NULL,
>                    &HandleCount,
>                    &HandleBuffer
> --
> 2.21.0 (Apple Git-122.2)
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> 
> View/Reply Online (#53170): https://edk2.groups.io/g/devel/message/53170
> Mute This Topic: https://groups.io/mt/69653841/1768756
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [zhichao.gao@intel.com]
> -=-=-=-=-=-=