From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web10.35220.1578903092431040292 for ; Mon, 13 Jan 2020 00:11:32 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: zhichao.gao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Jan 2020 00:11:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,428,1571727600"; d="scan'208";a="224831709" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga003.jf.intel.com with ESMTP; 13 Jan 2020 00:11:26 -0800 Received: from shsmsx606.ccr.corp.intel.com (10.109.6.216) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 13 Jan 2020 00:11:26 -0800 Received: from shsmsx603.ccr.corp.intel.com (10.109.6.143) by SHSMSX606.ccr.corp.intel.com (10.109.6.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 13 Jan 2020 16:11:24 +0800 Received: from shsmsx603.ccr.corp.intel.com ([10.109.6.143]) by SHSMSX603.ccr.corp.intel.com ([10.109.6.143]) with mapi id 15.01.1713.004; Mon, 13 Jan 2020 16:11:24 +0800 From: "Gao, Zhichao" To: "devel@edk2.groups.io" , "vit9696@protonmail.com" CC: "Ni, Ray" , "Gao, Zhichao" Subject: Re: [edk2-devel] [PATCH 1/1] ShellPkg: Do not connect handles without device paths Thread-Topic: [edk2-devel] [PATCH 1/1] ShellPkg: Do not connect handles without device paths Thread-Index: AQHVyZC/Qe6p2ZGwfEaS4TYlM59ZjKfoPDaA Date: Mon, 13 Jan 2020 08:11:24 +0000 Message-ID: <483a200323c14afb95bdb94ad447868d@intel.com> References: <20200112213845.96853-1-vit9696@protonmail.com> <20200112213845.96853-2-vit9696@protonmail.com> In-Reply-To: <20200112213845.96853-2-vit9696@protonmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.36] MIME-Version: 1.0 Return-Path: zhichao.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi, What does 'freeze' mean? System blocked for a while or it hung up forever? The change would affect the operation of the 'load' command. If some driver= s need to connect to the device controller but it doesn't have a device pat= h protocol, the behavior of 'load' may be incorrect. Is the option '-nc' working for your request? Thanks, Zhichao > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Vitaly Cheptsov via Groups.Io > Sent: Monday, January 13, 2020 5:39 AM > To: devel@edk2.groups.io > Subject: [edk2-devel] [PATCH 1/1] ShellPkg: Do not connect handles withou= t > device paths >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2460 >=20 > Doing this reduces the amount of needless work during device connection > and resolves issues with firmwares that freeze when connecting handles > without device paths. >=20 > Signed-off-by: Vitaly Cheptsov > --- > ShellPkg/Library/UefiShellLevel2CommandsLib/Load.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/ShellPkg/Library/UefiShellLevel2CommandsLib/Load.c > b/ShellPkg/Library/UefiShellLevel2CommandsLib/Load.c > index b6e7c952fa..083aac0dba 100644 > --- a/ShellPkg/Library/UefiShellLevel2CommandsLib/Load.c > +++ b/ShellPkg/Library/UefiShellLevel2CommandsLib/Load.c > @@ -32,8 +32,8 @@ ConnectAllEfi ( > UINTN Index; >=20 > Status =3D gBS->LocateHandleBuffer ( > - AllHandles, > - NULL, > + ByProtocol, > + &gEfiDevicePathProtocolGuid, > NULL, > &HandleCount, > &HandleBuffer > -- > 2.21.0 (Apple Git-122.2) >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. >=20 > View/Reply Online (#53170): https://edk2.groups.io/g/devel/message/53170 > Mute This Topic: https://groups.io/mt/69653841/1768756 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub > [zhichao.gao@intel.com] > -=3D-=3D-=3D-=3D-=3D-=3D