* [PATCH 1/1] EmbeddedPkg/RealTimeClockRuntimeDxe: depend on gEfiVariableArchProtocolGuid
@ 2021-01-08 13:41 Nhi Pham
2021-01-08 14:02 ` [edk2-devel] " Laszlo Ersek
2021-01-10 1:20 ` Leif Lindholm
0 siblings, 2 replies; 4+ messages in thread
From: Nhi Pham @ 2021-01-08 13:41 UTC (permalink / raw)
To: devel; +Cc: Nhi Pham, Leif Lindholm, Ard Biesheuvel
The EfiGetVariable() is used in the entry of this module. So, the
variable services are required to be ready before they are used. This
patch adds the arch protocol gEfiVariableArchProtocolGuid to dependency
expression to guarantee that this module will be started once the
variable protocol is available.
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Signed-off-by: Nhi Pham <nhi@os.amperecomputing.com>
---
EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf b/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf
index fec53c79d335..0a4cd6dae703 100644
--- a/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf
+++ b/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf
@@ -38,5 +38,5 @@ [Protocols]
gEfiRealTimeClockArchProtocolGuid
[Depex]
- TRUE
+ gEfiVariableArchProtocolGuid
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg/RealTimeClockRuntimeDxe: depend on gEfiVariableArchProtocolGuid
2021-01-08 13:41 [PATCH 1/1] EmbeddedPkg/RealTimeClockRuntimeDxe: depend on gEfiVariableArchProtocolGuid Nhi Pham
@ 2021-01-08 14:02 ` Laszlo Ersek
2021-01-08 14:07 ` Nhi Pham
2021-01-10 1:20 ` Leif Lindholm
1 sibling, 1 reply; 4+ messages in thread
From: Laszlo Ersek @ 2021-01-08 14:02 UTC (permalink / raw)
To: devel, nhi; +Cc: Leif Lindholm, Ard Biesheuvel
On 01/08/21 14:41, Nhi Pham via groups.io wrote:
> The EfiGetVariable() is used in the entry of this module. So, the
> variable services are required to be ready before they are used. This
> patch adds the arch protocol gEfiVariableArchProtocolGuid to dependency
> expression to guarantee that this module will be started once the
> variable protocol is available.
>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Signed-off-by: Nhi Pham <nhi@os.amperecomputing.com>
> ---
> EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf b/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf
> index fec53c79d335..0a4cd6dae703 100644
> --- a/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf
> +++ b/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf
> @@ -38,5 +38,5 @@ [Protocols]
> gEfiRealTimeClockArchProtocolGuid
>
> [Depex]
> - TRUE
> + gEfiVariableArchProtocolGuid
>
>
Will you send a patch for "OvmfPkg/OvmfXen.dsc", for the regression that
you commit 55ee36b0c490 caused?
For this patch:
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg/RealTimeClockRuntimeDxe: depend on gEfiVariableArchProtocolGuid
2021-01-08 14:02 ` [edk2-devel] " Laszlo Ersek
@ 2021-01-08 14:07 ` Nhi Pham
0 siblings, 0 replies; 4+ messages in thread
From: Nhi Pham @ 2021-01-08 14:07 UTC (permalink / raw)
To: Laszlo Ersek, devel; +Cc: Leif Lindholm, Ard Biesheuvel
On 1/8/21 21:02, Laszlo Ersek wrote:
> On 01/08/21 14:41, Nhi Pham via groups.io wrote:
>> The EfiGetVariable() is used in the entry of this module. So, the
>> variable services are required to be ready before they are used. This
>> patch adds the arch protocol gEfiVariableArchProtocolGuid to dependency
>> expression to guarantee that this module will be started once the
>> variable protocol is available.
>>
>> Cc: Leif Lindholm <leif@nuviainc.com>
>> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
>> Signed-off-by: Nhi Pham <nhi@os.amperecomputing.com>
>> ---
>> EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf b/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf
>> index fec53c79d335..0a4cd6dae703 100644
>> --- a/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf
>> +++ b/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf
>> @@ -38,5 +38,5 @@ [Protocols]
>> gEfiRealTimeClockArchProtocolGuid
>>
>> [Depex]
>> - TRUE
>> + gEfiVariableArchProtocolGuid
>>
>>
> Will you send a patch for "OvmfPkg/OvmfXen.dsc", for the regression that
> you commit 55ee36b0c490 caused?
Yes, I will generate a patch for it.
-Nhi
>
>
> For this patch:
>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] EmbeddedPkg/RealTimeClockRuntimeDxe: depend on gEfiVariableArchProtocolGuid
2021-01-08 13:41 [PATCH 1/1] EmbeddedPkg/RealTimeClockRuntimeDxe: depend on gEfiVariableArchProtocolGuid Nhi Pham
2021-01-08 14:02 ` [edk2-devel] " Laszlo Ersek
@ 2021-01-10 1:20 ` Leif Lindholm
1 sibling, 0 replies; 4+ messages in thread
From: Leif Lindholm @ 2021-01-10 1:20 UTC (permalink / raw)
To: Nhi Pham; +Cc: devel, Ard Biesheuvel
On Fri, Jan 08, 2021 at 20:41:15 +0700, Nhi Pham wrote:
> The EfiGetVariable() is used in the entry of this module. So, the
> variable services are required to be ready before they are used. This
> patch adds the arch protocol gEfiVariableArchProtocolGuid to dependency
> expression to guarantee that this module will be started once the
> variable protocol is available.
>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Signed-off-by: Nhi Pham <nhi@os.amperecomputing.com>
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
Pushed as 4ea3a6ded844.
Thanks!
> ---
> EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf b/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf
> index fec53c79d335..0a4cd6dae703 100644
> --- a/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf
> +++ b/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf
> @@ -38,5 +38,5 @@ [Protocols]
> gEfiRealTimeClockArchProtocolGuid
>
> [Depex]
> - TRUE
> + gEfiVariableArchProtocolGuid
>
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-10 1:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-08 13:41 [PATCH 1/1] EmbeddedPkg/RealTimeClockRuntimeDxe: depend on gEfiVariableArchProtocolGuid Nhi Pham
2021-01-08 14:02 ` [edk2-devel] " Laszlo Ersek
2021-01-08 14:07 ` Nhi Pham
2021-01-10 1:20 ` Leif Lindholm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox