From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.groups.io with SMTP id smtpd.web09.123.1610114568060933333 for ; Fri, 08 Jan 2021 06:02:48 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=BZGuKdA5; spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610114567; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e91o7dbF/qniAGhJOip/2myY8XUTV62LVhbxIGfdZOk=; b=BZGuKdA5fD70VIocA1+ztnW4r0GZXaiT+hFgApW+7Eeg7B49nhTqs21sGHs+pIMquU9lLw CRrdMVayMRBa1J/m/SePqAXYyPucY/vqUwUswxvqhDDRILiwiT4Jq3wEtiiI8krDMaXGTy KJoJxsCGOebbRmIOB103KBudCt5+dE0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-564-6OX6k6OwORKlGoyC1c9GXw-1; Fri, 08 Jan 2021 09:02:43 -0500 X-MC-Unique: 6OX6k6OwORKlGoyC1c9GXw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6E2B559; Fri, 8 Jan 2021 14:02:42 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-112.ams2.redhat.com [10.36.113.112]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7363F5C8AA; Fri, 8 Jan 2021 14:02:41 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg/RealTimeClockRuntimeDxe: depend on gEfiVariableArchProtocolGuid To: devel@edk2.groups.io, nhi@os.amperecomputing.com Cc: Leif Lindholm , Ard Biesheuvel References: <20210108134115.8011-1-nhi@os.amperecomputing.com> From: "Laszlo Ersek" Message-ID: <485d1426-5bef-3248-f37b-ea29a51f7faf@redhat.com> Date: Fri, 8 Jan 2021 15:02:40 +0100 MIME-Version: 1.0 In-Reply-To: <20210108134115.8011-1-nhi@os.amperecomputing.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 01/08/21 14:41, Nhi Pham via groups.io wrote: > The EfiGetVariable() is used in the entry of this module. So, the > variable services are required to be ready before they are used. This > patch adds the arch protocol gEfiVariableArchProtocolGuid to dependency > expression to guarantee that this module will be started once the > variable protocol is available. > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Signed-off-by: Nhi Pham > --- > EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf b/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf > index fec53c79d335..0a4cd6dae703 100644 > --- a/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf > +++ b/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf > @@ -38,5 +38,5 @@ [Protocols] > gEfiRealTimeClockArchProtocolGuid > > [Depex] > - TRUE > + gEfiVariableArchProtocolGuid > > Will you send a patch for "OvmfPkg/OvmfXen.dsc", for the regression that you commit 55ee36b0c490 caused? For this patch: Reviewed-by: Laszlo Ersek