From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: redhat.com, ip: 209.85.221.48, mailfrom: philmd@redhat.com)
Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48])
 by groups.io with SMTP; Tue, 16 Jul 2019 02:41:23 -0700
Received: by mail-wr1-f48.google.com with SMTP id 31so20203425wrm.1
        for <devel@edk2.groups.io>; Tue, 16 Jul 2019 02:41:23 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:subject:from:to:cc:references:openpgp:message-id
         :date:user-agent:mime-version:in-reply-to:content-language
         :content-transfer-encoding;
        bh=ABEp6RlJhTNDBJSuPX27Zglnsug86+7d0zs59hYy2GQ=;
        b=CWzRpvy9IvZyMDwEokEcdmh2dDewjtiHQuB3PVsxnORCnY05BWniWR+cpotUI6XmUC
         9GpqrATQz5Dpg40q77j3M/fWOPCKG5emEUMDE7ALjuigZM5uxru8v6DWVqYDYq79/fkS
         Wvr/hi4EGfY9trF6XW9gOCdud0j5fa7N4OBvY9RgsShNTVNc1VnTxjD5j+9AmehERZh6
         cGfwcsiKUdwbNZ6G6wKCsfcxMENuRs4jtr36QP1Nbo4KDjeQhusFUr2qEXGOPiR1vNPz
         dN4NfKT/irEKm4M4DBSMiEZr25VJtZRSrcWqgjhyfzz8bwG1bj/0wcBWDaFB2e6rXpes
         qHsg==
X-Gm-Message-State: APjAAAXtANiOzIY9DjRefX6q5wivmkRW2Mv6PmBCkhphOLLuDm6/xcIo
	B25GOWjkVB4EbJHnm14wK3/YOg==
X-Google-Smtp-Source: APXvYqwY2iWjJkKcbd35c9GzSqh/TNrW2tL4P5tWpJJn1N6iDX2IL8A1dS5aKwXbjDqVQsLwBPml3Q==
X-Received: by 2002:adf:b612:: with SMTP id f18mr23252418wre.97.1563270081809;
        Tue, 16 Jul 2019 02:41:21 -0700 (PDT)
Return-Path: <philmd@redhat.com>
Received: from [192.168.1.37] (62.red-83-42-61.dynamicip.rima-tde.net. [83.42.61.62])
        by smtp.gmail.com with ESMTPSA id z6sm15961371wrw.2.2019.07.16.02.41.20
        (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128);
        Tue, 16 Jul 2019 02:41:20 -0700 (PDT)
Subject: Re: [PATCH 1/3] MdePkg/BaseLib: re-specify Base64Decode(), and add temporary stub impl
From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= <philmd@redhat.com>
To: Laszlo Ersek <lersek@redhat.com>,
 edk2-devel-groups-io <devel@edk2.groups.io>
Cc: Liming Gao <liming.gao@intel.com>, =?UTF-8?Q?Marvin_H=c3=a4user?=
 <mhaeuser@outlook.de>, Michael D Kinney <michael.d.kinney@intel.com>,
 Zhichao Gao <zhichao.gao@intel.com>
References: <20190702102836.27589-1-lersek@redhat.com>
 <20190702102836.27589-2-lersek@redhat.com>
 <6dd4f56b-b7df-7986-11cf-1780981c1d0e@redhat.com>
Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE;
 url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE
Message-ID: <4865d268-7867-a8c3-c1f0-2613d7667679@redhat.com>
Date: Tue, 16 Jul 2019 11:41:20 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.0
MIME-Version: 1.0
In-Reply-To: <6dd4f56b-b7df-7986-11cf-1780981c1d0e@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit

Hi Laszlo,

On 7/16/19 10:38 AM, Philippe Mathieu-Daudé wrote:
> On 7/2/19 12:28 PM, Laszlo Ersek wrote:
>> Rewrite Base64Decode() from scratch, due to reasons listed in the second
>> reference below.
>>
>> As first step, redo the interface contract, and replace the current
>> implementation with a stub that asserts FALSE, then fails.
>>
>> Cc: Liming Gao <liming.gao@intel.com>
>> Cc: Marvin Häuser <mhaeuser@outlook.de>
>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
>> Cc: Zhichao Gao <zhichao.gao@intel.com>
>> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1891
>> Ref: http://mid.mail-archive.com/c495bd0b-ea4d-7206-8a4f-a7149760d19a@redhat.com
>> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
>> ---
>>  MdePkg/Include/Library/BaseLib.h |  99 +++++--
>>  MdePkg/Library/BaseLib/String.c  | 285 ++++++--------------
>>  2 files changed, 168 insertions(+), 216 deletions(-)

You forgot to update the copyright in both files.