public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Liming Gao" <liming.gao@intel.com>
To: "Feng, Bob C" <bob.c.feng@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Dong, Guo" <guo.dong@intel.com>
Subject: Re: [Patch 1/1] BaseTools: Fixed a Incremental build issue
Date: Fri, 7 Feb 2020 09:29:41 +0000	[thread overview]
Message-ID: <48a4ee64e965449ca8ec584a0f984b61@intel.com> (raw)
In-Reply-To: <20200207084145.17576-1-bob.c.feng@intel.com>

Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: Feng, Bob C <bob.c.feng@intel.com>
> Sent: Friday, February 7, 2020 4:42 PM
> To: edk2-devel@lists.01.org; devel@edk2.groups.io
> Cc: Feng, Bob C <bob.c.feng@intel.com>; Dong, Guo <guo.dong@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [Patch 1/1] BaseTools: Fixed a Incremental build issue
> 
> From: Bob Feng <bob.c.feng@intel.com>
> 
> The .map file is not update to FFS_OUTPUT_DIR folder
> in the incremental build.
> 
> Signed-off-by: Guo Dong <guo.dong@intel.com>
> Signed-off-by: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> ---
>  BaseTools/Source/Python/AutoGen/GenMake.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/BaseTools/Source/Python/AutoGen/GenMake.py b/BaseTools/Source/Python/AutoGen/GenMake.py
> index ba199c1aa73d..9ae09c47caf8 100755
> --- a/BaseTools/Source/Python/AutoGen/GenMake.py
> +++ b/BaseTools/Source/Python/AutoGen/GenMake.py
> @@ -718,11 +718,11 @@ cleanlib:
>                      Src = self.ReplaceMacro(Src)
>                      Dst = self.ReplaceMacro(Dst)
>                      if Dst not in self.ResultFileList:
>                          self.ResultFileList.append(Dst)
>                      if '%s :' %(Dst) not in self.BuildTargetList:
> -                        self.BuildTargetList.append("%s :" %(Dst))
> +                        self.BuildTargetList.append("%s : %s" %(Dst,Src))
>                          self.BuildTargetList.append('\t' + self._CP_TEMPLATE_[self._FileType] %{'Src': Src, 'Dst': Dst})
> 
>              FfsCmdList = Cmd[0]
>              for index, Str in enumerate(FfsCmdList):
>                  if '-o' == Str:
> --
> 2.18.0.windows.1


  reply	other threads:[~2020-02-07  9:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-07  8:41 [Patch 1/1] BaseTools: Fixed a Incremental build issue Bob Feng
2020-02-07  9:29 ` Liming Gao [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-02-07  8:45 Bob Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48a4ee64e965449ca8ec584a0f984b61@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox