From: "Laszlo Ersek" <lersek@redhat.com>
To: Walon Li <walon.li@hpe.com>, devel@edk2.groups.io
Cc: sunnywang@hpe.com, ray.ni@intel.com, hao.a.wu@intel.com,
gaoliming@byosoft.com.cn
Subject: Re: [PATCH v2] MdeModulePkg/UefiBootManagerLib: Put BootMenu at the end of BootOrder
Date: Fri, 19 Feb 2021 17:49:07 +0100 [thread overview]
Message-ID: <48a9a3dc-57b1-4d34-d51e-2a3418d1e696@redhat.com> (raw)
In-Reply-To: <20210219093931.1458-1-walon.li@hpe.com>
On 02/19/21 10:39, Walon Li wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3135
>
> When Boot Menu does not exist in the BootOrder, BmRegisterBootManagerMenu
> will create one into list. However, it should be put at the "end" of
> BootOrder instead of "start" of BootOrder. Replace 0 by -1 to adjust
> order of load options.
>
> Signed-off-by: Walon Li <walon.li@hpe.com>
> ---
> MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
> index aff620ad52..6cc34d29c0 100644
> --- a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
> +++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
> @@ -3,7 +3,7 @@
>
> Copyright (c) 2019, NVIDIA CORPORATION. All rights reserved.
> Copyright (c) 2011 - 2020, Intel Corporation. All rights reserved.<BR>
> -(C) Copyright 2015-2016 Hewlett Packard Enterprise Development LP<BR>
> +(C) Copyright 2015-2021 Hewlett Packard Enterprise Development LP<BR>
> SPDX-License-Identifier: BSD-2-Clause-Patent
>
> **/
> @@ -2505,7 +2505,7 @@ BmRegisterBootManagerMenu (
> EfiBootManagerFreeLoadOptions (BootOptions, BootOptionCount);
> );
>
> - return EfiBootManagerAddLoadOptionVariable (BootOption, 0);
> + return EfiBootManagerAddLoadOptionVariable (BootOption, (UINTN) -1);
> }
>
> /**
>
Acked-by: Laszlo Ersek <lersek@redhat.com>
next prev parent reply other threads:[~2021-02-19 16:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-19 9:39 [PATCH v2] MdeModulePkg/UefiBootManagerLib: Put BootMenu at the end of BootOrder Li, Walon
2021-02-19 16:49 ` Laszlo Ersek [this message]
2021-02-22 9:29 ` Wang, Sunny (HPS SW)
2021-02-22 10:00 ` 回复: [edk2-devel] " gaoliming
[not found] ` <1666098D782F198A.19946@groups.io>
2021-02-26 5:17 ` gaoliming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48a9a3dc-57b1-4d34-d51e-2a3418d1e696@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox