[PATCH v2] MdeModulePkg/UefiBootManagerLib: Put BootMenu at the end of BootOrder

[PATCH v2] MdeModulePkg/UefiBootManagerLib: Put BootMenu at the end of BootOrder

[Li, Walon]

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3135

When Boot Menu does not exist in the BootOrder, BmRegisterBootManagerMenu
will create one into list. However, it should be put at the "end" of
BootOrder instead of "start" of BootOrder. Replace 0 by -1 to adjust
order of load options.

Signed-off-by: Walon Li <walon.li@hpe.com>
---
 MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
index aff620ad52..6cc34d29c0 100644
--- a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
+++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
@@ -3,7 +3,7 @@
 
 Copyright (c) 2019, NVIDIA CORPORATION. All rights reserved.
 Copyright (c) 2011 - 2020, Intel Corporation. All rights reserved.<BR>
-(C) Copyright 2015-2016 Hewlett Packard Enterprise Development LP<BR>
+(C) Copyright 2015-2021 Hewlett Packard Enterprise Development LP<BR>
 SPDX-License-Identifier: BSD-2-Clause-Patent
 
 **/
@@ -2505,7 +2505,7 @@ BmRegisterBootManagerMenu (
     EfiBootManagerFreeLoadOptions (BootOptions, BootOptionCount);
     );
 
-  return EfiBootManagerAddLoadOptionVariable (BootOption, 0);
+  return EfiBootManagerAddLoadOptionVariable (BootOption, (UINTN) -1);
 }
 
 /**
-- 
2.23.0.windows.1

Re: [PATCH v2] MdeModulePkg/UefiBootManagerLib: Put BootMenu at the end of BootOrder

[Laszlo Ersek]

On 02/19/21 10:39, Walon Li wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3135
> 
> When Boot Menu does not exist in the BootOrder, BmRegisterBootManagerMenu
> will create one into list. However, it should be put at the "end" of
> BootOrder instead of "start" of BootOrder. Replace 0 by -1 to adjust
> order of load options.
> 
> Signed-off-by: Walon Li <walon.li@hpe.com>
> ---
>  MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
> index aff620ad52..6cc34d29c0 100644
> --- a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
> +++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
> @@ -3,7 +3,7 @@
>  
>  Copyright (c) 2019, NVIDIA CORPORATION. All rights reserved.
>  Copyright (c) 2011 - 2020, Intel Corporation. All rights reserved.<BR>
> -(C) Copyright 2015-2016 Hewlett Packard Enterprise Development LP<BR>
> +(C) Copyright 2015-2021 Hewlett Packard Enterprise Development LP<BR>
>  SPDX-License-Identifier: BSD-2-Clause-Patent
>  
>  **/
> @@ -2505,7 +2505,7 @@ BmRegisterBootManagerMenu (
>      EfiBootManagerFreeLoadOptions (BootOptions, BootOptionCount);
>      );
>  
> -  return EfiBootManagerAddLoadOptionVariable (BootOption, 0);
> +  return EfiBootManagerAddLoadOptionVariable (BootOption, (UINTN) -1);
>  }
>  
>  /**
> 

Acked-by: Laszlo Ersek <lersek@redhat.com>

Re: [PATCH v2] MdeModulePkg/UefiBootManagerLib: Put BootMenu at the end of BootOrder

[Wang, Sunny (HPS SW)]

Yeah, the problem is that always adding the Boot Menu to the top of BootOrder causes confusion to the users who manipulate the Boot Order under OS. Also, we can't find any reason why the Boot Menu needs to be always added to the top of the Boot Order even if we check the change history and emails. 
 
Reviewed-by: Sunny Wang <sunnywang@hpe.com>


-----Original Message-----
From: Li, Walon <walon.li@hpe.com> 
Sent: Friday, February 19, 2021 5:40 PM
To: devel@edk2.groups.io
Cc: Li, Walon <walon.li@hpe.com>; Wang, Sunny (HPS SW) <sunnywang@hpe.com>; lersek@redhat.com; ray.ni@intel.com; hao.a.wu@intel.com; gaoliming@byosoft.com.cn
Subject: [PATCH v2] MdeModulePkg/UefiBootManagerLib: Put BootMenu at the end of BootOrder

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3135

When Boot Menu does not exist in the BootOrder, BmRegisterBootManagerMenu will create one into list. However, it should be put at the "end" of BootOrder instead of "start" of BootOrder. Replace 0 by -1 to adjust order of load options.

Signed-off-by: Walon Li <walon.li@hpe.com>
---
 MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
index aff620ad52..6cc34d29c0 100644
--- a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
+++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
@@ -3,7 +3,7 @@
  Copyright (c) 2019, NVIDIA CORPORATION. All rights reserved. Copyright (c) 2011 - 2020, Intel Corporation. All rights reserved.<BR>-(C) Copyright 2015-2016 Hewlett Packard Enterprise Development LP<BR>+(C) Copyright 2015-2021 Hewlett Packard Enterprise Development LP<BR> SPDX-License-Identifier: BSD-2-Clause-Patent  **/@@ -2505,7 +2505,7 @@ BmRegisterBootManagerMenu (
     EfiBootManagerFreeLoadOptions (BootOptions, BootOptionCount);     ); -  return EfiBootManagerAddLoadOptionVariable (BootOption, 0);+  return EfiBootManagerAddLoadOptionVariable (BootOption, (UINTN) -1); }  /**-- 
2.23.0.windows.1

回复: [edk2-devel] [PATCH v2] MdeModulePkg/UefiBootManagerLib: Put BootMenu at the end of BootOrder

[gaoliming]

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: bounce+27952+71931+4905953+8761045@groups.io
> <bounce+27952+71931+4905953+8761045@groups.io> 代表 Wang, Sunny
> (HPS SW)
> 发送时间: 2021年2月22日 17:30
> 收件人: Li, Walon <walon.li@hpe.com>; devel@edk2.groups.io
> 抄送: lersek@redhat.com; ray.ni@intel.com; hao.a.wu@intel.com;
> gaoliming@byosoft.com.cn; Wang, Sunny (HPS SW) <sunnywang@hpe.com>
> 主题: Re: [edk2-devel] [PATCH v2] MdeModulePkg/UefiBootManagerLib: Put
> BootMenu at the end of BootOrder
> 
> Yeah, the problem is that always adding the Boot Menu to the top of
> BootOrder causes confusion to the users who manipulate the Boot Order
> under OS. Also, we can't find any reason why the Boot Menu needs to be
> always added to the top of the Boot Order even if we check the change
> history and emails.
> 
> Reviewed-by: Sunny Wang <sunnywang@hpe.com>
> 
> 
> -----Original Message-----
> From: Li, Walon <walon.li@hpe.com>
> Sent: Friday, February 19, 2021 5:40 PM
> To: devel@edk2.groups.io
> Cc: Li, Walon <walon.li@hpe.com>; Wang, Sunny (HPS SW)
> <sunnywang@hpe.com>; lersek@redhat.com; ray.ni@intel.com;
> hao.a.wu@intel.com; gaoliming@byosoft.com.cn
> Subject: [PATCH v2] MdeModulePkg/UefiBootManagerLib: Put BootMenu at
> the end of BootOrder
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3135
> 
> When Boot Menu does not exist in the BootOrder,
> BmRegisterBootManagerMenu will create one into list. However, it should be
> put at the "end" of BootOrder instead of "start" of BootOrder. Replace 0
by -1
> to adjust order of load options.
> 
> Signed-off-by: Walon Li <walon.li@hpe.com>
> ---
>  MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
> b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
> index aff620ad52..6cc34d29c0 100644
> --- a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
> +++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
> @@ -3,7 +3,7 @@
>   Copyright (c) 2019, NVIDIA CORPORATION. All rights reserved. Copyright
(c)
> 2011 - 2020, Intel Corporation. All rights reserved.<BR>-(C) Copyright
> 2015-2016 Hewlett Packard Enterprise Development LP<BR>+(C) Copyright
> 2015-2021 Hewlett Packard Enterprise Development LP<BR>
> SPDX-License-Identifier: BSD-2-Clause-Patent  **/@@ -2505,7 +2505,7 @@
> BmRegisterBootManagerMenu (
>      EfiBootManagerFreeLoadOptions (BootOptions,
> BootOptionCount);     ); -  return EfiBootManagerAddLoadOptionVariable
> (BootOption, 0);+  return EfiBootManagerAddLoadOptionVariable
> (BootOption, (UINTN) -1); }  /**--
> 2.23.0.windows.1
> 
> 
> 
> 
> 

回复: [edk2-devel] [PATCH v2] MdeModulePkg/UefiBootManagerLib: Put BootMenu at the end of BootOrder

[gaoliming]

Merge @ 7f34681c488aee2563eaa2afcc6a2c8aa7c5b912

Thanks
Liming
> -----邮件原件-----
> 发件人: bounce+27952+71937+4905953+8761045@groups.io
> <bounce+27952+71937+4905953+8761045@groups.io> 代表 gaoliming
> 发送时间: 2021年2月22日 18:00
> 收件人: devel@edk2.groups.io; sunnywang@hpe.com; 'Li, Walon'
> <walon.li@hpe.com>
> 抄送: lersek@redhat.com; ray.ni@intel.com; hao.a.wu@intel.com
> 主题: 回复: [edk2-devel] [PATCH v2] MdeModulePkg/UefiBootManagerLib:
> Put BootMenu at the end of BootOrder
> 
> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> 
> > -----邮件原件-----
> > 发件人: bounce+27952+71931+4905953+8761045@groups.io
> > <bounce+27952+71931+4905953+8761045@groups.io> 代表 Wang,
> Sunny
> > (HPS SW)
> > 发送时间: 2021年2月22日 17:30
> > 收件人: Li, Walon <walon.li@hpe.com>; devel@edk2.groups.io
> > 抄送: lersek@redhat.com; ray.ni@intel.com; hao.a.wu@intel.com;
> > gaoliming@byosoft.com.cn; Wang, Sunny (HPS SW) <sunnywang@hpe.com>
> > 主题: Re: [edk2-devel] [PATCH v2] MdeModulePkg/UefiBootManagerLib:
> Put
> > BootMenu at the end of BootOrder
> >
> > Yeah, the problem is that always adding the Boot Menu to the top of
> > BootOrder causes confusion to the users who manipulate the Boot Order
> > under OS. Also, we can't find any reason why the Boot Menu needs to be
> > always added to the top of the Boot Order even if we check the change
> > history and emails.
> >
> > Reviewed-by: Sunny Wang <sunnywang@hpe.com>
> >
> >
> > -----Original Message-----
> > From: Li, Walon <walon.li@hpe.com>
> > Sent: Friday, February 19, 2021 5:40 PM
> > To: devel@edk2.groups.io
> > Cc: Li, Walon <walon.li@hpe.com>; Wang, Sunny (HPS SW)
> > <sunnywang@hpe.com>; lersek@redhat.com; ray.ni@intel.com;
> > hao.a.wu@intel.com; gaoliming@byosoft.com.cn
> > Subject: [PATCH v2] MdeModulePkg/UefiBootManagerLib: Put BootMenu at
> > the end of BootOrder
> >
> > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3135
> >
> > When Boot Menu does not exist in the BootOrder,
> > BmRegisterBootManagerMenu will create one into list. However, it should
> be
> > put at the "end" of BootOrder instead of "start" of BootOrder. Replace 0
> by -1
> > to adjust order of load options.
> >
> > Signed-off-by: Walon Li <walon.li@hpe.com>
> > ---
> >  MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
> > b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
> > index aff620ad52..6cc34d29c0 100644
> > --- a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
> > +++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
> > @@ -3,7 +3,7 @@
> >   Copyright (c) 2019, NVIDIA CORPORATION. All rights reserved. Copyright
> (c)
> > 2011 - 2020, Intel Corporation. All rights reserved.<BR>-(C) Copyright
> > 2015-2016 Hewlett Packard Enterprise Development LP<BR>+(C) Copyright
> > 2015-2021 Hewlett Packard Enterprise Development LP<BR>
> > SPDX-License-Identifier: BSD-2-Clause-Patent  **/@@ -2505,7 +2505,7
> @@
> > BmRegisterBootManagerMenu (
> >      EfiBootManagerFreeLoadOptions (BootOptions,
> > BootOptionCount);     ); -  return
> EfiBootManagerAddLoadOptionVariable
> > (BootOption, 0);+  return EfiBootManagerAddLoadOptionVariable
> > (BootOption, (UINTN) -1); }  /**--
> > 2.23.0.windows.1
> >
> >
> >
> >
> >
> 
> 
> 
> 
> 
> 
>